mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-26 14:45:59 +03:00
[GH-ISSUE #1422] When Chrome and Firefox alternately sync, the extension freezes #940
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#940
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @yjulm on GitHub (Oct 26, 2023).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1422
Which version of floccus are you using?
4.19.1
Sync method
WebDAV
Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.
Windows 8.1
Chrome 109.0.5414.120
LibreWolf 115.0.2-2
Which version of Nextcloud Bookmarks are you using? (if relevant)
No response
Which version of Nextcloud? (if relevant)
No response
What kind of WebDAV server are you using? (if relevant)
No response
Describe the Bug
I'm not a native English speaker, so I used Google Translate.
After I deleted the bookmarks.xbel file in WebDAV, I opened Firefox and Chrome browsers on the desktop.
First click the sync button in Chrome, then Chrome can synchronize data to WebDAV normally. Delete the bookmarks.xbel file in WebDAV again, and then click the sync button in Firefox. At this time, Firefox can also synchronize bookmarks to WebDAV. So when there is no bookmarks.xbel file in WebDAV, Chrome and Firefox can upload data normally.
Note that currently WebDAV stores Firefox data.
The problem will occur in the following operation. Return to Chrome and manually click the sync button. The extension will freeze after a few seconds. In the task manager, you can see that the CPU usage of the extension process is very high and stable at a constant value. It looks like it's entering a while(true) loop.
Below is my additional test operation
Delete the file now. Sync data in Chrome first, then click the button in Firefox. At this time, extensions in Firefox will also freeze.
It looks like both browsers are uploading some data that the other can't process.
Expected Behavior
Both sync data normally
To Reproduce
Already explained
Debug log provided
@marcelklehr commented on GitHub (Nov 5, 2023):
How many bookmarks do you have?
@yjulm commented on GitHub (Nov 6, 2023):
1667
@marcelklehr commented on GitHub (Dec 5, 2023):
When the xbel file exists already on the server, floccus tries to consolidate the local bookmarks with the server-side bookmarks. This can be a resource-heavy process, but it should end at some point. Could you try to open the debug console to check the logs and see what's going on?
Firefox
about:debuggingThis firefoxdebugbutton next to floccus entry to open the consolesync nowfor the account of your choice.Chrome
chrome://extensionsDeveloper modedist/html/background.htmlbutton in floccus' entry next to "Inspect views: " to open the consolesync nowfor the account of your choice@yjulm commented on GitHub (Dec 6, 2023):
After my testing, I determined the steps to reproduce the bug.
In Firefox and Chrome browsers, set the "Local folder" in the extension's "Folder mapping" to "/"
Delete the data file "bookmarks.xbel" in WebDAV
Manually click the Sync button in Chrome, successfully upload the data and generate the file "bookmarks.xbel" in WebDAV
When manually clicking the Sync button in Firefox, the extension freezes. CPU usage remains at a fixed value. After a long period of time, the program stops freezing and shows sync failed.
Although synchronization fails, the bookmarks have been disrupted. For example, many bookmarks are placed in the first folder named "Android" in the bookmark bar. These bookmarks were not originally in this folder. This phenomenon can also be observed through debug logs.
If you set the "Local folder" in step 1 to the corresponding "Bookmarks Bar" of Firefox and Chrome browsers, both browsers can quickly synchronize data without freezing.
@marcelklehr commented on GitHub (Dec 6, 2023):
I'm sorry this doesn't work for me. Can you please upload the full, unbutchered log files here, if you want you can generate anonymized logs, but please do not delete any parts.
@yjulm commented on GitHub (Dec 7, 2023):
This time I re-executed steps 1 to 5, and the bookmarks in step 5 were not disrupted. I used the "Bookmark Dupes" extension to help me check if bookmarks are being added repeatedly to different folders
Retest log file
chrome-floccus-4.19.1-2023-12-06.log
firefox-floccus-4.19.1-2023-12-07.log
@marcelklehr commented on GitHub (May 15, 2024):
Huh. Your Cache is corrupt for some reason
@marcelklehr commented on GitHub (May 15, 2024):
Your cache contains only the Android folder, direclty below the root. Whereas it should contain the bookmarks bar etc. I cannot reproduce this, even with your steps above.
@marcelklehr commented on GitHub (May 15, 2024):
You can clear your cache in the settings and it should work again.
@github-actions[bot] commented on GitHub (May 16, 2025):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.