mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 14:16:12 +03:00
[GH-ISSUE #1364] No Sync from Brave Browser on 3 PCs all with v4.19.0 #900
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#900
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dsiminiuk on GitHub (Mar 28, 2023).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1364
Which version of floccus are you using?
4.19.0
Sync method
Nextcloud Bookmarks
Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.
Brave
Which version of Nextcloud Bookmarks are you using? (if relevant)
12.1.0
Which version of Nextcloud? (if relevant)
25.0.5
What kind of WebDAV server are you using? (if relevant)
No response
Describe the Bug
No sync up or down even when I add or remove bookmarks from the NC Booksmarks app. I've uninstalled, reinstalled, no differnce.
Expected Behavior
It should sync like it used to.
To Reproduce
Click the Floccus add-in button and sync, push up or push down, no sync. One laptop with Brave now shows "Disabled". ???
Debug log provided
@dsiminiuk commented on GitHub (Mar 28, 2023):
I reverted to v4.18.1 and it works fine again on the laptop that was "Disabled". OK Disabled just means Auto-sync is off.
And it gets worse for Brave on Windows. Because v4.18.1 is no longer on the Chrome Webstore you can't even install the crx file of the previous version in the Extensions page with Developer mode on.
2 PCs on Linux with brave are now working.
2 Windows PCs are disconnected from my NC Bookmarks with no floccus extension.
@eihnat commented on GitHub (Mar 28, 2023):
same issue here. reverting back to v4.18.1 solved and sync works.
@BOFH90 commented on GitHub (Mar 28, 2023):
Same issue on macOS and Windows with Nextcloud, Brave and v4.19.0
@baritell commented on GitHub (Mar 28, 2023):
Wanted to chime in here in case this might help.
I first noticed 4.19 was not working for me on a new windows box when I tried to run my first pull. It showed success and the logs had all my bookmarks but nothing showed up on the Chrome or Firefox "Toolbar".
I then tested a bit on my linux box via Chrome and Firefox and found something odd. If I already have a folder on the root of the bookmarks toolbar I can add and delete bookmarks and it works as expected. However, If I try to add or remove anything from the root of the toolbar it is not working.
Hope that might help someone who knows more than me. Thanks
I should add that I am also using the nextcloud bookmarks currently on version 13.0.1. Nextcloud version: 26.0.0.11
floccus-4.19.0-2023-03-28.log
@dsiminiuk commented on GitHub (Mar 28, 2023):
@baritell Agreed! I played with 4.19.0 some more on Windows and it does work for bookmarks in folders below the Bookmark Bar but not for changes on the bookmark bar. Good find!
@marcelklehr commented on GitHub (Mar 28, 2023):
Thanks for reporting this. I have a fix in mind but don't know when I'll get to applying and releasing it. Fingers crossed
@dsiminiuk commented on GitHub (Mar 28, 2023):
@marcelklehr
Just confirmed on Windows 10, Brave Browser and floccus 4.19.0 - when adding a new bookmark to the bookmark bar, it does not upload it to the server. Move the same bookmark to a folder and voila!
Delete the bookmark from the folder on the server, re-sync, and it is removed from the client end also.
@cimenta commented on GitHub (Mar 29, 2023):
could you please provide steps how to revert?
I downloaded crx file of v4.18.1 file from https://github.com/floccusaddon/floccus/releases but got this error https://i.imgur.com/z3QivOo.png
@eihnat commented on GitHub (Mar 29, 2023):
Managed to do this only in Firefox.
https://addons.mozilla.org/en-US/firefox/addon/floccus/?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=search
on extension page there's on left lower side "see all versions" and you can pick which one you want. you need to uninstall newer one first i think.
Didn't find how to do it on Brave (Chrome probably same).
@dsiminiuk commented on GitHub (Mar 29, 2023):
I was a Vivaldi user until recently. They had a bug that wiped all my bookmarks so I jumped to Brave. That was fine until this bug in 4.19.0 showed up. And even then it is OK on Linux. You can go to your Extensions page and enable Developer Mode, export your settings from floccus, remove it, download the crx file for the release you want, and drop it on the Developer Mode Extensions page.
But with the Windows version of Brave, it won't let you install a crx extension for any version different than the one currently published on the Chrome Webstore. Here is a thread about that https://github.com/brave/brave-browser/issues/20296.
Last night I tried Midori - didn't like it's lack of features, search engine limitations specifically. Then I tried SRWare Iron, and it allowed me to install the crx file the usual way, but when I did a forced download of my bookmarks they didn't appear on my Bookmarks bar. Perhaps I could have figured out what was happening there but it was late and I'd had enough messing around.
One workaround might be for @marcelklehr to pull the v4.19.0 off the Chrome Store and re-publish v4.18.1 so I could get that version back on my Windows/Brave machines.
@marcelklehr commented on GitHub (Mar 29, 2023):
Which folder do you have selected as your local sync target in this scenario?
@dsiminiuk commented on GitHub (Mar 29, 2023):
@marcelklehr Here is a snip...
@marcelklehr commented on GitHub (Mar 29, 2023):
Thanks!
@baritell commented on GitHub (Mar 29, 2023):
For me I have it set to
/Bookmarks Toolbar/. Just fyi, in case it matters. Thanks for your help!@marcelklehr commented on GitHub (Mar 29, 2023):
@baritell Thanks for confirming, this affects everyone syncing the main / built-in folders (but not the absolute untitled root folder).
@dsiminiuk commented on GitHub (Mar 29, 2023):
@baritell The name of it is browser dependent.
@marcelklehr commented on GitHub (Mar 29, 2023):
It seems I'm unable to publish a new release without having to push out a patch a few days later ... 🙈 Preparing a release with the fix as we speak
@marcelklehr commented on GitHub (Mar 30, 2023):
Should be fixed with v4.19.1 -- coming to a machine near you soon-ish.
@dsiminiuk commented on GitHub (Mar 30, 2023):
@marcelklehr Now that v4.19.1 is available on the Chrome Webstore I was able to install it on the WIndows/Brave PCs and all is good. I did remove the 4.19.0 and add back 4.19.1 importing a previously exported .json file and then did a one time pull initially, now everything syncs perfectly.
Thank you for your quick action. This extension (and Bitwarden for passwords) keep me sane. Another contribution is on the way.
@marcelklehr commented on GitHub (Mar 30, 2023):
thank you 💙 I'm glad you like it!
@github-actions[bot] commented on GitHub (Mar 30, 2024):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.