mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 22:26:06 +03:00
[GH-ISSUE #1310] Sync interval #873
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#873
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @kalekad on GitHub (Jan 1, 2023).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1310
Which version of floccus are you using?
v4.18.0
Sync method
WebDAV
Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.
Tor Browser 12.0.1(Firefox 102.6esr), Android
Which version of Nextcloud Bookmarks are you using? (if relevant)
No response
Which version of Nextcloud? (if relevant)
No response
What kind of WebDAV server are you using? (if relevant)
No response
Describe the Bug
I set the sync interval to 5 minutes and save. I reopen the settings and the sync interval is at 15 minutes.
Expected Behavior
A sync interval of 5 minutes remains stored.
To Reproduce
Debug log provided
@marcelklehr commented on GitHub (Jan 8, 2023):
It seems only 5minutes was forbidden due to a legacy rule. Fixed now.
@kalekad commented on GitHub (Jan 14, 2023):
In v4.18.1 the color of the indicator changed from red to blue when selecting a 5 min interval, but it still does not save.
@marcelklehr commented on GitHub (Jan 15, 2023):
Confirmed. Weird. I tested this before the release and it was working :/
@kolinger commented on GitHub (Nov 27, 2023):
Last fix removed one part of condition but identical condition was left few lines bellow:
github.com/floccusaddon/floccus@8812859e7b/src/ui/components/OptionSyncInterval.vue (L49-L61)Where zero index is taken as invalid value and overridden by default 15 minute interval. But zero index is first option of interval and that's 5 minutes, thus 5 minutes is always overridden by 15 minutes.
This is why 5 minute interval still can't be saved with 4.19.1 as #1414 reports and thus this issues wasn't fixed yet.
@marcelklehr commented on GitHub (Dec 6, 2023):
Thank you @kolinger for investigating this!
@github-actions[bot] commented on GitHub (Dec 6, 2024):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.