mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 14:16:12 +03:00
[GH-ISSUE #88] pathSegment is undefined -- Path tag corrupted when editing in bookmarks app #86
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#86
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @andreas-bulling on GitHub (Apr 17, 2018).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/88
Hi,
I've installed the latest Nextcloud and Floccus versions and use this setup in combination with Firefox 58.0.2 on MacOSX.
Syncing worked fine as long as I only sync from the server to my browser. I just added the first bookmark in my browser and, while syncing back to the server worked, I now see an error message:
"pathSegment is undefined"
Any ideas?
@marcelklehr commented on GitHub (Apr 17, 2018):
Hey @andreas-bulling
It looks like there's a problem with creating a folder on the client. Could you provide logs as follows?
Firefox
about:debuggingdebugbutton next to floccus entrysync nowfor the account of your choice.@andreas-bulling commented on GitHub (Apr 18, 2018):
Hi @marcelklehr
thanks for your quick reply. Here is the debugging output:
I found the problem. The tag for the object in question (62) is not "floccus:>" as for others that I had added using the nextcloud web interface but "floccus:>". That object I had added using Floccus (I do that typically by moving the tab or i symbol to the floccus-created folder in the Bookmarks Toolbar). When I manually fix the tag the sync completes without error.
The error is reproducible.
UPDATE: When editing individual bookmarks the "floccus:>" tag is never shown properly, i.e. always urlencoded. Also not very nice.
@marcelklehr commented on GitHub (Apr 18, 2018):
So, the problem is the upstream bug of nextcloud bookmarks urlencoding tags everytime you edit a bookmark. Correct? This should be fixed in the upcoming version of the app, so we just need to wait for the new release.
@andreas-bulling commented on GitHub (Apr 18, 2018):
Not sure. I thought the problematic bookmark I had added with Floccus but I am not sure anymore now given that the error doesn't occur anymore for some reason.
There is definitely a bug in NC that, when editing the tags for a bookmark (which shows correctly in the overall bookmark list in the NC web interface) the ":>" is urlencoded and not saved properly.
@marcelklehr commented on GitHub (Apr 18, 2018):
Short explanation: the floccus tag is a combination of
PREFIXFOLDER_PATH.PREFIXisfloccus:at the moment. TheFOLDER_PATHused to be a normal path with slashes, e.g./foo/bar/baz, but nextcloud cannot handle that, so/are replaced with>. So, when you add a bookmark in the root folder floccus addsfloccus:>in order to know in which folder the bookmark is when it syncs the next time.You say adding a bookmark with floccus doesn't work, yet the log you provided doesn't show a bookmark being added, but one that was already on the server before the sync process that was logged here.
@marcelklehr commented on GitHub (Apr 22, 2018):
@andreas-bulling for some reason your latest comments don't appear on the website... 🤔
Could it be that you edited a bookmark on the server and it subsequently failed to be sycned / caused the error. When I edit bookmarks with floccus tags, the
>characters in the floccus tag turn into>s, which would account for the error you're seeing.@andreas-bulling commented on GitHub (Apr 23, 2018):
Yes, I am pretty sure this is what happened/is the problem. Thanks a lot for pushing this upstream - let's hope it will be fixed soon.
@marcelklehr commented on GitHub (Aug 25, 2018):
Bookmarks v0.12.0 has been released ;)
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.