mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-26 14:45:59 +03:00
[GH-ISSUE #1242] floccus becomes unusuable on Firefox and stays in syncing mode #827
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#827
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Whissi on GitHub (Aug 28, 2022).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1242
Which version of floccus are you using?
4.17.0
Sync method
Nextcloud Bookmarks
Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.
Mozilla Firefox 104.0 64-bit
Which version of Nextcloud Bookmarks are you using? (if relevant)
v11.0.1
Which version of Nextcloud? (if relevant)
v24.0.4
What kind of WebDAV server are you using? (if relevant)
No response
Describe the Bug
For some months now I notice that the bookmark icon in Firefox's nav bar doesn't work anymore: When I click on the star, a menu like
should appear. However, nothing is happening.
When I disable Floccus add-on, bookmark button in nav bar is working as expected.
When button is not working, it will also disable "null" as tooltip when I hover the icon while normally it should display "Bookmark this page (CTRL+D)".
Pressing CTRL+D will bring up the menu.
Expected Behavior
The star icon in Firefox's nav bar should work, i.e.
To Reproduce
Debug log provided
@Whissi commented on GitHub (Aug 28, 2022):
I just noticed that Floccus seems to stay in "Syncing" status, see
However, last line of log is
When I click the cancel button, nothing happens.
Not sure if this has something to do with the problem.
@Whissi commented on GitHub (Aug 28, 2022):
I clicked "Reset Cache" in options and both issues are gone for now, i.e. add-on shows "All good" and bookmark icon in nav bar is working again.
I leave this open since I had the same experience when disabling/re-enabling floccus add-on but error comes back after few hours/days.
@marcelklehr commented on GitHub (Sep 2, 2022):
Did the error come back?
@Whissi commented on GitHub (Sep 5, 2022):
Yes, was working for some days but I am experiencing the problem right now.
@Whissi commented on GitHub (Sep 6, 2022):
Today I hit this again.
@Whissi commented on GitHub (Sep 13, 2022):
Today it happened again.
@marcelklehr commented on GitHub (Sep 17, 2022):
I can confirm this issue, but I doubt it's something that can be fixed in floccus.
@Whissi commented on GitHub (Sep 22, 2022):
Do you have more information? I don't know when it started but there were versions without this problem.
At the moment this problem is making floccus unusable for me like I just noticed you cannot edit/delete any bookmarks in Firefox bookmark windows (CTRL+SHIFT+O) when floccus is causing Firefox to stays in "syncing" mode. I am also wondering about the impact of resetting cache every 1-2 days (i.e. is floccus for example not deleting bookmarks on server I changed/deleted locallay because UI says "the next synchronization run is guaranteed not to delete any data and merely merges server and local bookmarks together").
@marcelklehr commented on GitHub (Sep 22, 2022):
I cannot reproduce this. What is "syncing" mode?
The only thing I can reproduce is that the bookmark button in the firefox URL bar doesn't correctly indicate whether the current site is bookmarked.
I am not sure why resetting the cache would fix this issue temporarily. I think it's likely a coincidence and it's actually an intermittent issue.
@Whissi commented on GitHub (Sep 22, 2022):
With "syncing mode" I mean the UI status shown in the screenshot above.
@stale[bot] commented on GitHub (Oct 8, 2022):
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@Whissi commented on GitHub (Oct 9, 2022):
I updated issue to reflect the main issue.
When I initially reported this issue I thought that this was only an UI issue, i.e. only affects icon shown on nav bar and maybe bookmark menu. Nothing that critical. However, that's not the case. Add-on is completely not usable for me when this error occurs and floccus stays in "syncing" mode. I.e. not just UI is blocked, even new or changed bookmarks don't get synchronized anymore (shouldn't be surprising given that add-on stays in "syncing" status).
@marcelklehr commented on GitHub (Oct 14, 2022):
So, this is about two issues as far as I can see, then:
Can you open a new issue for 2, so we can separate the two? The bookmark button not working is likely a firefox bug and nothing I can do about in floccus.
@Whissi commented on GitHub (Oct 15, 2022):
I don't believe that these are two issues. I believe that the thing with the button in navbar or not working bookmark dialog is caused by floccus getting stuck in syncing mode which will block bookmark API from firefox affecting firefox own navbar and other features like the bookmark dialog which all need to query bookmark data.
@stale[bot] commented on GitHub (Oct 30, 2022):
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@flexy2dd commented on GitHub (Nov 16, 2022):
Hi all
I have the exact same issue (with 4.17.1) and I agree with @Whissi is not just a UI issue but it's sync loop
and is not possible to cancel the sync, if click on cancel button no effect
@Whissi commented on GitHub (Nov 27, 2022):
I just noticed that this bug is causing data loss:
I disabled auto-sync for a while in hope that Firefox will keep working until I manually sync and have to clear cache in floccus afterwards to unbreak it. However, it looks like this is not enough.
Today for example I added a new bookmark. I noticed that UI was stuck (the way using the bookmark star). But I was able to create the bookmark via context menu. It was visible in my bookmark toolbar.
I restarted the complete browser and after restart I noticed that the new bookmark was gone.
I now moved one bookmark from folder A to folder B. Tried to sync in floccus but "Sync now" button didn't work (nothing happened when I clicked the button). So I cleared cache in floccus, restarted Firefox and all my changes were lost, i.e. the bookmark I moved from folder A to folder B was back in folder A.
@Whissi commented on GitHub (Dec 21, 2022):
In the past weeks I tried several older versions and I didn't find a single one working (oldest version I tried was v4.15). So for me I declare floccus completely broken on firefox. It's not usable anymore, especially because you can lose data.
@marcelklehr commented on GitHub (Dec 21, 2022):
I'm sorry I've been absent from this issue.
This is a false belief, AFAIK. Floccus doesn't block Firefox's bookmarks access.
I use it daily on Firefox and it works fine for me.
This is what makes you lose data. There is a warning attached to that button I believe.
Can you tell me why this is not the same issue as https://github.com/floccusaddon/floccus/issues/1290 ?
@Whissi commented on GitHub (Dec 21, 2022):
Well, this is at least how the error manifests for me. Disabling floccus add-in while firefox is "blocked" will "unblock" firefox immediately for me. I.e. on reload/new tab, blue bookmark star or bookmark menu works for me again without the need to restart the browser.
That's not how I read/understand
(from advanced options)
Hard to tell. Few weeks ago I found another issue discussing a locking issues where you posted some commands to check lock status. I remember that I tried this when my browser was stuck but there wasn't any lock. Also, my understanding of #1290 is that no other client will be able to sync when there is a (stale) lock. However, floccus in my Microsoft Edge and Google Chrome instances is working fine and last sync state is current (i.e. not what @jdelker experienced in https://github.com/floccusaddon/floccus/issues/1290#issuecomment-1348448541).
I would start by fixing the "Cancel" button (this is not meant to be instructive). I.e. when floccus is stuck in "syncing", "Cancel" button has no effect. I would expect at least to stop running action and reset floccus UI state. I would expect that this would remove any stale lock set by this client. At least I should be able to press cancel and start a new sync. At the moment, once floccus is stuck in syncing mode, there is no escape. I have to either clear cache or kill add-in.
I probably need to learn how to run this add-in from folder (not as XPI) so I can start debugging.
@lazymonkey2 commented on GitHub (Jan 25, 2023):
@Whissi do you see any errors in the dev console of firefox?
(to open it press CTRL+SHIFT+J. maybe you should select multiprocess option).
@Whissi commented on GitHub (Feb 6, 2023):
Nothing in dev console when floccus is getting stuck, I only see the starting message: "Starting sync process for account ...". Also nothing when I press "Cancel" button to stop sync in progress. I wonder if this button works for anyone...
Don't know if I found something new: Since I lost bookmarks due to this issue, I stopped using floccus for a while. I now re-enabled floccus (4.18.1) on Firefox 109.0.1 and at least it looks like I don't need to reset cache to recover. Looks like it is enough to restart Firefox.
@Whissi commented on GitHub (Feb 9, 2023):
Forget my previous comment. Because the problem hasn't happened that often in the past few days I thought that something could have changed in 4.18.x or Firefox 109 but it hasn't
Today I experienced the same issue like before: Console is showing "Starting sync process for account ..." and floccus became stuck. Firefox was showing bookmark icon for any URL I visited in navbar, bookmark menu didn't work...
While Firefox/floccus was stuck I started a Chromium-based browser where I also have floccus installed which is using same account and it had no problems to sync.
@silopolis commented on GitHub (Oct 2, 2023):
Same here with an error 423 "Resource is already locked", possibly related to #1290
@Whissi commented on GitHub (Oct 2, 2023):
FYI: I haven't experienced the problems since I changed storage of the volume where I store my Firefox profile (I used an RAID 10 on Adaptec SmartRAID 3154-8 before but for some unknown and unrelated reasons, this storage is sometimes very slow -- the whole system for example was hanging for ~2min after each cold boot. At this time my Windows user profile was stored on that volume. Since I moved my user profile to a NVMe disk I never experienced the problem again. This let me believe that there might be race condition you experience only on slow/overloaded storage system).
@marcelklehr commented on GitHub (May 12, 2024):
I think this is likely a problem with Firefox.
@github-actions[bot] commented on GitHub (May 13, 2025):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.