mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-26 14:45:59 +03:00
[GH-ISSUE #82] Bug deleting entry on server that already didn't exist #80
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#80
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Lantizia on GitHub (Apr 10, 2018).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/82
Software versions
Steps to reproduce
Expected outcome
It to sync up properly and down properly?
Actual outcome
For some reason when it was syncing up it randomly stopped and said it had difficulty deleting entry with id 68 on the server. I had to go into the SQL of the Nextcloud database into the bookmarks table and make a fake entry 68 just so it could then delete it. Not sure why, I can provide extra information if I am able to (as I'll likely re-attempt uploading these all up again in the future when all the bugs I'm listing are ironed out).
@marcelklehr commented on GitHub (Apr 10, 2018):
I've fixed this on the server-side already, it should be ok with the next release of nextcloud bookmarks.
@Lantizia commented on GitHub (Apr 10, 2018):
Brill I'll keep an eye out for the next release of that. I need a rebuild of my Nextcloud server anyway, 12.0.5 is getting oooold.
@1stone commented on GitHub (May 16, 2018):
Hi Marcel,
could you give some background why this is a server-side bug?
With the uncertainty when a new bookmark app will be available, do you see a chance to mitigate this problem in floccus?
I'm currently hitting this problem over and over again (syncing with multiple browsers, Chrome & Firefox). Using the suggested workaround becomes quite annoying...
Cheers
@marcelklehr commented on GitHub (May 21, 2018):
Hey @1stone
Sorry for the delay!
There have been multiple bugs that caused this failure, apparently. In the end the server should be able to handle deletions of items that have already been deleted, which is why I labelled this as an upstream issue. But then, why does the client delete the item in the first place? Initially, I thought this only happens when the same item is deleted concurrently on two clients. But the latest patch release fixes a bug that could lead to all sorts of undesirable behavior. Let me know if v2.2.3 makes your life easier :)
@e-alfred commented on GitHub (May 28, 2018):
I have the same problem. I added a few bookmarks in folders I didn't want to and I deleted them on one Floccus client. They were removed from the server without a problem. But then they were synced back from another client. If I delete them on the other client and try "sync now" I get multiple errors complaining "Removing a bookmark on the server failed. remoteId=111".
@marcelklehr commented on GitHub (May 31, 2018):
It turns out I hadn't completely fixed the issue I mentioned earlier, so... give v2.2.6 a try :)
@marcelklehr commented on GitHub (Jun 6, 2018):
Did the error come up again in the meantime?
@e-alfred commented on GitHub (Jun 7, 2018):
Yes, it works now. Thanks for the awesome work!
@1stone commented on GitHub (Jun 7, 2018):
Hmm...
after not seeing this problem for several days, I just encountered it again with 2.2.7 on Chrome.
This is the message copy&pasted from the settings window:
@marcelklehr commented on GitHub (Jun 7, 2018):
@1stone I realize that those ids are kind of awkward. Any specific actions that you undertook before this happened?
@1stone commented on GitHub (Jun 8, 2018):
@marcelklehr: Nothing particular. In fact, I've only revived my workstation from hibernation and noticed that the floccus icon showed an "!" annotation. (It probably was there before. I don't see a relation to hibernation here.)
Clicking on it and saw that error message pasted above.
While two other accounts (one of that on the same server, but with different path) reported ok, I was not able to change the situation for the failed one. Neither clicking sync or reset had any obvious effect.
Finally, I deleted the account completely and recreated it again with the same settings. A full sync started, and everything was fine again after that.
I'll keep a close eye on this and report back with eventually more infos.
Thanks for your support.
@marcelklehr commented on GitHub (Jun 21, 2018):
I'll close this in the meantime. @1stone Feel free to open a new issue for follow-ups. :)
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.