mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 22:26:06 +03:00
[GH-ISSUE #1186] This url will cause sync error #790
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#790
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Sorata on GitHub (May 31, 2022).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1186
Which version of floccus are you using?
4.14.0
Sync method
{"label"=>"WebDAV"}
Which browser are you using? In case you are using the Android App, specify the Android version please.
Firefox 100.0.2
Which version of Nextcloud Bookmarks are you using? (if relevant)
No response
Which version of Nextcloud? (if relevant)
No response
What kind of WebDAV server are you using? (if relevant)
No response
Describe the Bug
Url:https://blog.csdn.net/weixin_28987001/article/details/116655417
The title:linux删除0字节的文件,如何在linux中删除许多0字节的文件?_解说柯基~~~的博客-CSDN博客
The string after 柯基, will cause sync error: Syncing failed with An invalid or illegal string was specified
Expected Behavior
Sync OK.
To Reproduce
Just add it to bookMark and sync.
Debug log provided
@pinpontitit commented on GitHub (Jun 2, 2022):
I can reproduce it with same version of Firefox, but only if I modify the bookmark and give it the title provided in your post.
However, if I directly create a bookmark from the link you provided, Firefox will automatically use a different character than the one (�) that you gave, and then syncing works.
And if you use Chrome when bookmarking the link, you can notice that Chrome will automatically and simply erase the symbol on the title.
Github also cannot make difference between those symbols. (I suppose the symbol I see in your comment is not the same than the one you wrote, and github changed it, no ?)
So I guess that you reached a problem that even browsers aren't able to handle without changing the title.
Does it happen a lot to you, that you bookmark or uses websites with this symbol on the title ?
or it was the only one ever ?
Just for pleasure : In your language, what does this symbol (or word) mean ? because of course I cannot see it.
@Sorata commented on GitHub (Jun 4, 2022):
I don't know either, I just suddenly found out that I couldn't synchronize, so I spent time locating the cause of the problem, and found that this url caused an exception.
It doesn't matter if this problem is not fixed, after all, the title of the bookmark can be manually adjusted.
@pinpontitit commented on GitHub (Jun 5, 2022):
Right.
However it's true that the Error message could be more explicit for the user.
Like this they know that they can fix it themselves by changing the title.
For example, before all the technical content (if this content is truly needed by the user):
"There is 1 or more invalid characters in the bookmark title, please change or remove those".
@marcelklehr commented on GitHub (Mar 22, 2023):
I cannot reproduce this with latest firefox.
@ghost commented on GitHub (Aug 5, 2023):
Hi,
I have the same bug with another asian URL
I can reproduce this bug with Librewolf 116.0-1 + Firefox 102.13.0esr on debian 12
https://rtrp.jp/articles/43475
Firefox
Firefox assigned bookmark name: "《長崎》美しき日本を再発見!長崎のフォトジェニックな絶景スポット5選 | RETRIP[リトリップ]"
Firefox Library's screenshot
In my case, If you look in the page at the article's title after "見!" it seems the character is even missing from it, since Japanese does not have spaces. But if I copy and paste it to gedit then it appears as Firefox. However, at this point, I do not understand what character is.
page title's screenshot

Brave
Creating the same bookmark with Brave, the character in the name is replaced with a space and have no issue with floccus. But if you copy the title inside the article to gedit, then it appears.
@github-actions[bot] commented on GitHub (Aug 5, 2024):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.