starred/floccus

Fork 0

mirror of https://github.com/floccusaddon/floccus.git synced 2026-04-25 22:26:06 +03:00

[GH-ISSUE #1122] [Android] After user grants access over SSO, automatically "Save" #745

New issue

Closed

opened 2026-02-25 22:37:59 +03:00 by kerem · 5 comments

kerem commented

2026-02-25 22:37:59 +03:00

Owner

Originally created by @sunjam on GitHub (Apr 20, 2022).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1122

Describe the feature you'd like to request

After granting access to a new account over SSO, the user must click the "Save" button on the top right.
Please making this save automatic as opposed to manual when granting access over SSO.

If the Save button is not click the user will instead become bob@example.com

Thanks!

Describe the solution you'd like

Automatically save the SSO account.

Describe alternatives you've considered

You must click the "Save" button after granting SSO access, which is counterintuitive. Thanks!

Originally created by @sunjam on GitHub (Apr 20, 2022). Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1122 ### Describe the feature you'd like to request After granting access to a new account over SSO, the user must click the "Save" button on the top right. Please making this save automatic as opposed to manual when granting access over SSO. If the Save button is not click the user will instead become bob@example.com Thanks! ### Describe the solution you'd like Automatically save the SSO account. ### Describe alternatives you've considered You must click the "Save" button after granting SSO access, which is counterintuitive. Thanks!

kerem

2026-02-25 22:37:59 +03:00

closed this issue
added the
enhancement
label

kerem commented

2026-02-25 22:38:00 +03:00

Author

Owner

@marcelklehr commented on GitHub (Apr 20, 2022):

Thank you for raising this issue. I think implementing #1023 will fix this as well, hence I'm closing for now.

@marcelklehr commented on GitHub (Apr 20, 2022): Thank you for raising this issue. I think implementing #1023 will fix this as well, hence I'm closing for now.

kerem commented

2026-02-25 22:38:00 +03:00

Author

Owner

@sunjam commented on GitHub (Apr 20, 2022):

Possibly. The only confusion with it is after completing SSO login Nextcloud says:

Access Granted. You may now close this Window.

but Floccus is still waiting for you to click the Save button, which is easy to miss and can be browsed away from by clicking anywhere else in the app... then you end up with bob. 😆

@sunjam commented on GitHub (Apr 20, 2022): Possibly. The only confusion with it is after completing SSO login Nextcloud says: `Access Granted. You may now close this Window.` but Floccus is still waiting for you to click the `Save` button, which is easy to miss and can be browsed away from by clicking anywhere else in the app... then you end up with bob. :laughing:

kerem commented

2026-02-25 22:38:00 +03:00

Author

Owner

@marcelklehr commented on GitHub (Apr 24, 2022):

Agreed. It's problematic that the window doesn't close automatically, once the authorization is done.

A different browser implementation may help with this: https://ionicframework.com/docs/native/in-app-browser

@marcelklehr commented on GitHub (Apr 24, 2022): Agreed. It's problematic that the window doesn't close automatically, once the authorization is done. A different browser implementation may help with this: https://ionicframework.com/docs/native/in-app-browser

kerem commented

2026-02-25 22:38:00 +03:00

Author

Owner

@marcelklehr commented on GitHub (May 3, 2022):

Fixed by github.com/floccusaddon/floccus@e68009010e

Window closes automatically now.

@marcelklehr commented on GitHub (May 3, 2022): Fixed by https://github.com/floccusaddon/floccus/commit/e68009010e89d4153fc3c916758c51053aed02ce Window closes automatically now.

kerem commented

2026-02-25 22:38:00 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (May 4, 2023):

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions[bot] commented on GitHub (May 4, 2023): This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/floccus#745

No description provided.

Rows
Columns