[GH-ISSUE #1073] Cannot add webdav account manually, default account created instead #713

Closed
opened 2026-02-25 22:37:54 +03:00 by kerem · 7 comments
Owner

Originally created by @cracket on GitHub (Mar 11, 2022).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1073

Which version of floccus are you using?

4.11.0.1

Sync method

{"label"=>"WebDAV"}

Which browser are you using?

firefox 97.0.2 32 bit armhf

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

User cannot create webdav account manually, instead default webdav account is created, and as a workaround it can be edited to proper configuration

Expected Behavior

If firefox/web browser is too slow to process click, first click on "Add account" should block events until page with editing details is ready
Do not fire multiple "add account" event until account is saved or updated
When creating default bob@example.com account - it should have "auto-sync" set to off by default
Do not allow to create more than 1 default webdav accounts

To Reproduce

Steps to reproduce:

  • use latests components (floccus 4.11, firefox 97, ubuntu 20 on armhf) on preferably slow machine
  • remove all configured floccus accounts
  • restart ff
  • I have clicked "+ NEW ACCOUNT" in top right icon pull down menu (it was empty due to no accounts configured)
  • configuration page was shown: moz-extension://xxx-xxxx-xxxx-xxxx/dist/html/options.html#/new ( How do you want to sync? )
  • I have selected "XBEL file in WebDav"
  • clicked Add account, there was nothing happened
  • so I clicked 4 more times on "add account", and UI still did nothing, and remained on page "how do you want to sync?"
  • then I have moved to about:debugging (about:devtools-toolbox?id=floccus%40handmadeideas.org&type=extension) and tried to read some fancy floccus console logs
  • floccus started to synchronize 4 times the default built in account:
    2022-03-11T21:43:09.100Z Starting sync process for account bob@example.org
  • huge cpu utilization started due to multiple accounts being synced (although not the one I wanted)

Debug log provided

  • I have provided a debug log file
Originally created by @cracket on GitHub (Mar 11, 2022). Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1073 ### Which version of floccus are you using? 4.11.0.1 ### Sync method {"label"=>"WebDAV"} ### Which browser are you using? firefox 97.0.2 32 bit armhf ### Which version of Nextcloud Bookmarks are you using? (if relevant) _No response_ ### Which version of Nextcloud? (if relevant) _No response_ ### What kind of WebDAV server are you using? (if relevant) _No response_ ### Describe the Bug User cannot create webdav account manually, instead default webdav account is created, and as a workaround it can be edited to proper configuration ### Expected Behavior If firefox/web browser is too slow to process click, first click on "Add account" should block events until page with editing details is ready Do not fire multiple "add account" event until account is saved or updated When creating default bob@example.com account - it should have "auto-sync" set to off by default Do not allow to create more than 1 default webdav accounts ### To Reproduce Steps to reproduce: - use latests components (floccus 4.11, firefox 97, ubuntu 20 on armhf) on preferably slow machine - remove all configured floccus accounts - restart ff - I have clicked "+ NEW ACCOUNT" in top right icon pull down menu (it was empty due to no accounts configured) - configuration page was shown: moz-extension://xxx-xxxx-xxxx-xxxx/dist/html/options.html#/new ( How do you want to sync? ) - I have selected "XBEL file in WebDav" - clicked Add account, there was nothing happened - so I clicked 4 more times on "add account", and UI still did nothing, and remained on page "how do you want to sync?" - then I have moved to about:debugging (about:devtools-toolbox?id=floccus%40handmadeideas.org&type=extension) and tried to read some fancy floccus console logs - floccus started to synchronize 4 times the default built in account: 2022-03-11T21:43:09.100Z Starting sync process for account bob@example.org - huge cpu utilization started due to multiple accounts being synced (although not the one I wanted) ### Debug log provided - [ ] I have provided a debug log file
Author
Owner

@marcelklehr commented on GitHub (Mar 11, 2022):

Thank you for reporting this issue!

I cannot reproduce this off-hand.

so I clicked 4 more times on "add account", and UI still did nothing, and remained on page "how do you want to sync?"

Can you right click on the page when this happens, select 'Inspect' and then, in the newly opened dev-tools window go to the console tab to check for JavaScript errors?

<!-- gh-comment-id:1065616770 --> @marcelklehr commented on GitHub (Mar 11, 2022): Thank you for reporting this issue! I cannot reproduce this off-hand. > so I clicked 4 more times on "add account", and UI still did nothing, and remained on page "how do you want to sync?" Can you right click on the page when this happens, select 'Inspect' and then, in the newly opened dev-tools window go to the console tab to check for JavaScript errors?
Author
Owner

@cracket commented on GitHub (Mar 12, 2022):

There are no relevant errors in js console of moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/html/options.html#/new page.

Error: Cannot find module './pl.json'
    r moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/js/options.js:2
    a moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/js/options.js:2
    m moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/js/options.js:2
options.js:2:1313657
Error: Cannot find module './pl.json'
    r moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/js/options.js:2
    a moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/js/options.js:2
    m moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/js/options.js:2
options.js:2:1313922
Error: Cannot find module './en_US.json'
    r moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/js/options.js:2
    a moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/js/options.js:2
    m moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/js/options.js:2
options.js:2:1313657
[Vuetify] [UPGRADE] 'v-content' is deprecated, use 'v-main' instead.

found in

---> <VMain>
       <VApp>
         <App> at src/ui/App.vue
           <Root>

I suspect this can be just a huge delay due to bookmarks lockup ( see my other comment in https://github.com/floccusaddon/floccus/issues/973#issuecomment-1065727558 ) but I need to prove it somehow.

How floccus should behave if some of the firefox storage is locked for more than 50 seconds (slow hardware and huge sqlite DBs in ff)?

<!-- gh-comment-id:1065747465 --> @cracket commented on GitHub (Mar 12, 2022): There are no relevant errors in js console of moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/html/options.html#/new page. ``` Error: Cannot find module './pl.json' r moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/js/options.js:2 a moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/js/options.js:2 m moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/js/options.js:2 options.js:2:1313657 Error: Cannot find module './pl.json' r moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/js/options.js:2 a moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/js/options.js:2 m moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/js/options.js:2 options.js:2:1313922 Error: Cannot find module './en_US.json' r moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/js/options.js:2 a moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/js/options.js:2 m moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/js/options.js:2 options.js:2:1313657 [Vuetify] [UPGRADE] 'v-content' is deprecated, use 'v-main' instead. found in ---> <VMain> <VApp> <App> at src/ui/App.vue <Root> ``` I suspect this can be just a huge delay due to bookmarks lockup ( see my other comment in [https://github.com/floccusaddon/floccus/issues/973#issuecomment-1065727558](https://github.com/floccusaddon/floccus/issues/973#issuecomment-1065727558) ) but I need to prove it somehow. How floccus should behave if some of the firefox storage is locked for more than 50 seconds (slow hardware and huge sqlite DBs in ff)?
Author
Owner

@marcelklehr commented on GitHub (Mar 12, 2022):

Could indeed be that it just takes veeery long :/ I'll consider adding a loading indicator.

<!-- gh-comment-id:1065886081 --> @marcelklehr commented on GitHub (Mar 12, 2022): Could indeed be that it just takes veeery long :/ I'll consider adding a loading indicator.
Author
Owner

@sunjam commented on GitHub (May 12, 2022):

I just removed bob@example.com four times from my Floccus browser extension on Firefox this morning. Then, while attempting to add a new account... bob@example.com was added again.

<!-- gh-comment-id:1125324569 --> @sunjam commented on GitHub (May 12, 2022): I just removed bob@example.com four times from my Floccus browser extension on Firefox this morning. Then, while attempting to add a new account... bob@example.com was added again.
Author
Owner

@marcelklehr commented on GitHub (May 16, 2022):

I've updated the account creation workflow in v4.14.0, please let me know if this is still an issue with the new workflow.

<!-- gh-comment-id:1127918377 --> @marcelklehr commented on GitHub (May 16, 2022): I've updated the account creation workflow in v4.14.0, please let me know if this is still an issue with the new workflow.
Author
Owner

@marcelklehr commented on GitHub (May 18, 2022):

@soil8rino This issue is about account creation, so if there are still excessive useless accounts created upon clicking NEW ACCOUNT, let me know. I'm closing this for now.

<!-- gh-comment-id:1129752350 --> @marcelklehr commented on GitHub (May 18, 2022): @soil8rino This issue is about account creation, so if there are still excessive useless accounts created upon clicking NEW ACCOUNT, let me know. I'm closing this for now.
Author
Owner

@github-actions[bot] commented on GitHub (May 19, 2023):

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

<!-- gh-comment-id:1553883713 --> @github-actions[bot] commented on GitHub (May 19, 2023): This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/floccus#713
No description provided.