mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 22:26:06 +03:00
[GH-ISSUE #1073] Cannot add webdav account manually, default account created instead #713
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#713
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cracket on GitHub (Mar 11, 2022).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1073
Which version of floccus are you using?
4.11.0.1
Sync method
{"label"=>"WebDAV"}
Which browser are you using?
firefox 97.0.2 32 bit armhf
Which version of Nextcloud Bookmarks are you using? (if relevant)
No response
Which version of Nextcloud? (if relevant)
No response
What kind of WebDAV server are you using? (if relevant)
No response
Describe the Bug
User cannot create webdav account manually, instead default webdav account is created, and as a workaround it can be edited to proper configuration
Expected Behavior
If firefox/web browser is too slow to process click, first click on "Add account" should block events until page with editing details is ready
Do not fire multiple "add account" event until account is saved or updated
When creating default bob@example.com account - it should have "auto-sync" set to off by default
Do not allow to create more than 1 default webdav accounts
To Reproduce
Steps to reproduce:
2022-03-11T21:43:09.100Z Starting sync process for account bob@example.org
Debug log provided
@marcelklehr commented on GitHub (Mar 11, 2022):
Thank you for reporting this issue!
I cannot reproduce this off-hand.
Can you right click on the page when this happens, select 'Inspect' and then, in the newly opened dev-tools window go to the console tab to check for JavaScript errors?
@cracket commented on GitHub (Mar 12, 2022):
There are no relevant errors in js console of moz-extension://6f77eca5-e455-4fd3-b517-6453fa9f6978/dist/html/options.html#/new page.
I suspect this can be just a huge delay due to bookmarks lockup ( see my other comment in https://github.com/floccusaddon/floccus/issues/973#issuecomment-1065727558 ) but I need to prove it somehow.
How floccus should behave if some of the firefox storage is locked for more than 50 seconds (slow hardware and huge sqlite DBs in ff)?
@marcelklehr commented on GitHub (Mar 12, 2022):
Could indeed be that it just takes veeery long :/ I'll consider adding a loading indicator.
@sunjam commented on GitHub (May 12, 2022):
I just removed bob@example.com four times from my Floccus browser extension on Firefox this morning. Then, while attempting to add a new account... bob@example.com was added again.
@marcelklehr commented on GitHub (May 16, 2022):
I've updated the account creation workflow in v4.14.0, please let me know if this is still an issue with the new workflow.
@marcelklehr commented on GitHub (May 18, 2022):
@soil8rino This issue is about account creation, so if there are still excessive useless accounts created upon clicking NEW ACCOUNT, let me know. I'm closing this for now.
@github-actions[bot] commented on GitHub (May 19, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.