mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 22:26:06 +03:00
[GH-ISSUE #1037] The "Anonymize private data" checkbox does not save the state and is always active (Android, 4.10.0) #683
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#683
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gitmaker032 on GitHub (Feb 8, 2022).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1037
Describe the bug
The checkbox "Anonymize private data" is active by default and if you try to uncheck and save the settings, the checkbox remains active. Completely reinstalling the app does not solve the problem.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The checkbox keeps the inactive state.
Screenshots (GIFs)
View the GIF
Android
@marcelklehr commented on GitHub (Feb 8, 2022):
From what I can see in the GIF, this seems to be the intended behavior: Always default to anonymized logs. The question for me is, does it still anonymize the logs when disabling the checkbox and tapping on the download button?
@gitmaker032 commented on GitHub (Feb 8, 2022):
I thought that in order for the logging settings to apply, they need to be saved first :) Which is consistent with the logic of the other fields in the settings section. Yes, the logs look a bit different if you download them immediately after unchecking the box. However, in my case, no additional information on the error was added, which confused me.
@marcelklehr commented on GitHub (Feb 9, 2022):
Mh, I see. Maybe two buttons or a dropdown button would be better then, what do you think?
@marcelklehr commented on GitHub (Feb 9, 2022):
@gitmaker032 commented on GitHub (Feb 9, 2022):
I think the version with two buttons is clearly better. This solution does not break the logic of "change the setting - save it". As an alternative, you can not duplicate the button, and make a popup menu after you click it. Cleaner interface, but more difficult to implement, I suppose.
@github-actions[bot] commented on GitHub (Mar 20, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.