mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 14:16:12 +03:00
[GH-ISSUE #1030] Tab sync closes newly opened tabs #678
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#678
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sevmonster on GitHub (Feb 6, 2022).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1030
Describe the bug
If you open new tabs during a push tab sync, those tabs are closed as floccus attempts to bring the current tab list into sync with what it believes it should be. I am not sure if bookmarks also suffer this race condition, as I was only able to replicate it with push tab sync. (When the next update lands I will test with other tab sync modes.)
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Newly opened tabs are left alone. By definition push sync should not make any local changes.
Desktop
Server
Debug log
There is no button, and no sync error occured.
@marcelklehr commented on GitHub (Feb 15, 2022):
I cannot replicate this with the latest dev version, so it seems my latest fixes addressed this as well. I'll leave this open until the changes land in release, though.
@sevmonster commented on GitHub (Feb 15, 2022):
Great, I will test when it lands. Thank you.
@marcelklehr commented on GitHub (Mar 14, 2022):
Patch has landed, do you still experience this?
@sevmonster commented on GitHub (Mar 15, 2022):
Didn't mean to close. GitHub mobile interface sucks in landscape.
I just experienced this in Kiwi with 4.11.0 and Nextcloud Bookmarks app 10.1.0. I do not have a desktop environment to test desktop browsers with at the moment.
I can see from Nextcloud Activities that the login page tab bookmark was added in the prior sync cycle and there are no errors in NC logs to show otherwise, so for some reason it did not see the tab in NC and closed it in the sync.
@sevmonster commented on GitHub (Mar 15, 2022):
Don't know if it's related, but I noticed that with every other sync it seems, this will happen:

@stale[bot] commented on GitHub (Mar 29, 2022):
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@sevmonster commented on GitHub (Mar 30, 2022):
Since 4.12, I have not experienced this issue. There does still appear to be some jank with newly opened tabs from a fresh bookmark sync jumping around and reloading themselves with subsequent syncs until you navigate to a new page: it looks like the
parentIdis not updated to the new window when the tab is fetched. Don't know if that would be under this issue or not.@stale[bot] commented on GitHub (Apr 13, 2022):
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@github-actions[bot] commented on GitHub (Apr 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.