[GH-ISSUE #998] Use different Oauth for Google login #653

Closed
opened 2026-02-25 22:37:45 +03:00 by kerem · 15 comments
Owner

Originally created by @Cyberavater on GitHub (Nov 17, 2021).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/998

When I log in using google login for other services, the page opens up on a new tab I can use many features (i.e Choose Gmail account or Gmail autocomplete, auto password fill-up (by password manager extension), and even no 2 fact verification if the account is already logged in on the same browser.)

I'm not sure how it's currently implemented in floccus but its functionality lacks in many ways that much I can tell.

Originally created by @Cyberavater on GitHub (Nov 17, 2021). Original GitHub issue: https://github.com/floccusaddon/floccus/issues/998 When I log in using google login for other services, the page opens up on a new tab I can use many features (i.e Choose Gmail account or Gmail autocomplete, auto password fill-up (by password manager extension), and even no 2 fact verification if the account is already logged in on the same browser.) I'm not sure how it's currently implemented in floccus but its functionality lacks in many ways that much I can tell.
Author
Owner

@github-actions[bot] commented on GitHub (Nov 17, 2021):

Hi @Cyberavater! This issue is being automatically closed because it does not follow the issue template.

<!-- gh-comment-id:971876276 --> @github-actions[bot] commented on GitHub (Nov 17, 2021): Hi @Cyberavater! This issue is being automatically closed because it does not follow the issue template.
Author
Owner

@github-actions[bot] commented on GitHub (Nov 17, 2021):

Hi @Cyberavater! This issue is being automatically closed because it does not follow the issue template.

<!-- gh-comment-id:971876560 --> @github-actions[bot] commented on GitHub (Nov 17, 2021): Hi @Cyberavater! This issue is being automatically closed because it does not follow the issue template.
Author
Owner

@Cyberavater commented on GitHub (Nov 17, 2021):

This also actually causes login issues on many browsers (#919 and #921). If possible, please have a look at it.

<!-- gh-comment-id:971882886 --> @Cyberavater commented on GitHub (Nov 17, 2021): This also actually causes login issues on many browsers (#919 and #921). If possible, please have a look at it.
Author
Owner

@marcelklehr commented on GitHub (Nov 17, 2021):

Follow standard OAuth for Google login

As far as I can remember, what floccus does is the standard (possibly the only) way to do OAuth in a web extension, that's why there is a web extension API for it. I'm aware that some browsers crash upon using this API, but that doesn't make it non-standard, IMHO. I'm happy to be proven wrong, though.

<!-- gh-comment-id:971898850 --> @marcelklehr commented on GitHub (Nov 17, 2021): > Follow standard OAuth for Google login As far as I can remember, what floccus does is the standard (possibly the only) way to do OAuth in a web extension, that's why there is a web extension API for it. I'm aware that some browsers crash upon using this API, but that doesn't make it non-standard, IMHO. I'm happy to be proven wrong, though.
Author
Owner

@Cyberavater commented on GitHub (Nov 17, 2021):

Hi, thanks for responding. Please check Tampermonkey's way of Google Oauth implementation, it opens up the Oauth in a new tab that retains all functionality (mentioned above) and I've seen no browser crashed so far with that.

Edit: Altho, I'm not sure how much it'll help since Tampermonkey is not Open Source anymore and I'm not sure if Tampermonkey had this in the older version.

This repository contains the source of the Tampermonkey extension up to version 2.9. All newer versions are distributed under a proprietary license.

<!-- gh-comment-id:971908472 --> @Cyberavater commented on GitHub (Nov 17, 2021): Hi, thanks for responding. Please check [Tampermonkey's](https://github.com/Tampermonkey/tampermonkey) way of Google Oauth implementation, it opens up the Oauth in a new tab that retains all functionality (mentioned above) and I've seen no browser crashed so far with that. Edit: Altho, I'm not sure how much it'll help since Tampermonkey is not Open Source anymore and I'm not sure if Tampermonkey had this in the older version. > This repository contains the source of the Tampermonkey extension up to version 2.9. All newer versions are distributed under a proprietary license.
Author
Owner

@marcelklehr commented on GitHub (Nov 17, 2021):

I'm not sure if Tampermonkey had this in the older version.

Yeah, I don't think it did, code search doesn't yield anything :/

<!-- gh-comment-id:971916938 --> @marcelklehr commented on GitHub (Nov 17, 2021): > I'm not sure if Tampermonkey had this in the older version. Yeah, I don't think it did, code search doesn't yield anything :/
Author
Owner

@Cyberavater commented on GitHub (Nov 17, 2021):

Okay, check this one, (Violentmonkey) it's full FOSS and its Google login also works almost nicely.

<!-- gh-comment-id:971921189 --> @Cyberavater commented on GitHub (Nov 17, 2021): Okay, check this one, ([Violentmonkey](https://github.com/violentmonkey/violentmonkey)) it's full FOSS and its Google login also works ~~almost~~ nicely.
Author
Owner

@marcelklehr commented on GitHub (Nov 17, 2021):

Alright, their approach is a bit hacky but works

<!-- gh-comment-id:971941143 --> @marcelklehr commented on GitHub (Nov 17, 2021): Alright, their approach is a bit hacky but works
Author
Owner

@github-actions[bot] commented on GitHub (Nov 17, 2021):

Hi @Cyberavater! This issue is being automatically closed because it does not follow the issue template.

<!-- gh-comment-id:971941850 --> @github-actions[bot] commented on GitHub (Nov 17, 2021): Hi @Cyberavater! This issue is being automatically closed because it does not follow the issue template.
Author
Owner

@marcelklehr commented on GitHub (Nov 17, 2021):

aah. fml

<!-- gh-comment-id:971942051 --> @marcelklehr commented on GitHub (Nov 17, 2021): aah. fml
Author
Owner

@Cyberavater commented on GitHub (Nov 17, 2021):

Alright, their approach is a bit hacky but works

Nice, since you're interested in implementing it, I'll add this issue here for you to read, https://github.com/violentmonkey/violentmonkey/issues/1396

[You'll know why I added 'almost', you can try to fix or ignore this since it only happens on kiwi]

<!-- gh-comment-id:971960505 --> @Cyberavater commented on GitHub (Nov 17, 2021): > Alright, their approach is a bit hacky but works Nice, since you're interested in implementing it, I'll add this issue here for you to read, https://github.com/violentmonkey/violentmonkey/issues/1396 [You'll know why I added 'almost', you can try to fix or ignore this since it only happens on kiwi]
Author
Owner

@marcelklehr commented on GitHub (Dec 5, 2021):

sigh

That's the problem with hacks. They are often not officially supported :/

<!-- gh-comment-id:986281162 --> @marcelklehr commented on GitHub (Dec 5, 2021): *sigh* That's the problem with hacks. They are often not officially supported :/
Author
Owner

@Cyberavater commented on GitHub (Dec 10, 2021):

But the Tempermoney implementation is just perfect, I haven't encountered any issues with that (but alas it's closed source).

<!-- gh-comment-id:990615127 --> @Cyberavater commented on GitHub (Dec 10, 2021): But the Tempermoney implementation is just perfect, I haven't encountered any issues with that (but alas it's closed source).
Author
Owner

@marcelklehr commented on GitHub (Mar 14, 2022):

Sorry.

<!-- gh-comment-id:1066758557 --> @marcelklehr commented on GitHub (Mar 14, 2022): Sorry.
Author
Owner

@github-actions[bot] commented on GitHub (Mar 20, 2023):

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

<!-- gh-comment-id:1476306229 --> @github-actions[bot] commented on GitHub (Mar 20, 2023): This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/floccus#653
No description provided.