mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-26 14:45:59 +03:00
[GH-ISSUE #998] Use different Oauth for Google login #653
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#653
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Cyberavater on GitHub (Nov 17, 2021).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/998
When I log in using google login for other services, the page opens up on a new tab I can use many features (i.e Choose Gmail account or Gmail autocomplete, auto password fill-up (by password manager extension), and even no 2 fact verification if the account is already logged in on the same browser.)
I'm not sure how it's currently implemented in floccus but its functionality lacks in many ways that much I can tell.
@github-actions[bot] commented on GitHub (Nov 17, 2021):
Hi @Cyberavater! This issue is being automatically closed because it does not follow the issue template.
@github-actions[bot] commented on GitHub (Nov 17, 2021):
Hi @Cyberavater! This issue is being automatically closed because it does not follow the issue template.
@Cyberavater commented on GitHub (Nov 17, 2021):
This also actually causes login issues on many browsers (#919 and #921). If possible, please have a look at it.
@marcelklehr commented on GitHub (Nov 17, 2021):
As far as I can remember, what floccus does is the standard (possibly the only) way to do OAuth in a web extension, that's why there is a web extension API for it. I'm aware that some browsers crash upon using this API, but that doesn't make it non-standard, IMHO. I'm happy to be proven wrong, though.
@Cyberavater commented on GitHub (Nov 17, 2021):
Hi, thanks for responding. Please check Tampermonkey's way of Google Oauth implementation, it opens up the Oauth in a new tab that retains all functionality (mentioned above) and I've seen no browser crashed so far with that.
Edit: Altho, I'm not sure how much it'll help since Tampermonkey is not Open Source anymore and I'm not sure if Tampermonkey had this in the older version.
@marcelklehr commented on GitHub (Nov 17, 2021):
Yeah, I don't think it did, code search doesn't yield anything :/
@Cyberavater commented on GitHub (Nov 17, 2021):
Okay, check this one, (Violentmonkey) it's full FOSS and its Google login also works
almostnicely.@marcelklehr commented on GitHub (Nov 17, 2021):
Alright, their approach is a bit hacky but works
@github-actions[bot] commented on GitHub (Nov 17, 2021):
Hi @Cyberavater! This issue is being automatically closed because it does not follow the issue template.
@marcelklehr commented on GitHub (Nov 17, 2021):
aah. fml
@Cyberavater commented on GitHub (Nov 17, 2021):
Nice, since you're interested in implementing it, I'll add this issue here for you to read, https://github.com/violentmonkey/violentmonkey/issues/1396
[You'll know why I added 'almost', you can try to fix or ignore this since it only happens on kiwi]
@marcelklehr commented on GitHub (Dec 5, 2021):
sigh
That's the problem with hacks. They are often not officially supported :/
@Cyberavater commented on GitHub (Dec 10, 2021):
But the Tempermoney implementation is just perfect, I haven't encountered any issues with that (but alas it's closed source).
@marcelklehr commented on GitHub (Mar 14, 2022):
Sorry.
@github-actions[bot] commented on GitHub (Mar 20, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.