mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 22:26:06 +03:00
[GH-ISSUE #863] HTTP redirect detection breaks connection in some (corporate) networks #558
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#558
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @efelon on GitHub (Apr 8, 2021).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/863
Describe the bug
I want to use one of my NC bookmark app server folders on my company PC. Since a few weeks syncing is not possible any more with the error:
Syncing failed with E033: Redirect detected.( I guess:
github.com/floccusaddon/floccus@6946fc96c1)I'm aware that there is a zscaler proxy which fiddles with the connection. Sync outside of the company network is as expected.
I was not sure whether to label it a bug or feature request. But since it broke a working setup I went with bug.
Expected behavior
For this it would be good to have an option, which is default on, to deactivate this redirect check.
Desktop
Server
Debug log
@marcelklehr commented on GitHub (Apr 8, 2021):
Does the nextcloud URL you entered redirect to a different location? If so, then syncing is unlikely to work reliably. Make sure to enter the redirect target in the floccus settings instead.
@efelon commented on GitHub (Apr 8, 2021):
No, the URL stays the same. I am logged in within the same browser to that account on the NC webui. I'm also doing CalDav connections to the same instance from this PC only floccus stopped connecting.
One obvious difference is that the SSL certificate issuer is different. It's from this zscaler proxy system my company uses. That's why I suspected it to be the problem.
My setup hasn't changed when floccus stopped connecting with that error.
Company PC -https(company cert)-> Company Proxy -https(letsencrypt)-> Home Nginx SSL proxy -(http)-> nginx NC server
Do you know what exactly is detected as redirect by that function.
@marcelklehr commented on GitHub (Apr 8, 2021):
According to the spec only 301 or 302 responses should be detected as a redirect.
So, from what I can see at the moment, either your proxy chain somehow returns a 30{1,2} at some point, or your browser is doing something funky.
You could try intercepting network traffic as follows:
Firefox
about:debugging->This firefoxdebugbutton next to floccus entrysync nowfor the account of your choice.Chrome
chrome://extensionsDeveloper modedist/html/background.htmlbutton in floccus' entry next to "Inspect views: "sync nowfor the account of your choice@efelon commented on GitHub (Apr 8, 2021):
From Firefox (and Chrome) I get a 307 from the company proxy:
Request:
Response:
@marcelklehr commented on GitHub (Apr 8, 2021):
Ah. I didn't consider 307 and 308. I'll make sure those are given a pass.
@marcelklehr commented on GitHub (Apr 9, 2021):
Sadly, it doesn't seem to be possible to distinguish between different redirect status codes :/
So, the options are now
a) prohibit all redirects, breaking 307 and 308
b) allow all redirects, giving a confusing error message for people that unknowingly have a 301/302 in their URL (POSTing to a 301 URL will redirect to a GET, breaking sync)
Update: I've opened an issue for this: https://github.com/whatwg/fetch/issues/1212
@efelon commented on GitHub (Apr 9, 2021):
It's hard for me to tell how special my case is for your user base. I would be out of options when you choose a).
I don't know how much effort it would be, but
c) to create a GUI (or even more hidden) option: Allow redirects
By default you would block them.
@marcelklehr commented on GitHub (Jul 14, 2021):
I think c is a good path forward. :)
@efelon commented on GitHub (Aug 6, 2021):
Thank you very much.
I confirm the fix is working.
@github-actions[bot] commented on GitHub (Mar 20, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.