mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 22:26:06 +03:00
[GH-ISSUE #46] Beta phase for v2.0.0 #45
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#45
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @marcelklehr on GitHub (Jan 4, 2018).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/46
Hello there,
anyone who's up for a bit of testing in order to get an earlier glimpse at the new features of the upcoming floccus (folder sync ;)) version can follow the guide below.
Folders are now synced by utilizing specialized tags that contain the path of the folder the bookmark is in, e.g.
floccus:>your>folder.Installation
Note: You'll need
the latest changes of the bookmarks app on the server as well.version 0.11.0 of the bookmarks app in your nextcloud .Chrome (separate testing installation)
chrome://extensions/Load unpacked extensionand select the root folder of the floccus buildChrome (direct upgrade)
chrome://extensions/.crxfile into the page to installFirefox (separate testing installation; cannot upgrade)
about:debuggingLoad tempoprary addonand select the manifest file in the root folder of the floccus buildDebugging
In case you experience problems, file an issue on this repo. In order to aid in debugging, please provide client-side logs:
Firefox
about:debuggingdebugbutton next to floccus entryforce Syncfor the account of your choice.Chrome
chrome://extensionsDeveloper modedist/html/background.htmlbutton in floccus' entry next to "Inspect views: "force Syncfor the account of your choiceCheers!
Marcel
@marcelklehr commented on GitHub (Jan 31, 2018):
It turns out the choice of magic string (
__floccus-path:) was a bit too verbose, it leads some users to think there's something wrong and clutters up the UI with useless text, so I'm thinking about changing it to something likefloccus:/foo/bar@kgraefe commented on GitHub (Feb 1, 2018):
Sounds good to me.
@jookk commented on GitHub (Feb 3, 2018):
I getting some error in chrome.
Error loading extension
Impossible to load extension from source folder...
Impossible to load page on backgroud „dist/html/background.html“.
tried from unpacked zip
@marcelklehr commented on GitHub (Feb 3, 2018):
@jookk ah, my bad. I forgot to add the zipped build to the release (the zipped source will not work). Here you go :)
@jookk commented on GitHub (Feb 4, 2018):
@marcelklehr Thank You! Beta created new folder on my chrome bookmarks and downloaded all nc bookmarks to that.
But, I missing mobile sync (import bookmarks to mobile ff or chrome) :(
@marcelklehr commented on GitHub (Feb 4, 2018):
@jookk Yes, ideally you would be able to install floccus on firefox for android (see #3). Until Firefox for android supports this, you can make use of the following android app: https://github.com/theScrabi/OCBookmarks It's not the same, but it works.
@marcelklehr commented on GitHub (Feb 15, 2018):
Unfortunately, I've discovered that having tags with slashes in them breaks the nextcloud REST API, due to Apache decoding even the urlencoded slashes and treating them as path separators. The result is that people cannot delete the tags floccus sets in nextcloud. It's still possible to remove tags from a bookmark, but deleting a tag from the app directly is not possible when it contains slashes. (see https://github.com/nextcloud/bookmarks/issues/441)
So, I'm also considering changing the path separator for these tags, even though I'm unhappy about that. I'm thinking maybe
>, as it indicates a direction?so, e.g. instead of
floccus:/blog articles/technology/it'd befloccus:>blog articles>technology>.Using colons might be easier on the eyes, though:
floccus::blog articles:technology:,or even the infamous backslash:
floccus:\blog articles\technology\@SoftwareEngineer commented on GitHub (Feb 21, 2018):
Hi!
I tried your latest dev branch and I am hitting the following error intermittently:
Fetching bookmarks Object { type: "nextcloud", url: "https://www/nextcloud", username: "user", password: "password", syncing: true, error: "creatUrl is not defined" }Any idea what is going wrong? Sometimes when I start all over and just add one bookmark it fails like this. Other times it works. I don't even add a folder. I have the latest bookmarks app github source on my Nextcloud server.
@marcelklehr commented on GitHub (Feb 21, 2018):
Hey @SoftwareEngineer
thanks for reporting this. I've just fixed the typo :)
@SoftwareEngineer commented on GitHub (Feb 22, 2018):
@marcelklehr Appreciate the quick fix! Now it starts to sync but then I run into the following error (no message found in nextcloud.log):
Fetching bookmarks Object { type: "nextcloud", url: "https://www/nextcloud", username: "user", password: "pass", syncing: true, error: "nextcloud API returned error" }But then I also see the following afterwards:
Object { data: Array[274], status: "success" }@marcelklehr commented on GitHub (Feb 22, 2018):
@SoftwareEngineer Since you appear to be acquainted with the browser dev tools, you could check the Network tab to see exactly what happens to the request that gets an error response. ;)
@SoftwareEngineer commented on GitHub (Feb 25, 2018):
@marcelklehr So I found one bookmark causing an error presumably because there were some strange characters in the title ("—"). So I deleted it and removed everything and synced again. I am still getting "error" in the GUI but don't see an error in the Network tab anymore after removing the mentioned bookmark. However, I am sync'ing a lot of bookmarks and my server is fairly slow so it is taking a long time. Do you have a timeout that is kicking in or something that is causing it to show error in the GUI?
@marcelklehr commented on GitHub (Feb 25, 2018):
@SoftwareEngineer Can you post the error caused by the bookmark with the strange title? regarding the large set of bookmarks, I think it's unlikely that's causing problems. There might simply be other client-side bugs. What does the error message say? (Hover over the Error in the GUI.)
@marcelklehr commented on GitHub (Feb 25, 2018):
@SoftwareEngineer I just found an error concerning the creation of bookmarks on the server, in the develop branch. That might have been the bug you ran into. Should be fixed now.
@SoftwareEngineer commented on GitHub (Feb 27, 2018):
@marcelklehr Regarding strange title issue. Here is the request:
"postData": { "mimeType": "multipart/form-data; boundary=---------------------------164086561520606906801937991141", "params": [], "text": "-----------------------------164086561520606906801937991141\r\nContent-Disposition: form-data; name=\"url\"\r\n\r\nfile:///home/abc/nextcloud/file.html\r\n-----------------------------164086561520606906801937991141\r\nContent-Disposition: form-data; name=\"title\"\r\n\r\nFile's — abc\r\n-----------------------------164086561520606906801937991141\r\nContent-Disposition: form-data; name=\"item[tags][]\"\r\n\r\nfloccus:/foldername/\r\n-----------------------------164086561520606906801937991141--\r\n"Response:
"response": { "status": 400, "statusText": "Bad request", "httpVersion": "HTTP/1.1", "headers": [ ... ], "cookies": [], "content": { "mimeType": "application/json; charset=utf-8", "size": 18, "text": "{\"status\":\"error\"}" }, "redirectURL": "", "headersSize": 2282, "bodySize": 2300 },@SoftwareEngineer commented on GitHub (Feb 27, 2018):
@marcelklehr Thanks for fixing the issue concerning the creation of bookmarks on the server! It seems to be working now. The only issue is the one with the strange title but that is not a big deal at all. The title should be cleaned up anyway.
However, one thing is that when sync'ing the bookmarks firefox pegs the cpu @ 100% and firefox becomes very unresponse. Is there something that can be done about that?
@marcelklehr commented on GitHub (Feb 28, 2018):
@SoftwareEngineer Good news: The problem with the title is already fixed in nextcloud/bookmarks#424 🎉 (Without intending to :D)
I'll see what I can do about that cpu blockage :)
@marcelklehr commented on GitHub (Mar 1, 2018):
Beta 2 is out now, with custom folders, polished UI, the new tag prefix, and smarter syncing. 🎉
@marcelklehr commented on GitHub (Mar 11, 2018):
The beta should work with the bookmarks app out of the box, now, starting with the new version: v0.11.0 :)
@ffuentes commented on GitHub (Mar 13, 2018):
Hi,
i'm getting issues with spaces and latin chars in folders.
Nextcloud version: 13.0.0
Bookmarks app: 0.11.0
Floccus version: 2.0.0 beta2
It does sync (and freezes! for about half a minute).
By the way, thanks for it! If there is anything to help with debuging just let me know.
@phreaker0 commented on GitHub (Mar 14, 2018):
I discovered the develop branch some days ago and finally can sync my bookmarks again across my devices and browsers. Big thx for your work here. The issues I came across:
@marcelklehr commented on GitHub (Mar 14, 2018):
Thanks for the feedback, folks!
@ffuentes The %-encoded characters are by design for now, but I will fix that. The freezing is fixed already, but hasn't made it into the beta 2 release :)
@phreaker0 I will look into the automatic folder removal. I would rather fix the problems with acceptance of protocols on the server-side (the complete break of the sync process is a safety measure for now, but will probably be a good opportunity for improvement). The error message is fixed now, though. :)
@phreaker0 commented on GitHub (Mar 14, 2018):
You mean that the error message should be fixed in the current develop HEAD, because I'm running that :-)
@marcelklehr commented on GitHub (Mar 14, 2018):
@phreaker0 Sorry, I meant I've fixed it locally. I've just pushed to the repo, so if you pull from the repo now it should be fixed for you, too :)
@marcelklehr commented on GitHub (Mar 14, 2018):
btw, don't run develop in a production environment, mind you, it will eat your bookmarks! :D (Especially the changes I've just pushed shouldn't be run with an account that's already been setup...)
@phreaker0 commented on GitHub (Mar 15, 2018):
thx.
no risk no fun :-D I'm aware of the bleeding edge status, I have backups for that.
@phreaker0 commented on GitHub (Mar 15, 2018):
i like the new status icons and the folder removal works for me, great stuff!
@marcelklehr commented on GitHub (Mar 16, 2018):
So, on the protocol front we decided to not add file or javascript to the accepted protocols on the server: https://github.com/nextcloud/bookmarks/issues/454
Thanks for the feedback on the badges :)
@phreaker0 commented on GitHub (Mar 16, 2018):
this is a pity, thanks for considering it.
@marcelklehr commented on GitHub (Mar 16, 2018):
I think I'll opt to ignore those bookmarks then, since throwing errors might be useless as most users
probably don't even want to remove those bookmarks.
@phreaker0 commented on GitHub (Mar 17, 2018):
That would be nice, as I could move back the unsupported bookmarks to the toolbar.
@marcelklehr commented on GitHub (Mar 17, 2018):
.......aaand it's out there. v2.0.0 is released! Thanks for your help testing the changes ❤️ :)
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.