mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-26 06:35:59 +03:00
[GH-ISSUE #648] error sync with unicode emoji in bookmark's title #427
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#427
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @belgotux on GitHub (Aug 28, 2020).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/648
Describe the bug
I've try to do the first synchronisation with an empty nextcloud bookmarks and a lot for bookmarks on Firefox.
To Reproduce
Steps to reproduce the behavior:
The log is attached
floccus-4.3.0-2020-08-28.log.txt
I've seen that the server path is empty by default (/ in grey).
After that, I've try to modify server path to "/perso". And work well create a "perso" directory to the root of nextcloud bookmarks.
After that another think :
Expected behavior
Sync the bookmarks on firefox to the root directory of nextcloud bookmarks.
Desktop (please complete the following information):
Server (please complete the following information):
Debug log
log of the first try : floccus-4.3.0-2020-08-28.log.txt
I can do other test if needed, ask me.
I'll doing a review on my blog for your great module after all my test ;)
@marcelklehr commented on GitHub (Aug 28, 2020):
I think the problem is that floccus by default creates an empty folder on the client side that it syncs. And that is initially empty, of course. So, you'll have to explicitly set the local folder when setting up sync.
Awesome! :)
@belgotux commented on GitHub (Aug 28, 2020):
Can't possible to sync on the root folder of nextcloud bookmarks ? Because inside this blank folder, only two folders : bookmarks bar and bookmarks menu.
Now A big part of my bookmarks is sync (it takes time the first time, I've too many bookmarks -_-), but stopped after 3936 bookmarks.
Here the error and I've send you by your secure link the logfile(floccus-4.3.0-2020-08-28.log-2.txt). I've seen nothing wrong. Maybe special characters in name ?
@marcelklehr commented on GitHub (Sep 1, 2020):
That could be. Can you check the nextcloud log for errors? Also, it might help to check what exactly is returned on that request that cannot be parsed. See below for a how-to.
How to debug network
Firefox
about:debuggingdebugbutton next to floccus entrysync nowfor the account of your choice.Chrome
chrome://extensionsDeveloper modedist/html/background.htmlbutton in floccus' entry next to "Inspect views: "sync nowfor the account of your choice@belgotux commented on GitHub (Sep 8, 2020):
Hello,
Sorry for the delay, no time, big production release this weekend.
I've time today and I've seen the error. It's the string of the title from the website https://wificard.bdw.to/
I've attached the full nextcloud log in your shared space, you can see the 500 error during the POST at line 168.
I've done a debug on the plugin (use it for work but I don't knowed this for a plugin)
curl "https://xxx/index.php/apps/bookmarks/public/rest/v2/bookmark" -H "User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0" -H "Accept: */*" -H "Accept-Language: fr,fr-FR;q=0.8,be-FR;q=0.6,en-US;q=0.4,en;q=0.2" --compressed -H "Content-type: application/json" -H "Authorization: Basic ZzpDWHpyei14R01QTS16UHlabS13NEE5ai1HbVdSaw==" -H "Origin: moz-extension://4d2e7b87-982d-4eaa-b46c-75b711324eb3" -H "DNT: 1" -H "Connection: keep-alive" -H "TE: Trailers" --data-raw "{""url"":""https://wificard.bdw.to/"",""title"":""📡 WiFi Card qrcode"",""folders"":[460]}"request just before is maybe relevent too :
curl "https://xxx/index.php/apps/bookmarks/public/rest/v2/bookmark" -H "User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0" -H "Accept: */*" -H "Accept-Language: fr,fr-FR;q=0.8,be-FR;q=0.6,en-US;q=0.4,en;q=0.2" --compressed -H "Content-type: application/json" -H "Authorization: Basic ZzpDWHpyei14R01QTS16UHlabS13NEE5ai1HbVdSaw==" -H "Origin: moz-extension://4d2e7b87-982d-4eaa-b46c-75b711324eb3" -H "DNT: 1" -H "Connection: keep-alive" -H "TE: Trailers" --data-raw "{""url"":""https://wificard.bdw.to/"",""title"":""📡 WiFi Card qrcode"",""folders"":[460]}"I've modified the name of the bookmarks and it works until the next error with https://sploitus.com/
curl "https://xxx/index.php/apps/bookmarks/public/rest/v2/bookmark" -H "User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0" -H "Accept: */*" -H "Accept-Language: fr,fr-FR;q=0.8,be-FR;q=0.6,en-US;q=0.4,en;q=0.2" --compressed -H "Content-type: application/json" -H "Authorization: Basic ZzpDWHpyei14R01QTS16UHlabS13NEE5ai1HbVdSaw==" -H "Origin: moz-extension://4d2e7b87-982d-4eaa-b46c-75b711324eb3" -H "DNT: 1" -H "Connection: keep-alive" -H "TE: Trailers" --data-raw "{""url"":""https://sploitus.com/"",""title"":""💀 Sploitus | Exploit & Hacktool Search Engine"",""folders"":[554]}"I think it's the new unicode emoji done problem with floccus.
Bug identified, 90% of the work is done :p
@belgotux commented on GitHub (Sep 8, 2020):
I've rename the title for the true bug, the first error was a feature chose ;)
@marcelklehr commented on GitHub (Sep 8, 2020):
Try this: https://github.com/marcelklehr/floccus#troubleshooting
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.