mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-26 14:45:59 +03:00
[GH-ISSUE #547] Cannot read property 'filter' of undefined #381
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#381
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @joshcsullivan on GitHub (Jun 3, 2020).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/547
Describe the bug
I stupidly updated NC Bookmarks to 3.1.0 without checking how long it's been out (~2 hours), and floccus immediately came up with this error in Brave (Chromium):
Cannot read property 'filter' of undefined. Firefox (which uses another server folder) comes back with:this.children is undefined. I've tried removing the account, removing the local bookmarks and setting sync up again, but still having the same issue.To Reproduce
Steps to reproduce the behavior:
Expected behavior
floccus syncs local changes to NC Bookmarks.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Server (please complete the following information):
Note: Please write down the actual version numbers instead of writing 'latest'.
Debug log
It is often useful to provide a debug log file along with the issue. You can obtain a debug log of the most recent sync runs by clicking 'Debug log' in the bottom right corner of the floccus panel in your browser.
Note: As your debug log usually contains large parts of your bookmark data, instead of attaching it publicly to the issue here, I recommend uploading it privately at the following URL https://klehranlage.net/index.php/s/7nn82NSBsfQKdsJ
File Name:
GitHub_Issue-547_floccus-4.1.0-2020-06-03Additional context
I also use nextBookmark on iOS, and it is syncing correctly, just as a point of reference that NextCloud sync is still working.
Cheers,
Josh
@crh0831 commented on GitHub (Jun 3, 2020):
Same. Nothing new to contribute except that it's affecting me the exact same way. It appears the update to Nextcloud Bookmarks 3.1.0 is the casue.
@marcelklehr commented on GitHub (Jun 3, 2020):
Yep. v3.1.1 is out already. Update the bookmarks app to get the fix :)
@marcelklehr commented on GitHub (Jun 3, 2020):
It's a double bug. A bug in nextcloud bookmarks caused a bug in floccus 🙀
@Erebus999 commented on GitHub (Jun 3, 2020):
Same here
@crh0831 commented on GitHub (Jun 3, 2020):
Maybe I'm doing this wrong, but since I haven't receive the notification to install the Nextcloud Bookmarks update I looked to see if I could manually install the fix. The diff between 3.1.0 and 3.1.1 (other than version numbers) is one character on one line.
See https://github.com/nextcloud/bookmarks/compare/v3.1.0...v3.1.1
I made the change on line 665 (per the diff file) and restarted apache, but floccus still isn't working.
Again, maybe I did the patch wrong (I only changed line 665).
Anyone know how to force Nextcloud to look for app updates?
@marcelklehr commented on GitHub (Jun 3, 2020):
The floccus update of today definitely fixes the client-side bug, so until the bookmarks update reaches you, an update of floccus should take care of things.
@joshcsullivan commented on GitHub (Jun 3, 2020):
The new Firefox extension update 4.2.0, it started working immediately, without the 3.1.1 NC Bookmarks update yet.
No new Chrome Extension of yet, so waiting patiently.
Thanks for the quick turn around!
@Erebus999 commented on GitHub (Jun 4, 2020):
@crh0831
THX
Edit line line 665 and its works.
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.