mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 14:16:12 +03:00
[GH-ISSUE #40] Feature request: Stop trying to sync without a username and password even entered. #37
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#37
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mannp on GitHub (Dec 15, 2017).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/40
Thanks for the plugin, its great, but this niggles me every time I have to setup a new user.
At each point of adding details fail2ban bans the client for repeated incorrect connections, meaning I have to unban and quickly enter the details.
It doesn't make sense for the plugin to try and connect without any details / complete details.
Can the plugin connect when the details are all added, or have it that it starts trying to connect on a force start by the user?
Thanks for your consideration.
@marcelklehr commented on GitHub (Dec 15, 2017):
I've tried to improve the behavior of the automated connectivity check in v1.3.1, so that it waits for the user to pause typing until it checks the credentials. Given that you were apparently still on 1.3.0 when making the comment, I encourage you to try the new version to see if the new behavior is better :)
@marcelklehr commented on GitHub (Dec 18, 2017):
Upon further negative feedback tapping in the same hole, I decided to drop the validation altogether, because nothing will explode if people use the force sync button for testing their account the first time. In fact the validation only tested authentication, but not the whole sync process, so it kinda offers a false security. tl;dr thanks for you sensible advice and happy syncing :)
@mannp commented on GitHub (Dec 18, 2017):
@marcelklehr I personally much prefer your revised method in 1.3.2 👍 thanks for that.
I can add a user and when I am happy with the settings, force a sync.
No more fail2ban resetting.
Keep up the great work :)
@marcelklehr commented on GitHub (Dec 18, 2017):
Thanks :)
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.