starred/floccus

Fork 0

mirror of https://github.com/floccusaddon/floccus.git synced 2026-04-25 22:26:06 +03:00

[GH-ISSUE #382] Floccus duplicates bookmarks on the server #307

New issue

Closed

opened 2026-02-25 22:36:45 +03:00 by kerem · 5 comments

kerem commented

2026-02-25 22:36:45 +03:00

Owner

Originally created by @ratermir on GitHub (Oct 1, 2019).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/382

Floccus creates duplications of the bookmarka. I use it for syncing between two instances and it halppens that dome bookmarks are duplicate many times on the server.
I didn't observer any "logic" in this - some folders are multiplied (some of them even 10x), but most of then isn't.
It happens mainly on folders. In data downloaded from server i saw these bookmark folders have even the same ID.
I don't know who manages these IDs (whether client or server), but I suppose the ID should (or must?) be unique. So there should be a way how to avoid duplications of IDs (don't create new item with already existing ID, but merge them instead?).

I captured some data - it is attached in #383

Originally created by @ratermir on GitHub (Oct 1, 2019). Original GitHub issue: https://github.com/floccusaddon/floccus/issues/382 Floccus creates duplications of the bookmarka. I use it for syncing between two instances and it halppens that dome bookmarks are duplicate many times on the server. I didn't observer any "logic" in this - some folders are multiplied (some of them even 10x), but most of then isn't. It happens mainly on folders. In data downloaded from server i saw these bookmark folders have even the same ID. I don't know who manages these IDs (whether client or server), but I suppose the ID should (or must?) be unique. So there should be a way how to avoid duplications of IDs (don't create new item with already existing ID, but merge them instead?). I captured some data - it is attached in #383

kerem

2026-02-25 22:36:45 +03:00

closed this issue
added the
bug

waiting for more information
labels

kerem commented

2026-02-25 22:36:46 +03:00

Author

Owner

@marcelklehr commented on GitHub (Dec 4, 2019):

Mmh, I have a theory about why this is happening. Could you try to produce a debug log for a sync run that creates duplicate folders? I know this is probably not easy, but would help a lot :)

@marcelklehr commented on GitHub (Dec 4, 2019): Mmh, I have a theory about why this is happening. Could you try to produce a debug log for a sync run that creates duplicate folders? I know this is probably not easy, but would help a lot :)

kerem commented

2026-02-25 22:36:46 +03:00

Author

Owner

@ratermir commented on GitHub (Dec 4, 2019):

Ok, I'll try to capture it during christmas holiday (until then I am really busy).

@ratermir commented on GitHub (Dec 4, 2019): Ok, I'll try to capture it during christmas holiday (until then I am really busy).

kerem commented

2026-02-25 22:36:46 +03:00

Author

Owner

@marcelklehr commented on GitHub (Dec 15, 2019):

In the process of debugging #401 I stumbled into this as well, and I'm fairly certain how to avoid it. (Background: Recent floccus versions are able to bulk import a whole folder into the bookmarks app, if, however, said folder is too large to be handled before the reverse proxy timeout, or the php execution timeout, floccus will think it failed, when it actually (partially) succeeded, causing duplicate folders.) The way out of this is to avoid bulk imports for folders with too much content.

@marcelklehr commented on GitHub (Dec 15, 2019): In the process of debugging #401 I stumbled into this as well, and I'm fairly certain how to avoid it. (Background: Recent floccus versions are able to bulk import a whole folder into the bookmarks app, if, however, said folder is too large to be handled before the reverse proxy timeout, or the php execution timeout, floccus will think it failed, when it actually (partially) succeeded, causing duplicate folders.) The way out of this is to avoid bulk imports for folders with too much content.

kerem commented

2026-02-25 22:36:46 +03:00

Author

Owner

@marcelklehr commented on GitHub (Dec 17, 2019):

This should be fixed in v3.5.3

@marcelklehr commented on GitHub (Dec 17, 2019): This should be fixed in v3.5.3

kerem commented

2026-02-25 22:36:46 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Mar 21, 2023):

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions[bot] commented on GitHub (Mar 21, 2023): This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

kerem referenced this issue

2026-02-25 22:40:25 +03:00

[PR #307] [CLOSED] Bump p-queue from 5.0.0 to 6.0.1 #1499

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/floccus#307

No description provided.

Rows
Columns