mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 22:26:06 +03:00
[GH-ISSUE #347] XBEL not picking up new folders #289
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#289
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @xelcho on GitHub (Aug 8, 2019).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/347
Software versions
OS: ubuntu 18.04 lts
Steps to reproduce
Expected outcome
after multiple syncs, expected it to show up on other synced machines.
...
Actual outcome
after multiple syncs, expected it did not show up on other synced machines.
...
Debug log
@marcelklehr commented on GitHub (Aug 10, 2019):
Mh. I cannot reproduce this. Does the folder end up in the xbel file?
@xelcho commented on GitHub (Aug 15, 2019):
Sorry for the delay!
I am not able to find the folder in the xbel file.
@marcelklehr commented on GitHub (Aug 19, 2019):
Which folder did you select to be synced?
@xelcho commented on GitHub (Aug 19, 2019):
I added a new folder to Firefox (on client machine) and expected it to be picked up by floccus and replicated to other client machines. This has been the pattern that has worked in the past, and I don't recall changing anything in the mean time.
Does that answer your question?
@marcelklehr commented on GitHub (Aug 19, 2019):
Did you try syncing manually? You may also want to try the new beta, to see if this has been fixed by any chance: #338
@xelcho commented on GitHub (Aug 19, 2019):
For my understanding: Manually Sync is clicking on "Sync now" button in the extension?
I will give the beta a try.
@marcelklehr commented on GitHub (Aug 19, 2019):
Yes. But I assume you tried that already.
@xelcho commented on GitHub (Aug 19, 2019):
Thanks!
@xelcho commented on GitHub (Aug 21, 2019):
It seems that the client is hanging on sync, regardless if it is automatic or manually initiated. It gets hung at...
If I "mess" with it, I get issues with file locking.
If I delete the lock file, it hangs at the same spot.
I am not sure what I should be looking for in the debug log on client, the following are the last 2 lines:
Syncing failed with E023: Unable to clear lock file, consider deleting bm/bookmarks.xbel.lock manually.
onSyncFail
@marcelklehr commented on GitHub (Aug 21, 2019):
Can you check the debug log, when it hangs?
@xelcho commented on GitHub (Aug 22, 2019):
Client debug log:
It is working, for now, by renaming the xbel file and creating a new one. Let's see if the other clients behave. :)
@bhlevca commented on GitHub (Aug 22, 2019):
I am experiencing periodically the same behaviour and I need quite often to
delete the lock file and sometimes the xbel file. There is something
corrupting the process and I think that the locking mechanism need to be
reviewed. In particular, if a sync process is stopped for various reasons
including closing the browser, the lock file is not removed. Also,it
happens one in a while that I get duplicates, sometimes folders sometimes
duplicates inside the folder. It is so random that it is hard if not
impossible to catch.
I don't know how can I help to fix these issues.
Bogdan
ᐧ
On Thu, 22 Aug 2019 at 06:32, xelcho notifications@github.com wrote:
@xelcho commented on GitHub (Aug 22, 2019):
So on my windows 10 firefox quantum client, the sync can not complete the debug log:
Bookmark unchanged
Syncing failed with E011: Item in folder ordering is not an actual child: {"id":813,"type":"bookmark"}
E011: Item in folder ordering is not an actual child: {"id":1353,"type":"bookmark"}
E012: Folder ordering is missing some of the folder's children
E012: Folder ordering is missing some of the folder's children
E011: Item in folder ordering is not an actual child: {"id":1333,"type":"bookmark"}
onSyncFail
Please advise, thx.
@marcelklehr commented on GitHub (Aug 23, 2019):
@xelcho uh,oh. These errors suggest an inconsistency occurring somewhere in the sync algorithm. Are you using the new beta for this? Did you enable a different syncing strategy?
@bhlevca commented on GitHub (Aug 24, 2019):
Hi,
I don't use the beta version and I get occasionally the same errors.
Bogdan
On Fri, Aug 23, 2019, 19:00 Marcel Klehr, notifications@github.com wrote:
@xelcho commented on GitHub (Aug 25, 2019):
@marcelklehr So I am not using the beta, same version from start of this post (3.3.2)
Current situation:
Home Client (Ubuntu) works fine, I can add bookmarks and folders and it syncs as it should.
My work Client (Windoz 10) with firefox is the machine having fits.
Please advise.
I'm considering download the bookmarks from my work machine, wipe them and rebuild from sync.
@marcelklehr commented on GitHub (Aug 26, 2019):
I've just released v3.4.0. You can now easily run the latest code.
@xelcho commented on GitHub (Aug 26, 2019):
Thanks!
I ran it with the new release on the windows client and it hung, same issue (E011...) . So I carried through with my plan to backup, then delete all book marks and then sync.
Seems good for now.
The result is a clean sync, now I have to do a diff on the backup and current book marks. :)
@marcelklehr commented on GitHub (Sep 2, 2019):
@bhlevca Feel free to open a separate issue with your errors
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.