[GH-ISSUE #328] URL syncing issues (encoding, GET parameters) #281

Closed
opened 2026-02-25 22:36:41 +03:00 by kerem · 5 comments
Owner

Originally created by @esjarc on GitHub (Jul 19, 2019).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/328

Software versions

  • Browser: Firefox 60.8.0 ESR, Vivaldi 2.6.1566.44
  • Nextcloud: 16.0.3
  • Nextcloud Bookmarks app: -
  • Floccus: 3.3.2
  • Floccus sync method: WebDAV

Steps to reproduce

  1. Create a bookmark
  2. Sync it to another browser
  3. Compare the URLs between the source browser and the destination browser

Expected outcome

Both URL strings are identical

Actual outcome

The URLs are different:

  1. GET-parameters have a different order (which is quite annoying, since I use these URLs as templates, and some sites even break because of the reordering), e. g.
    original (Firefox): https://www.google.com/search?tbm=isch&tbs=isz:l&num=100&hl=en&gl=au&q=Floccus
    after sync (to Vivaldi): https://www.google.com/search?gl=au&hl=en&num=100&q=Floccus&tbm=isch&tbs=isz%3Al

  2. Some URLs are no longer usable, because of broken characters:
    original (Firefox): https://google.com/maps/@0,0.0,0m/?force=canvas
    after sync (to Vivaldi): https://google.com/maps/%400%2C0.0%2C0m/?force=canvas

(also happens with German umlauts in URLs on sites like https://geizhals.eu)

It makes no difference which browsers are getting synced or in which direction the syncing happens. E. g. two Firefox instances experience the same issues.
It also doesn't help to switch from WebDAV to the Nextcloud Bookmarks app.

Originally created by @esjarc on GitHub (Jul 19, 2019). Original GitHub issue: https://github.com/floccusaddon/floccus/issues/328 <!-- Hello there! Thank you for providing feedback! Please answer the below questions to allow for as smooth a process of tackling the issue as possible :) (Note: Everything surrounded by arrows, like this text for example, will not be visible.) --> ### Software versions <!-- Please provide the versions of the following software products in your set up --> - Browser: Firefox 60.8.0 ESR, Vivaldi 2.6.1566.44 - Nextcloud: 16.0.3 - Nextcloud Bookmarks app: - - Floccus: 3.3.2 - Floccus sync method: WebDAV <!-- Sync methods are either XBEL/webdav (signified as `webdav`), nextcloud Bookmarks legacy (signified as `nextcloud`), or nextcloud Bookmarks v0.14+ with folders (signified as `nextcloud-folders`) --> ### Steps to reproduce <!-- What did you do? Be as specific as possible --> 1. Create a bookmark 2. Sync it to another browser 3. Compare the URLs between the source browser and the destination browser ### Expected outcome <!-- What did you think was going to happen or what do you think should have happened? --> Both URL strings are identical ### Actual outcome <!-- What actually happened after you did the above steps? --> The URLs are different: 1. GET-parameters have a different order (which is quite annoying, since I use these URLs as templates, and some sites even break because of the reordering), e. g. original (Firefox): https://www.google.com/search?tbm=isch&tbs=isz:l&num=100&hl=en&gl=au&q=Floccus after sync (to Vivaldi): https://www.google.com/search?gl=au&hl=en&num=100&q=Floccus&tbm=isch&tbs=isz%3Al 2. Some URLs are no longer usable, because of broken characters: original (Firefox): https://google.com/maps/@0,0.0,0m/?force=canvas after sync (to Vivaldi): https://google.com/maps/%400%2C0.0%2C0m/?force=canvas (also happens with German umlauts in URLs on sites like https://geizhals.eu) It makes no difference which browsers are getting synced or in which direction the syncing happens. E. g. two Firefox instances experience the same issues. It also doesn't help to switch from WebDAV to the Nextcloud Bookmarks app. <!-- Thanks! Now, hit Submit and wait for a reply :) -->
kerem closed this issue 2026-02-25 22:36:41 +03:00
Author
Owner

@marcelklehr commented on GitHub (Jul 21, 2019):

Thank you for the feedback. URL normalization has been an issue for a while, since I chose to go with a handwritten normalizer. I've now decided to switch to plain WHATWG URL validation and normalization, which should prevent such issues in the future.

<!-- gh-comment-id:513512856 --> @marcelklehr commented on GitHub (Jul 21, 2019): Thank you for the feedback. URL normalization has been an issue for a while, since I chose to go with a handwritten normalizer. I've now decided to switch to plain WHATWG URL validation and normalization, which should prevent such issues in the future.
Author
Owner

@ghost commented on GitHub (Jul 26, 2019):

FF and Chrome has old versions.
Version
3.3.2
Size
2.35 MB
Last updated
a month ago (Jun 16, 2019)

<!-- gh-comment-id:515407548 --> @ghost commented on GitHub (Jul 26, 2019): FF and Chrome has old versions. Version 3.3.2 Size 2.35 MB Last updated a month ago (Jun 16, 2019)
Author
Owner

@marcelklehr commented on GitHub (Jul 26, 2019):

I know, I know. I don't get as much done as I would like to, these days :)

<!-- gh-comment-id:515444428 --> @marcelklehr commented on GitHub (Jul 26, 2019): I know, I know. I don't get as much done as I would like to, these days :)
Author
Owner

@esjarc commented on GitHub (Aug 2, 2019):

Both issues seem to be fixed with floccus 3.4.0.2. Thank you very much for fixing it so quickly!

<!-- gh-comment-id:517594825 --> @esjarc commented on GitHub (Aug 2, 2019): Both issues seem to be fixed with floccus 3.4.0.2. Thank you very much for fixing it so quickly!
Author
Owner

@github-actions[bot] commented on GitHub (Mar 21, 2023):

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

<!-- gh-comment-id:1477332570 --> @github-actions[bot] commented on GitHub (Mar 21, 2023): This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/floccus#281
No description provided.