mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-26 22:55:59 +03:00
[GH-ISSUE #328] URL syncing issues (encoding, GET parameters) #281
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#281
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @esjarc on GitHub (Jul 19, 2019).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/328
Software versions
Steps to reproduce
Expected outcome
Both URL strings are identical
Actual outcome
The URLs are different:
GET-parameters have a different order (which is quite annoying, since I use these URLs as templates, and some sites even break because of the reordering), e. g.
original (Firefox): https://www.google.com/search?tbm=isch&tbs=isz:l&num=100&hl=en&gl=au&q=Floccus
after sync (to Vivaldi): https://www.google.com/search?gl=au&hl=en&num=100&q=Floccus&tbm=isch&tbs=isz%3Al
Some URLs are no longer usable, because of broken characters:
original (Firefox): https://google.com/maps/@0,0.0,0m/?force=canvas
after sync (to Vivaldi): https://google.com/maps/%400%2C0.0%2C0m/?force=canvas
(also happens with German umlauts in URLs on sites like https://geizhals.eu)
It makes no difference which browsers are getting synced or in which direction the syncing happens. E. g. two Firefox instances experience the same issues.
It also doesn't help to switch from WebDAV to the Nextcloud Bookmarks app.
@marcelklehr commented on GitHub (Jul 21, 2019):
Thank you for the feedback. URL normalization has been an issue for a while, since I chose to go with a handwritten normalizer. I've now decided to switch to plain WHATWG URL validation and normalization, which should prevent such issues in the future.
@ghost commented on GitHub (Jul 26, 2019):
FF and Chrome has old versions.
Version
3.3.2
Size
2.35 MB
Last updated
a month ago (Jun 16, 2019)
@marcelklehr commented on GitHub (Jul 26, 2019):
I know, I know. I don't get as much done as I would like to, these days :)
@esjarc commented on GitHub (Aug 2, 2019):
Both issues seem to be fixed with floccus 3.4.0.2. Thank you very much for fixing it so quickly!
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.