[PR #2008] [MERGED] Fix "failed to map parentId" errors and other correctness fixes #1978

New issue

Closed

opened 2026-02-25 23:31:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:31:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/floccusaddon/floccus/pull/2008
Author: @marcelklehr
Created: 7/30/2025
Status: ✅ Merged
Merged: 8/2/2025
Merged by: @marcelklehr

Base: develop ← Head: fix/correctness-fixes

📝 Commits (10+)

112a321 fix: Fix "failed to map parentId" errors
0b65ac9 fix(SyncProcess): Correct variable names in reconcileReorderings()
ca77653 fix: Refactor and speed up Diff.findChain
45df376 fix(Diff.findChain): Improve cache key construction perf
d573db7 fix(BrowserTree): Do not move items across folders in orderFolder()
cf56c72 fix(Diff): Fix findChains()
2253d42 fix(Mappings): Fix mappable()
1be0c22 fix(SyncProcess): reconcileReorderings based on both donePlans
226b029 fixup
db02934 fix(reconcileReorderings): Fix ID comparisons

📊 Changes

7 files changed (+135 additions, -61 deletions)

View changed files

📝 src/lib/Diff.ts (+38 -15)
📝 src/lib/Mappings.ts (+9 -2)
📝 src/lib/browser/BrowserTree.ts (+4 -0)
📝 src/lib/strategies/Default.ts (+62 -35)
📝 src/lib/strategies/Merge.ts (+3 -3)
📝 src/lib/strategies/Unidirectional.ts (+6 -0)
📝 src/test/test.js (+13 -6)

📄 Description

Signed-off-by: Marcel Klehr mklehr@gmx.net

Fix benchmark without caching
Fix linkwarden tests
Fix fake benchmark for seed 12dd05da349df3d71c9e48e764f5d50ec2bbc88d

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/floccusaddon/floccus/pull/2008 **Author:** [@marcelklehr](https://github.com/marcelklehr) **Created:** 7/30/2025 **Status:** ✅ Merged **Merged:** 8/2/2025 **Merged by:** [@marcelklehr](https://github.com/marcelklehr) **Base:** `develop` ← **Head:** `fix/correctness-fixes` --- ### 📝 Commits (10+) - [`112a321`](https://github.com/floccusaddon/floccus/commit/112a3210676d7d0d646456bf6edd543ad31438b6) fix: Fix "failed to map parentId" errors - [`0b65ac9`](https://github.com/floccusaddon/floccus/commit/0b65ac921d7d3ac57662baeb62aa337630e31f20) fix(SyncProcess): Correct variable names in reconcileReorderings() - [`ca77653`](https://github.com/floccusaddon/floccus/commit/ca77653db52e817875c319940f07df82cef1d0f6) fix: Refactor and speed up Diff.findChain - [`45df376`](https://github.com/floccusaddon/floccus/commit/45df376d1183b6fe270f3e436eff4aa16064b9d2) fix(Diff.findChain): Improve cache key construction perf - [`d573db7`](https://github.com/floccusaddon/floccus/commit/d573db771b8fdf57ca8245e68bf2fc7e6d7dece2) fix(BrowserTree): Do not move items across folders in orderFolder() - [`cf56c72`](https://github.com/floccusaddon/floccus/commit/cf56c72f860fe95b0be3531a583b7a1b3b3b041b) fix(Diff): Fix findChains() - [`2253d42`](https://github.com/floccusaddon/floccus/commit/2253d4285e2501d8b91acdadb1b96d95373c7c17) fix(Mappings): Fix mappable() - [`1be0c22`](https://github.com/floccusaddon/floccus/commit/1be0c22308f561627380c9a64fafb7f8f23bb14e) fix(SyncProcess): reconcileReorderings based on both donePlans - [`226b029`](https://github.com/floccusaddon/floccus/commit/226b029b0e63cc520ac5bad03cd39f74c8aa8229) fixup - [`db02934`](https://github.com/floccusaddon/floccus/commit/db02934c6260c7689db83caa268422bc74ddbdba) fix(reconcileReorderings): Fix ID comparisons ### 📊 Changes **7 files changed** (+135 additions, -61 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/Diff.ts` (+38 -15) 📝 `src/lib/Mappings.ts` (+9 -2) 📝 `src/lib/browser/BrowserTree.ts` (+4 -0) 📝 `src/lib/strategies/Default.ts` (+62 -35) 📝 `src/lib/strategies/Merge.ts` (+3 -3) 📝 `src/lib/strategies/Unidirectional.ts` (+6 -0) 📝 `src/test/test.js` (+13 -6) </details> ### 📄 Description Signed-off-by: Marcel Klehr <mklehr@gmx.net> - [x] Fix benchmark without caching - [x] Fix linkwarden tests - [ ] Fix fake benchmark for seed 12dd05da349df3d71c9e48e764f5d50ec2bbc88d --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-25 23:31:25 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/floccus#1978

No description provided.

Rows
Columns