[PR #1953] [MERGED] feat: Add Karakeep sync #1965

New issue

Closed

opened 2026-02-25 23:31:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:31:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/floccusaddon/floccus/pull/1953
Author: @MohamedBassem
Created: 5/11/2025
Status: ✅ Merged
Merged: 5/31/2025
Merged by: @marcelklehr

Base: develop ← Head: add-karakeep

📝 Commits (10+)

d6f69d0 feat: Add Karakeep sync
3be6a73 Update icon
3533bb0 Merge branch 'add-karakeep' of github.com:MohamedBassem/floccus into MohamedBassem-add-karakeep
c044f08 fix(build): Run lint:fix
e9e01d4 Fix the db migration problem
1b55fc8 attempt fix server address
7a4a02d some more test fixes
7d454a3 down to a single failing test
eddb2de Attempt to fix the server connection issue in tests
9eba1c3 fix(tests)

📊 Changes

14 files changed (+978 additions, -30 deletions)

View changed files

📝 .github/workflows/tests.yml (+12 -0)
📝 _locales/en/messages.json (+18 -0)
📝 src/lib/Account.ts (+1 -0)
➕ src/lib/adapters/Karakeep.ts (+557 -0)
📝 src/test/test.js (+20 -11)
➕ src/ui/components/OptionsKarakeep.vue (+198 -0)
📝 src/ui/components/native/Drawer.vue (+1 -0)
📝 src/ui/store/actions.js (+15 -0)
📝 src/ui/store/definitions.js (+1 -0)
📝 src/ui/store/native/actions.js (+14 -0)
📝 src/ui/views/AccountOptions.vue (+7 -1)
📝 src/ui/views/NewAccount.vue (+59 -0)
📝 src/ui/views/native/Options.vue (+7 -1)
📝 test/selenium-runner.js (+68 -17)

📄 Description

Hi there, I'm the maintainer of Karakeep!

Adding a sync with Karakeep is apparently a popular FR on Floccus (#1745) and on Karakeep (https://github.com/karakeep-app/karakeep/issues/712), so I took a stab at implementing it.

The way I implemented it is that I mimic-ed your implementation for Linkwarden exactly and changed the APIs to be that of Karakeep, hopefully that'll be good enough. There were some places where I saw some inconsistent casing (e.g. in i18n label names), but I kept them the same as those of linkwarden for consistency.

I tested the extension locally, and it works, you can see it in action here:

https://github.com/user-attachments/assets/5d2cad68-3f58-4e34-aef4-da0156d48e9f

However, what I didn't do is run the extensions' tests yet which I'll do after getting some provisional review from you.

EDIT: Just noticed that I wrote floccus incorrectly in the demo, sorry! :D

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/floccusaddon/floccus/pull/1953 **Author:** [@MohamedBassem](https://github.com/MohamedBassem) **Created:** 5/11/2025 **Status:** ✅ Merged **Merged:** 5/31/2025 **Merged by:** [@marcelklehr](https://github.com/marcelklehr) **Base:** `develop` ← **Head:** `add-karakeep` --- ### 📝 Commits (10+) - [`d6f69d0`](https://github.com/floccusaddon/floccus/commit/d6f69d0673606b68032e8e2cf7e5857fbb502cda) feat: Add Karakeep sync - [`3be6a73`](https://github.com/floccusaddon/floccus/commit/3be6a734ed7a2b956767796dddee9d66b5951199) Update icon - [`3533bb0`](https://github.com/floccusaddon/floccus/commit/3533bb048b5f139a75be393b52199d634ea5e58d) Merge branch 'add-karakeep' of github.com:MohamedBassem/floccus into MohamedBassem-add-karakeep - [`c044f08`](https://github.com/floccusaddon/floccus/commit/c044f08556d53c6727eea86035b11c76b4554890) fix(build): Run lint:fix - [`e9e01d4`](https://github.com/floccusaddon/floccus/commit/e9e01d4c540c4aa1f8f059fb903f9cb4951e5bc4) Fix the db migration problem - [`1b55fc8`](https://github.com/floccusaddon/floccus/commit/1b55fc8aeaa82b1e3ddb2ac9c3bd16bccbd4df22) attempt fix server address - [`7a4a02d`](https://github.com/floccusaddon/floccus/commit/7a4a02d742fb46e83e8d99925936732e27f13067) some more test fixes - [`7d454a3`](https://github.com/floccusaddon/floccus/commit/7d454a3965e42223ec1056465f60beb27e795930) down to a single failing test - [`eddb2de`](https://github.com/floccusaddon/floccus/commit/eddb2de0e6f36c65ff78c36fd8e82a3bdf88766f) Attempt to fix the server connection issue in tests - [`9eba1c3`](https://github.com/floccusaddon/floccus/commit/9eba1c3bc4ffc78bff2236167435fc139edef3a1) fix(tests) ### 📊 Changes **14 files changed** (+978 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/tests.yml` (+12 -0) 📝 `_locales/en/messages.json` (+18 -0) 📝 `src/lib/Account.ts` (+1 -0) ➕ `src/lib/adapters/Karakeep.ts` (+557 -0) 📝 `src/test/test.js` (+20 -11) ➕ `src/ui/components/OptionsKarakeep.vue` (+198 -0) 📝 `src/ui/components/native/Drawer.vue` (+1 -0) 📝 `src/ui/store/actions.js` (+15 -0) 📝 `src/ui/store/definitions.js` (+1 -0) 📝 `src/ui/store/native/actions.js` (+14 -0) 📝 `src/ui/views/AccountOptions.vue` (+7 -1) 📝 `src/ui/views/NewAccount.vue` (+59 -0) 📝 `src/ui/views/native/Options.vue` (+7 -1) 📝 `test/selenium-runner.js` (+68 -17) </details> ### 📄 Description Hi there, I'm the maintainer of Karakeep! Adding a sync with Karakeep is apparently a popular FR on Floccus (#1745) and on Karakeep (https://github.com/karakeep-app/karakeep/issues/712), so I took a stab at implementing it. The way I implemented it is that I mimic-ed your implementation for Linkwarden exactly and changed the APIs to be that of Karakeep, hopefully that'll be good enough. There were some places where I saw some inconsistent casing (e.g. in i18n label names), but I kept them the same as those of linkwarden for consistency. I tested the extension locally, and it works, you can see it in action here: https://github.com/user-attachments/assets/5d2cad68-3f58-4e34-aef4-da0156d48e9f However, what I didn't do is run the extensions' tests yet which I'll do after getting some provisional review from you. EDIT: Just noticed that I wrote floccus incorrectly in the demo, sorry! :D --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-25 23:31:22 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/floccus#1965

No description provided.

Rows
Columns