[PR #1936] [CLOSED] fix: Rip out continuations as they never really worked anyway #1959

New issue

Closed

opened 2026-02-25 23:31:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:31:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/floccusaddon/floccus/pull/1936
Author: @marcelklehr
Created: 5/2/2025
Status: ❌ Closed

Base: develop ← Head: fix/rip-out-continuations

📝 Commits (6)

cc0b17a fix: Rip out continuations as they never really worked anyway
71a57d1 tests: Try to fix interrupt tests
8cfdf8c tests: Disable interrupt tests
653b9eb fix: Remove continuation methods from {Browser,Native}AccountStorage
aa63818 fix: fix build
2b817ca fix(Account#sync): Always run onSyncFail

📊 Changes

10 files changed (+114 additions, -125 deletions)

View changed files

📝 src/lib/Account.ts (+49 -83)
📝 src/lib/adapters/Linkwarden.ts (+2 -0)
📝 src/lib/adapters/NextcloudBookmarks.ts (+5 -3)
📝 src/lib/browser/BrowserAccountStorage.js (+0 -8)
📝 src/lib/browser/BrowserController.js (+16 -0)
📝 src/lib/interfaces/AccountStorage.ts (+0 -3)
📝 src/lib/native/NativeAccountStorage.js (+0 -8)
📝 src/lib/native/NativeController.js (+4 -1)
📝 src/lib/strategies/Default.ts (+10 -0)
📝 src/test/test.js (+28 -19)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/floccusaddon/floccus/pull/1936 **Author:** [@marcelklehr](https://github.com/marcelklehr) **Created:** 5/2/2025 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `fix/rip-out-continuations` --- ### 📝 Commits (6) - [`cc0b17a`](https://github.com/floccusaddon/floccus/commit/cc0b17aef685a7d0835df5eb5228cdd66fb865c4) fix: Rip out continuations as they never really worked anyway - [`71a57d1`](https://github.com/floccusaddon/floccus/commit/71a57d1fbd5db97d14c58c70dbd422a538833765) tests: Try to fix interrupt tests - [`8cfdf8c`](https://github.com/floccusaddon/floccus/commit/8cfdf8cb9a1653318c3addc167049b75d727b2d4) tests: Disable interrupt tests - [`653b9eb`](https://github.com/floccusaddon/floccus/commit/653b9eb643a3f91af53e54a6c663acdfec9de562) fix: Remove continuation methods from {Browser,Native}AccountStorage - [`aa63818`](https://github.com/floccusaddon/floccus/commit/aa638187129b4d1cdd01e28c69142ffe9bd431e2) fix: fix build - [`2b817ca`](https://github.com/floccusaddon/floccus/commit/2b817ca813ea2024886872e7a95d3aa9b7bd3a6d) fix(Account#sync): Always run onSyncFail ### 📊 Changes **10 files changed** (+114 additions, -125 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/Account.ts` (+49 -83) 📝 `src/lib/adapters/Linkwarden.ts` (+2 -0) 📝 `src/lib/adapters/NextcloudBookmarks.ts` (+5 -3) 📝 `src/lib/browser/BrowserAccountStorage.js` (+0 -8) 📝 `src/lib/browser/BrowserController.js` (+16 -0) 📝 `src/lib/interfaces/AccountStorage.ts` (+0 -3) 📝 `src/lib/native/NativeAccountStorage.js` (+0 -8) 📝 `src/lib/native/NativeController.js` (+4 -1) 📝 `src/lib/strategies/Default.ts` (+10 -0) 📝 `src/test/test.js` (+28 -19) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-25 23:31:21 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/floccus#1959

No description provided.

Rows
Columns