mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-26 06:35:59 +03:00
[GH-ISSUE #204] Its back: Folder ordering is missing some of the folder's children #194
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#194
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jlbprof on GitHub (Nov 30, 2018).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/204
Software versions
Debug log
I will attach it, the log is large.
Something I noticed from the logs:
@jlbprof commented on GitHub (Nov 30, 2018):
floccus-3.1.14-2018-11-30_from_home.log
@jlbprof commented on GitHub (Nov 30, 2018):
Ignore the above log, I accidentally loaded an ancient set of bookmarks.
@jlbprof commented on GitHub (Nov 30, 2018):
floccus-3.1.14-2018-11-30_from_home_2.log
Here is the new log
@jlbprof commented on GitHub (Nov 30, 2018):
This is the relevant part.
@jlbprof commented on GitHub (Nov 30, 2018):
They definitely are of different lengths. And they seem to be a mess of mis-merged bookmarks.
@jlbprof commented on GitHub (Nov 30, 2018):
I am not sure how that happened if it was months of merging that caused them to be a mixed mess. So do not worry about that, let's figure out why it failed.
@marcelklehr commented on GitHub (Nov 30, 2018):
This is the interesting part. Apparently there's the same URL bookmarked multiple times in that local folder, which is fine when ordering the local folder, but they are all synced with a single associated server bookmark. The ordering mechanism merely translates local ids to server ids, though, so ordering the server bookmarks fails because there aren't that many bookmarks on the server (more precisely, one bookmark appears multiple times in the ordering as seen below).
The question is, what we should do about this. It certainly is unexpected to the algorithm to have duplicates in the same folder. I think deduplicating local bookmarks in the same folder with the same URLs as a solution shouldn't cause trouble for users, should it?
@jlbprof commented on GitHub (Nov 30, 2018):
Deduplication is a good solution. I think the duplicates sometimes happen
because my hand slips, but I also think years of syncing have caused some
as well. First with xMarks and now with Floccus.
Julian
On Fri, Nov 30, 2018 at 5:25 PM Marcel Klehr notifications@github.com
wrote:
@mort74 commented on GitHub (Dec 3, 2018):
Just a hint: I recently used a rarely used Firefox installation, which caused this error because all old RSS bookmarks (which sadly are no longer supported) were replaced with "http://data". Maybe it'd be a good idea to filter this URL?
Oh, and separator lines.
@jlbprof commented on GitHub (Dec 3, 2018):
I do not see any http://data in my bookmarks.
I cannot imagine that would be a good filter,
Ex: http://data.mygoodsite.com/cgi-bin/my.cgi?Greeting=Howdy
That would be a legit bookmark and not an RSS feed.
Since RSS is mostly a thing from the past, it may not be worth doing a fix
for.
Julian
On Mon, Dec 3, 2018 at 2:12 AM mort74 notifications@github.com wrote:
@marcelklehr commented on GitHub (Dec 3, 2018):
@mort74 I recently implemented something that should also fix RSS bookmarks -- at least that was what was reported (see #182) Separators are a different problem, I'm not sure they're related to this error here.
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.