[PR #1828] [MERGED] Check that a URL is valid as soon as we load the Add Bookmark dialog #1937

New issue

Closed

opened 2026-02-25 23:31:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:31:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/floccusaddon/floccus/pull/1828
Author: @andybalaam
Created: 1/14/2025
Status: ✅ Merged
Merged: 1/15/2025
Merged by: @marcelklehr

Base: develop ← Head: check-shared-url-immediately

📝 Commits (1)

3899847 Check that a URL is valid as soon as we load the Add Bookmark dialog

📊 Changes

1 file changed (+11 additions, -8 deletions)

View changed files

📝 src/ui/views/native/AddBookmarkIntent.vue (+11 -8)

📄 Description

This is a part of addressing https://github.com/floccusaddon/floccus/issues/1826 - make sure that we display an error message in the Add Bookmark dialog immediately, if the shared URL is bad.

Before this change, there would be no error message in the "Add Bookmark" screen until we edited the URL, but now the error appears immediately:

I have zero Vue experience, so please let me know if I did it wrong.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/floccusaddon/floccus/pull/1828 **Author:** [@andybalaam](https://github.com/andybalaam) **Created:** 1/14/2025 **Status:** ✅ Merged **Merged:** 1/15/2025 **Merged by:** [@marcelklehr](https://github.com/marcelklehr) **Base:** `develop` ← **Head:** `check-shared-url-immediately` --- ### 📝 Commits (1) - [`3899847`](https://github.com/floccusaddon/floccus/commit/3899847c4e2b957d50b93d40dcbe8c111636590c) Check that a URL is valid as soon as we load the Add Bookmark dialog ### 📊 Changes **1 file changed** (+11 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/ui/views/native/AddBookmarkIntent.vue` (+11 -8) </details> ### 📄 Description This is a part of addressing https://github.com/floccusaddon/floccus/issues/1826 - make sure that we display an error message in the Add Bookmark dialog immediately, if the shared URL is bad. Before this change, there would be no error message in the "Add Bookmark" screen until we edited the URL, but now the error appears immediately: ![image](https://github.com/user-attachments/assets/d3b59a70-3d02-4318-b6da-2c975513769f) I have zero Vue experience, so please let me know if I did it wrong. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-25 23:31:17 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/floccus#1937

No description provided.

Rows
Columns