[PR #1807] [MERGED] fix: Don't produce UPDATE when URL changes #1935

New issue

Closed

opened 2026-02-25 23:31:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:31:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/floccusaddon/floccus/pull/1807
Author: @marcelklehr
Created: 12/24/2024
Status: ✅ Merged
Merged: 12/24/2024
Merged by: @marcelklehr

Base: develop ← Head: fix/nc-bookmarks-update

📝 Commits (3)

4d8bcf7 fix(Default#getDiffs): Don't produce UPDATEs for tabs, ever
e3e6b93 test: update the server on local changes of url collisions
d244f6d fix(SyncProcess): Fix URL collisions on NC Bookmarks

📊 Changes

2 files changed (+128 additions, -13 deletions)

View changed files

📝 src/lib/strategies/Default.ts (+66 -12)
📝 src/test/test.js (+62 -1)

📄 Description

NC Bookmarks cannot handle URL collisions

see #1804

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/floccusaddon/floccus/pull/1807 **Author:** [@marcelklehr](https://github.com/marcelklehr) **Created:** 12/24/2024 **Status:** ✅ Merged **Merged:** 12/24/2024 **Merged by:** [@marcelklehr](https://github.com/marcelklehr) **Base:** `develop` ← **Head:** `fix/nc-bookmarks-update` --- ### 📝 Commits (3) - [`4d8bcf7`](https://github.com/floccusaddon/floccus/commit/4d8bcf7e781c267085c380523ecbb97ab9b284b0) fix(Default#getDiffs): Don't produce UPDATEs for tabs, ever - [`e3e6b93`](https://github.com/floccusaddon/floccus/commit/e3e6b930706f2821988416b5098fe64e0fc16918) test: update the server on local changes of url collisions - [`d244f6d`](https://github.com/floccusaddon/floccus/commit/d244f6d44f2fb2713382cd564c179ce49fa978f1) fix(SyncProcess): Fix URL collisions on NC Bookmarks ### 📊 Changes **2 files changed** (+128 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/strategies/Default.ts` (+66 -12) 📝 `src/test/test.js` (+62 -1) </details> ### 📄 Description NC Bookmarks cannot handle URL collisions see #1804 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-25 23:31:17 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/floccus#1935

No description provided.

Rows
Columns