[PR #1687] [MERGED] Refactor to use location types #1918

New issue

Closed

opened 2026-02-25 23:31:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:31:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/floccusaddon/floccus/pull/1687
Author: @marcelklehr
Created: 7/28/2024
Status: ✅ Merged
Merged: 8/2/2024
Merged by: @marcelklehr

Base: develop ← Head: refactor/location-types

📝 Commits (10+)

92c9b99 fix(Folder#traverse)
06b8e74 refactor: Add generic types for item location
036438e refactor: Distinguish between plans of different stages and diffs
ae50c6b refactor: Get Default SyncProcess in order
ce1f052 refactor: Refactor Merge and Unidirectional strategies
dd70104 refactor: Fix Diff#findChain
d1276a5 refactor: Fix all mentions of TItem and TResource
61caf6f Merge branch 'develop' into refactor/location-types
1a035b1 fix: Folder#clone
ec567ec fix: Make default and slave tests pass

📊 Changes

26 files changed (+1542 additions, -1244 deletions)

View changed files

📝 src/errors/Error.ts (+3 -3)
📝 src/lib/Account.ts (+2 -2)
📝 src/lib/Diff.ts (+107 -99)
📝 src/lib/LocalTabs.ts (+9 -9)
📝 src/lib/Mappings.ts (+3 -3)
📝 src/lib/Scanner.ts (+75 -62)
📝 src/lib/Tree.ts (+71 -46)
📝 src/lib/adapters/Caching.ts (+13 -13)
📝 src/lib/adapters/NextcloudBookmarks.ts (+21 -21)
📝 src/lib/browser/BrowserAccount.ts (+6 -1)
📝 src/lib/browser/BrowserAccountStorage.js (+2 -2)
📝 src/lib/browser/BrowserTree.ts (+19 -19)
📝 src/lib/interfaces/AccountStorage.ts (+2 -2)
📝 src/lib/interfaces/Adapter.ts (+3 -3)
📝 src/lib/interfaces/Ordering.ts (+3 -3)
📝 src/lib/interfaces/Resource.ts (+18 -18)
📝 src/lib/interfaces/Serializer.ts (+3 -3)
📝 src/lib/native/NativeAccount.ts (+8 -0)
📝 src/lib/native/NativeAccountStorage.js (+2 -2)
📝 src/lib/native/NativeTree.ts (+14 -14)

...and 6 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/floccusaddon/floccus/pull/1687 **Author:** [@marcelklehr](https://github.com/marcelklehr) **Created:** 7/28/2024 **Status:** ✅ Merged **Merged:** 8/2/2024 **Merged by:** [@marcelklehr](https://github.com/marcelklehr) **Base:** `develop` ← **Head:** `refactor/location-types` --- ### 📝 Commits (10+) - [`92c9b99`](https://github.com/floccusaddon/floccus/commit/92c9b9917c6c10598029fef598b43619a249b85c) fix(Folder#traverse) - [`06b8e74`](https://github.com/floccusaddon/floccus/commit/06b8e74aac79a69dd318608076c03a72565f3b6f) refactor: Add generic types for item location - [`036438e`](https://github.com/floccusaddon/floccus/commit/036438e604603500c76bbd12baa396fdc136c5fd) refactor: Distinguish between plans of different stages and diffs - [`ae50c6b`](https://github.com/floccusaddon/floccus/commit/ae50c6b1eccb448fbec773ed0d50239eb1fa47a9) refactor: Get Default SyncProcess in order - [`ce1f052`](https://github.com/floccusaddon/floccus/commit/ce1f05266ea26021b262a5ee799819c666f6046a) refactor: Refactor Merge and Unidirectional strategies - [`dd70104`](https://github.com/floccusaddon/floccus/commit/dd701040c1917577b797e857f4e1e8784955ad5e) refactor: Fix Diff#findChain - [`d1276a5`](https://github.com/floccusaddon/floccus/commit/d1276a5c3a843ab615904c46e5b134d30849ccdd) refactor: Fix all mentions of TItem and TResource - [`61caf6f`](https://github.com/floccusaddon/floccus/commit/61caf6f5e63fa4e170141e361d4491b7a87e6f27) Merge branch 'develop' into refactor/location-types - [`1a035b1`](https://github.com/floccusaddon/floccus/commit/1a035b1cbd249da61c9a508ae934ae1ea2ff7e5a) fix: Folder#clone - [`ec567ec`](https://github.com/floccusaddon/floccus/commit/ec567eccffa3b98b603034efbfa69c3ec0505f91) fix: Make default and slave tests pass ### 📊 Changes **26 files changed** (+1542 additions, -1244 deletions) <details> <summary>View changed files</summary> 📝 `src/errors/Error.ts` (+3 -3) 📝 `src/lib/Account.ts` (+2 -2) 📝 `src/lib/Diff.ts` (+107 -99) 📝 `src/lib/LocalTabs.ts` (+9 -9) 📝 `src/lib/Mappings.ts` (+3 -3) 📝 `src/lib/Scanner.ts` (+75 -62) 📝 `src/lib/Tree.ts` (+71 -46) 📝 `src/lib/adapters/Caching.ts` (+13 -13) 📝 `src/lib/adapters/NextcloudBookmarks.ts` (+21 -21) 📝 `src/lib/browser/BrowserAccount.ts` (+6 -1) 📝 `src/lib/browser/BrowserAccountStorage.js` (+2 -2) 📝 `src/lib/browser/BrowserTree.ts` (+19 -19) 📝 `src/lib/interfaces/AccountStorage.ts` (+2 -2) 📝 `src/lib/interfaces/Adapter.ts` (+3 -3) 📝 `src/lib/interfaces/Ordering.ts` (+3 -3) 📝 `src/lib/interfaces/Resource.ts` (+18 -18) 📝 `src/lib/interfaces/Serializer.ts` (+3 -3) 📝 `src/lib/native/NativeAccount.ts` (+8 -0) 📝 `src/lib/native/NativeAccountStorage.js` (+2 -2) 📝 `src/lib/native/NativeTree.ts` (+14 -14) _...and 6 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-25 23:31:14 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/floccus#1918

No description provided.

Rows
Columns