[PR #1488] [MERGED] refactor: Move waiting for lock out of adapters into controller #1896

New issue

Closed

opened 2026-02-25 23:31:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:31:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/floccusaddon/floccus/pull/1488
Author: @marcelklehr
Created: 12/19/2023
Status: ✅ Merged
Merged: 12/20/2023
Merged by: @marcelklehr

Base: develop ← Head: refactor/wait-lock

📝 Commits (3)

3657c92 refactor: Move waiting for lock out of adapters into controller
c667d53 fix(Tree): Move scheduled message from tooltip to alert
8ee5783 fix(tests/locking): Adjust test to new locking behavior

📊 Changes

14 files changed (+158 additions, -98 deletions)

View changed files

📝 _locales/en/messages.json (+6 -0)
📝 manifest.json (+1 -8)
📝 src/errors/Error.ts (+8 -0)
📝 src/lib/Account.ts (+22 -3)
📝 src/lib/adapters/GoogleDrive.ts (+15 -17)
📝 src/lib/adapters/NextcloudBookmarks.ts (+7 -12)
📝 src/lib/adapters/WebDav.ts (+10 -14)
📝 src/lib/browser/BrowserController.js (+18 -22)
📝 src/lib/interfaces/Controller.ts (+5 -0)
📝 src/lib/native/NativeController.js (+36 -13)
📝 src/test/test.js (+8 -1)
📝 src/ui/components/AccountCard.vue (+4 -1)
📝 src/ui/views/Overview.vue (+0 -4)
📝 src/ui/views/native/Tree.vue (+18 -3)

📄 Description

fixes #1480
fixes #1068

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/floccusaddon/floccus/pull/1488 **Author:** [@marcelklehr](https://github.com/marcelklehr) **Created:** 12/19/2023 **Status:** ✅ Merged **Merged:** 12/20/2023 **Merged by:** [@marcelklehr](https://github.com/marcelklehr) **Base:** `develop` ← **Head:** `refactor/wait-lock` --- ### 📝 Commits (3) - [`3657c92`](https://github.com/floccusaddon/floccus/commit/3657c92c22dc61b549ae4158c7b9e97b178ba7f0) refactor: Move waiting for lock out of adapters into controller - [`c667d53`](https://github.com/floccusaddon/floccus/commit/c667d53b588bf0fb4e7007b346ab1f73447f53e9) fix(Tree): Move scheduled message from tooltip to alert - [`8ee5783`](https://github.com/floccusaddon/floccus/commit/8ee5783998fbd29f1f7c2ba333b2e87c0764d0ab) fix(tests/locking): Adjust test to new locking behavior ### 📊 Changes **14 files changed** (+158 additions, -98 deletions) <details> <summary>View changed files</summary> 📝 `_locales/en/messages.json` (+6 -0) 📝 `manifest.json` (+1 -8) 📝 `src/errors/Error.ts` (+8 -0) 📝 `src/lib/Account.ts` (+22 -3) 📝 `src/lib/adapters/GoogleDrive.ts` (+15 -17) 📝 `src/lib/adapters/NextcloudBookmarks.ts` (+7 -12) 📝 `src/lib/adapters/WebDav.ts` (+10 -14) 📝 `src/lib/browser/BrowserController.js` (+18 -22) 📝 `src/lib/interfaces/Controller.ts` (+5 -0) 📝 `src/lib/native/NativeController.js` (+36 -13) 📝 `src/test/test.js` (+8 -1) 📝 `src/ui/components/AccountCard.vue` (+4 -1) 📝 `src/ui/views/Overview.vue` (+0 -4) 📝 `src/ui/views/native/Tree.vue` (+18 -3) </details> ### 📄 Description fixes #1480 fixes #1068 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-25 23:31:10 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/floccus#1896

No description provided.

Rows
Columns