[PR #1396] [MERGED] Migrate to manifest v3 #1882

Closed
opened 2026-02-25 23:31:07 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/floccusaddon/floccus/pull/1396
Author: @marcelklehr
Created: 6/1/2023
Status: Merged
Merged: 8/27/2023
Merged by: @marcelklehr

Base: developHead: enh/manifest-v3


📝 Commits (10+)

  • 8538e40 First pass migrating to manifest v3
  • 71f4132 Manifest v3: Fix browser-api
  • 8ec03ba Manifest v3: Fix Controller dispatch
  • cd7792c Manifest v3: Fix webpack development config
  • 0569df5 fix(native): Make manifest v3 changes work on android
  • b37e990 fix(native): Make manifest v3 changes work on web again
  • 02feb21 Fix manifest v3 changes to work in firefox
  • c196442 Fix BrowserController#onchange: Don't error out on deleted items
  • 652838e Fix bookmarks cahgne detection
  • e5a82f8 fix(permissions): Ask for permissions if necessary

📊 Changes

47 files changed (+791 additions, -618 deletions)

View changed files

📝 .github/workflows/tests.yml (+34 -14)
📝 _locales/en/messages.json (+3 -12)
📝 gulpfile.js (+35 -8)
html/background.html (+0 -11)
📝 html/options.html (+0 -1)
📝 html/test.html (+0 -1)
lib/chrome-promise.js (+0 -83)
manifest.chrome.json (+40 -0)
manifest.firefox.json (+47 -0)
📝 manifest.json (+11 -8)
📝 package-lock.json (+60 -27)
📝 package.json (+13 -2)
📝 src/entries/background-script.js (+2 -6)
📝 src/entries/options.js (+0 -1)
📝 src/errors/Error.ts (+8 -0)
📝 src/lib/Account.ts (+13 -7)
📝 src/lib/Controller.ts (+124 -9)
📝 src/lib/Logger.js (+4 -4)
📝 src/lib/adapters/GoogleDrive.ts (+20 -4)
📝 src/lib/adapters/NextcloudBookmarks.ts (+14 -2)

...and 27 more files

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/floccusaddon/floccus/pull/1396 **Author:** [@marcelklehr](https://github.com/marcelklehr) **Created:** 6/1/2023 **Status:** ✅ Merged **Merged:** 8/27/2023 **Merged by:** [@marcelklehr](https://github.com/marcelklehr) **Base:** `develop` ← **Head:** `enh/manifest-v3` --- ### 📝 Commits (10+) - [`8538e40`](https://github.com/floccusaddon/floccus/commit/8538e403e4db91b46e411d364bd05fc88fa4eb01) First pass migrating to manifest v3 - [`71f4132`](https://github.com/floccusaddon/floccus/commit/71f41322b727547f88d29667c5eb5543e557aa98) Manifest v3: Fix browser-api - [`8ec03ba`](https://github.com/floccusaddon/floccus/commit/8ec03ba430db3b2eaef915aa8cc6286034f712ed) Manifest v3: Fix Controller dispatch - [`cd7792c`](https://github.com/floccusaddon/floccus/commit/cd7792c6226124ba536ea6f3fec5c1ab0b1cd9c2) Manifest v3: Fix webpack development config - [`0569df5`](https://github.com/floccusaddon/floccus/commit/0569df5105ce55ac814deceb3e3aac64af39fe11) fix(native): Make manifest v3 changes work on android - [`b37e990`](https://github.com/floccusaddon/floccus/commit/b37e9905ba46838dbe99f3770356ef696ea17c22) fix(native): Make manifest v3 changes work on web again - [`02feb21`](https://github.com/floccusaddon/floccus/commit/02feb21b43278ec2879fd8258be961f1c80c1155) Fix manifest v3 changes to work in firefox - [`c196442`](https://github.com/floccusaddon/floccus/commit/c196442dc82e53e5141bd76a138eff96cbad645a) Fix BrowserController#onchange: Don't error out on deleted items - [`652838e`](https://github.com/floccusaddon/floccus/commit/652838ee5833e93e9bfe8046a828892bfac7b0f1) Fix bookmarks cahgne detection - [`e5a82f8`](https://github.com/floccusaddon/floccus/commit/e5a82f896b117965c6bf564f911cdf990b03c315) fix(permissions): Ask for permissions if necessary ### 📊 Changes **47 files changed** (+791 additions, -618 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/tests.yml` (+34 -14) 📝 `_locales/en/messages.json` (+3 -12) 📝 `gulpfile.js` (+35 -8) ➖ `html/background.html` (+0 -11) 📝 `html/options.html` (+0 -1) 📝 `html/test.html` (+0 -1) ➖ `lib/chrome-promise.js` (+0 -83) ➕ `manifest.chrome.json` (+40 -0) ➕ `manifest.firefox.json` (+47 -0) 📝 `manifest.json` (+11 -8) 📝 `package-lock.json` (+60 -27) 📝 `package.json` (+13 -2) 📝 `src/entries/background-script.js` (+2 -6) 📝 `src/entries/options.js` (+0 -1) 📝 `src/errors/Error.ts` (+8 -0) 📝 `src/lib/Account.ts` (+13 -7) 📝 `src/lib/Controller.ts` (+124 -9) 📝 `src/lib/Logger.js` (+4 -4) 📝 `src/lib/adapters/GoogleDrive.ts` (+20 -4) 📝 `src/lib/adapters/NextcloudBookmarks.ts` (+14 -2) _...and 27 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 23:31:07 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/floccus#1882
No description provided.