mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-26 06:35:59 +03:00
[GH-ISSUE #184] While rearranging, bookmarks disappeared locally and put into "undefined" tag #175
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#175
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @aktentasche on GitHub (Oct 24, 2018).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/184
Software versions
Steps to reproduce
(2. sync happens automatically)
Expected outcome
Bookmarks do not disappear
Actual outcome
First it looked like I lost a lot of bookmarks, but when I checked the bookmarks app in nextcloud, I saw they where still there but with a weird tag:
Normally it looks like this:
floccus:>MYTAG>Bookmarks Bar>wiki>Stuff
but the ones that disappeared are tagged like this:
floccus:>MYTAGundefined
I think this might be caused by the fact that I moved items while sync was still happening. Possible safety check would be to catch the situation when this happens and stop the sync process.
edit: correction, it actually looks like I lost bookmarks but will be able to reconstruct them from the debug log.
@marcelklehr commented on GitHub (Nov 5, 2018):
Could you send me an excerpt of the debug log when this happened?
@aktentasche commented on GitHub (Nov 7, 2018):
Yes, I will send it by mail as this is my work PC and I don't want to upload the doc here.
@marcelklehr commented on GitHub (Nov 8, 2018):
I think I could reproduce the problems individually. The undefined tag was a separate issue from the disappearing bookmarks. It also didn't have anything to do with you changing things while the sync was running, but rather that you did some complex rearrangement that proved some of my assumptions in the sync algorithm to be false, causing those bookmarks to disappear or go haywire. I have added tests for these issues now, and fixed them. I will release a new version shortly.
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.