mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 14:16:12 +03:00
[GH-ISSUE #176] Floccus (XBEL) is spamming the Nextcloud activity stream #168
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#168
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @marcelschmidtdev on GitHub (Oct 1, 2018).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/176
Software versions
Steps to reproduce
Expected outcome
Actual outcome
Nextcloud activity stream is spammed with "XBEL.lock file created/deleted.
Also the XBEL file with the bookmarks was changed a lot, although no changes were made in my browser.
@jlbprof commented on GitHub (Oct 1, 2018):
What do you mean by that?
The typical process is:
syncing)
Otherwise fi the file is NOT there, it will create it
When the sync process is complete it is deleted.
Is the xbel.lock file still present on your Nextcloud?
On Mon, Oct 1, 2018 at 2:27 AM Marcel Schmidt notifications@github.com
wrote:
@marcelschmidtdev commented on GitHub (Oct 1, 2018):
I attached a screenshot of my activity stream. This is only the last couple of hours.
I did not change any bookmark but the lock file is still created and the XBEL file was changed for some reason. This makes the activity feature unusable for me.
@marcelklehr commented on GitHub (Oct 1, 2018):
The only entries we can reasonably get rid of are the mutations XBEL file even though nothing has changed. The lock file needs to be used because nextcloud doesn't offer native locking via DAV: https://github.com/nextcloud/server/issues/1308
@marcelschmidtdev commented on GitHub (Oct 1, 2018):
Nice, that would be a good start to reduce the noise 👍
Is it possible to only create the lock file after we've checked for changes and are about to apply them?
Thanks for your help.
@marcelklehr commented on GitHub (Oct 1, 2018):
The problem is that the algorithm effectively uses a diff to determine the changes as neither the browser nor the XBEL file track changes. So, we only know whether something has to be updated on the server once we have downloaded the file. But if we do need to update the file on the server we need to make sure it hasn't changed since we downloaded it. We can only do that by setting a lock before downloading. In any case, If you have nextcloud installed, I generally recommend using the bookmarks app, if there's nothing to be said against it.
@marcelschmidtdev commented on GitHub (Oct 2, 2018):
That makes sense, thank you for clarification. Using a file is just more convenient for me, especially restoring a backup from a single file which is under Nextcloud version control is easier then restoring the MySQL database.
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.