mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 22:26:06 +03:00
[PR #112] [CLOSED] Julian 004 #1469
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#1469
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/floccusaddon/floccus/pull/112
Author: @jlbprof
Created: 5/30/2018
Status: ❌ Closed
Base:
master← Head:julian_004📝 Commits (10+)
15e4385Squashed commit of the following:ae68755Updated0067049Adding the new webdav brings the whole system down.b36a734* Webdav in placef891674some before updatingcd77dfeFragile but seems to be working.28c9dadUpdated from pull request comments.cd65ad0Fix some minor issues.8b2b23fFix optionsf2c3a90v2.2.4📊 Changes
10 files changed (+656 additions, -28 deletions)
View changed files
📝
CHANGELOG.md(+6 -0)📝
manifest.json(+3 -2)📝
package.json(+1 -1)📝
src/entries/options.js(+5 -1)📝
src/lib/Account.js(+8 -1)📝
src/lib/Adapter.js(+4 -0)➕
src/lib/InputInitializeHook.js(+9 -0)📝
src/lib/adapters/Nextcloud.js(+10 -23)➕
src/lib/adapters/WebDav.js(+593 -0)📝
views/options.html(+17 -0)📄 Description
This pushes an xml (xbel) format bookmark file to the server.
I had to html encode the bookmark href's that may be a problem, but if I did not I could not get the xbel to validate with complex url's (such as some with question marks and ampersands).
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.