mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-26 06:35:59 +03:00
[GH-ISSUE #1987] there is no notification if git push fails #1331
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#1331
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @stevekm on GitHub (Jul 9, 2025).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1987
Which version of floccus are you using?
5.4.5
How many bookmarks do you have, roughly?
5000
Are you using other means to sync bookmarks in parallel to floccus?
Yes
Sync method
Git
Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.
Edge Version 138.0.3351.77
Which version of Nextcloud Bookmarks are you using? (if relevant)
No response
Which version of Nextcloud? (if relevant)
No response
What kind of WebDAV server are you using? (if relevant)
No response
Describe the Bug
BitBucket recently changed its "free tier" to impose a 1GB workspace limit
https://www.atlassian.com/blog/bitbucket/important-changes-coming-to-bitbucket-clouds-free-plan
Any users who were using BitBucket as the git sync method for Floccus (via App Password or Personal Access Token) are no longer able to perform a
git pushto their remote repo once their BitBucket account uses >1GB of space across all repos. This appears to be implemented via a git pre-push hook on the remote server side.When you attempt to do a
git pushin the terminal in these situations, you get an explicit message from BitBucket telling that your account is in Read Only mode and thegit pushfails.However, Floccus does not seem to understand or notice or handle this failure. Instead, the bookmark sync from Floccus silently fails, and then Floccus syncs your current browser state with the contents of the read-only remote repo that you were using.
The end result, is that after many months of using Floccus successfully, suddenly one notices that every time they create new Bookmarks in the browser, those bookmarks keep getting mysteriously removed. I watched this happen repeatedly in real-time. I would create a new Bookmark for a web page in Edge, then leave the page open, and after some time, the blue "star" in the page toolbar (the indicator that the page is bookmarked) vanishes and the Bookmark gets deleted.
The culprit is Floccus. As described, its attempting to do the usual bookmarks sync, however it silently fails when attempting to upload new bookmarks to the remote repo. Then it reads the contents of the remote repo, and syncs them to the current browser state, deleting the bookmarks you just made.
Ultimately, I dont expect Floccus to have any sort of complicated error handling for these cases, I just want to have some sort of notification that there was an error. Because otherwise I ended up spending multiple weeks trying to debug why the bookmarks in my browser kept getting deleted. If Floccus would have just notified me about the error (e.g. you could just change the Extension Icon to some red warning sign color) then I would have immediately realized the issue was with Floccus and would have discovered the issue more quickly.
Expected Behavior
Floccus should give a clear notification if its not able to
git pushyour local browser bookmarks state to the remote repoTo Reproduce
Debug log provided
@github-actions[bot] commented on GitHub (Jul 9, 2025):
Hello 👋
Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved. Let me give you a short introduction on what to expect from this issue tracker to avoid misunderstandings.
I'm Marcel. I created floccus a few years ago, and have been maintaining it since. I currently work for Nextcloud
which leaves me with less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient. It helps when you stick around to answer follow up questions I may have,
as very few bugs can be fixed directly from the first bug report, without any interaction. If information is missing in your bug report
and the issue cannot be solved without it, I will have to close the issue after a while.
Note also that GitHub in general is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
If you cannot lend a helping hand, to continue the development and maintenance of this project in a sustainable way,
I ask that you donate to the project when opening an issue (or at least once your issue is solved), if you're not a donor already.
You can find donation options at https://floccus.org/donate/. Thank you!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.
Thank you for reading through this primer. I look forward to working with you on this issue!
Cheers 💙
@marcelklehr commented on GitHub (Jul 11, 2025):
Hey @stevekm
Damn, I'm sorry for the trouble. I will look into how to detect this. Failures to push should already be caught, but maybe this pre-push hook result is not handled well by the git implementation that floccus uses...
@stevekm commented on GitHub (Jul 15, 2025):
no worries, this change to BitBucket policies has been very disruptive on multiple fronts. I am just glad to have this behavior documented publicly. Since I use BitBucket primarily for "background" application usages such as this, not interactively, it took me a long time to realize there was a change and then to connect the dots to the issues I was suddenly having with Floccus. Once I "fixed" this issue with the BitBucket account (by just making a new account) the issues with Floccus went away and its behaving normally again. Mostly just need a notification from the extension to alert about such issues in the future.