mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 14:16:12 +03:00
[GH-ISSUE #1894] Javascript Bookmarklet Duplication #1268
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#1268
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @easlice on GitHub (Mar 27, 2025).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1894
Which version of floccus are you using?
5.4.5
How many bookmarks do you have, roughly?
222
Are you using other means to sync bookmarks in parallel to floccus?
No
Sync method
Nextcloud Bookmarks
Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.
Librewolf
Which version of Nextcloud Bookmarks are you using? (if relevant)
v15.1.0
Which version of Nextcloud? (if relevant)
v30.0.6
What kind of WebDAV server are you using? (if relevant)
No response
Describe the Bug
Every time floccus syncs it creates another copy of my bookmarklet.
If I look at the actual bookmarks in Nextcloud, the multiple copies do not show up, only the one copy.
It almost looks like floccus doesn't realize that the bookmarklet already exists and is recreating it.
It also causes the bookmarks to reorder and the bookmarklet to move to the front.
It doesn't seem to matter if it is the auto-sync or a manual sync.
Expected Behavior
For there to only be as many copies of the bookmarklet as are on the server (and to not create duplicates).
To Reproduce
Have a javascript bookmarklet in your bookmarks.
Hit sync and wait. Another copy of the bookmarklet will appear and move through the list of bookmarks.
Hit sync again. Another copy of the bookmarklet will appear and move through the list of bookmarks.
floccus-5.4.5-2025-03-27-redacted.log
Debug log provided
@github-actions[bot] commented on GitHub (Mar 27, 2025):
Hello 👋
Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus a few years ago, maintaining it ever since. I currently work for Nextcloud
which leaves me with less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
To continue the development and maintenance of this project in a sustainable way I ask that you donate to the project when opening an issue
(or at least once your issue is solved), if you're not a donor already.
You can find donation options at https://floccus.org/donate/. Thank you!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.
I look forward to working with you on this issue
Cheers 💙
@marcelklehr commented on GitHub (Mar 28, 2025):
Hey @easlice
Thanks for the feedback! It looks like floccus assumes that your server does not support
javascript:bookmarks and therefore ignores all localjavascript:bookmarks. Does the issue persist when you restart the browser?@marcelklehr commented on GitHub (Mar 29, 2025):
I cannot reproduce this at the moment
@easlice commented on GitHub (Mar 31, 2025):
I restarted the browser like you said and the issue no longer occurs. I let it sit for a couple of days just to see what happened, and it still isn't happening. I wonder what changed? The behavior was very consistent before restarting.
@marcelklehr commented on GitHub (Mar 31, 2025):
You may have updated the bookmarks app on your nextcloud which recently added support for javascript bookmarks while the older version did not support them. When you restarted your browser, floccus became aware that your nextcloud bookmarks instance now supports javascript bookmarks and is no longer ignoring your local javascript bookmarklets. tl;dr it likely was a caching issue
@easlice commented on GitHub (Mar 31, 2025):
I see. Well, thanks for looking at it! I'll go ahead and close this issue, and if it arises again I'll open it up again.
By the way, thanks for working on this, floccus has worked very nicely for me other than this one oddity.
@marcelklehr commented on GitHub (Mar 31, 2025):
Thanks for the kind words and your donation :)