mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-26 06:35:59 +03:00
[GH-ISSUE #1841] Separators on Bookmarks-bar in Chrome-based browsers are horizontal instead of vertical #1236
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#1236
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @macrogreg on GitHub (Jan 24, 2025).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1841
Which version of floccus are you using?
5.4.3 on Firefox / 5.4.2 on Edge
How many bookmarks do you have, roughly?
300
Are you using other means to sync bookmarks in parallel to floccus?
Yes, I sync Firefox and Edge to their respective built-in primary backends
Sync method
Google Drive
Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.
Firefox 134.0.1 / Edge 132.0.2957.115
Which version of Nextcloud Bookmarks are you using? (if relevant)
n/a
Which version of Nextcloud? (if relevant)
n/a
What kind of WebDAV server are you using? (if relevant)
n/a
Describe the Bug
Hi team!
Thank you for providing this tool. I appreciate your work!
The Chrome-based browsers are lacking bookmark separators, and Floccus does a reasonable job emulating them by inserting a favicon-based "hack".
This "hack" works fine in most cases, however, it fails in the Favorites-bar.
There, the "icon" should be vertical rather than horizontal, and there should be no description text.
Currently, the bar looks like this:
Expected Behavior
The separators should be vertical, and there should be no other text on those elements.
Here is how the same synchronization looks for me in Firefox:
Contribution:
To contribute to a swift resolution, I created a PR for the separator-site repo: https://github.com/floccusaddon/separator-site/pull/2
Suggestion:
It seems that the fix should be simple:
title: ''and
url: 'https://separator.floccus.org/vertical.html?id=${rng.int(0,1000000)}'when
parentId === 'toolbar_____'.parentId !== 'toolbar_____', usetitle: '⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯'. This creates a more coherent horizontal separator line. (These are eleven Horizontal Line Extension chars (U+23AF).)If this strategy seems reasonable, I'd be happy to create a PR after the separator site is merged. Please let me know if that is helpful.
Request:
Please, validate the fix not only for Chrome, but also for Edge, and possible for other common Chrome-based browsers.
To Reproduce
Debug log provided
-- N/A
Extra request
The text on the vertical separators on places other than the Bookmarks Bar could be a little longer.
Currently it is: "
-----".Suggestion: "
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯" (these are eleven Horizontal Line Extension chars (U+23AF)).@github-actions[bot] commented on GitHub (Jan 24, 2025):
Hello 👋
Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus a few years ago, maintaining it ever since. I currently work for Nextcloud
which leaves me with less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
To continue the development and maintenance of this project in a sustainable way I ask that you donate to the project when opening an issue
(or at least once your issue is solved), if you're not a donor already.
You can find donation options at https://floccus.org/donate/. Thank you!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.
I look forward to working with you on this issue
Cheers 💙
@macrogreg commented on GitHub (Jan 24, 2025):
Cross-linking relevant items:
@marcelklehr commented on GitHub (Jan 26, 2025):
mmh, I'm not sure if the added complexity is worth it, to be honest.
@marcelklehr commented on GitHub (Jan 26, 2025):
On the other hand, iff you use separators the current behavior can be quite annoying. Let's go for it! :)
@marcelklehr commented on GitHub (Jan 26, 2025):
I'd be happy to merge a PR from you for this .) Note that
'toolbar_____'is only applicable in firefox, in Chrome-based browsers there are numeric IDs for the main folders, and in Brave (or Vivaldi, can't remember) there is no bookmarks toolbar folder at all, but I think they still have a toolbar. We'll need to test how it behaves there@macrogreg commented on GitHub (Jan 27, 2025):
Thanks, @marcelklehr.
I created https://github.com/floccusaddon/floccus/pull/1846.
I am not sure how to run the tests, so it is a draft for now. Looking forward to your feedback.
@macrogreg commented on GitHub (Jan 31, 2025):
#1846 is ready, tested and waiting for feedback and approval.
@marcelklehr commented on GitHub (Feb 1, 2025):
🎉 ... aaaaand merged. Congrats and thank you!
@macrogreg commented on GitHub (Feb 3, 2025):
Thank you, @marcelklehr !
I appreciate Floccus and it was fun working together.
What is the approx. timeline for releasing these changes? I am excited start using it! :)
@marcelklehr commented on GitHub (Feb 4, 2025):
I'll try to do a release tomorrow :)
@github-actions[bot] commented on GitHub (Feb 5, 2026):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.