mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 06:06:05 +03:00
[GH-ISSUE #1799] E035: Failed to create the following bookmark on the server: [object Object] #1203
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#1203
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tom-ch1 on GitHub (Dec 14, 2024).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1799
Which version of floccus are you using?
5.4.0
How many bookmarks do you have, roughly?
800
Are you using other means to sync bookmarks in parallel to floccus?
No
Sync method
Nextcloud Bookmarks
Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.
Chromium Version 131.0.6778.139 (Official Build) built on Debian GNU/Linux 12 (bookworm) (64-bit)
Which version of Nextcloud Bookmarks are you using? (if relevant)
v14.2.4
Which version of Nextcloud? (if relevant)
Nextcloud Hub 7 (28.0.9)
What kind of WebDAV server are you using? (if relevant)
No response
Describe the Bug
I have 3 sync tasks: a) for the bookmark bar, b) for other bookmarks, and c) for Tabs.
a) and b) are working fine but c) stops with an error:
Syncing failed with E035: Failed to create the following bookmark on the server: [object Object]
Expected Behavior
Syncing Tabs should succeed
To Reproduce
It is unclear what causes the issue. From previous experiences with floccus - nextcloud, it was always due to long page names or special characters. As floccus does not tell me which tab fails (is that a bug in the logger?) and only outputs [object Object] it is impossible for me to check this out.
Debug log provided
@github-actions[bot] commented on GitHub (Dec 14, 2024):
Hello 👋
Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus a few years ago, maintaining it ever since. I currently work for Nextcloud
which leaves me with less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
To continue the development and maintenance of this project in a sustainable way it is expected that you donate to the project when opening a ticket,
if you're not a donor already. You can find donation options at https://floccus.org/donate/. Thank you!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.
I look forward to working with you on this issue
Cheers 💙
@tom-ch1 commented on GitHub (Dec 14, 2024):
Donation done :-)
@marcelklehr commented on GitHub (Dec 15, 2024):
Hello 👋
Can you check the logs for the full error message?Ah, that won't work. Let me check how we can get the offending bookmark.@marcelklehr commented on GitHub (Dec 15, 2024):
Can you still send the last logs (possibly in redacted form)? I might be able to figure it out from there.
@tom-ch1 commented on GitHub (Dec 15, 2024):
Hi Marcel,
github.com/floccusaddon/floccus@9b2f6b9a80--> cool thanks! How can I install a version with this commit? I could probably then find the offending bookmarkI found the redacted log and redacted it even more with:
sed 's/\(url=https\?%3A%2F%2F\).*$/\1-redacted/' floccus-5.4.0-2024-12-15-redacted.log > floccus-5.4.0-2024-12-15-really-redacted.logbecause of some leaking bookmark urls.You'll find the log on my google drive: https://drive.google.com/file/d/1sb0lWWzuahcx26T4lNAnfSYpZwFMcXIZ/view?usp=sharing
@marcelklehr commented on GitHub (Dec 16, 2024):
If you scroll down in the log, there's 6 bookmarks beig CREATEd on the server, I think. Three of those are failing. That should be quite easy to narrow down.
@tom-ch1 commented on GitHub (Dec 20, 2024):
I don't understand: There are hundreds of bookmarks created not just 6. What do I search for in the log to find the 6 you are talking about?
How can I install a version with this commit?
github.com/floccusaddon/floccus@9b2f6b9a80I could probably then find the offending bookmark
@marcelklehr commented on GitHub (Dec 20, 2024):
Sorry, you're right, it's not just 6, but right before the error and after
Server: executing CREATEsI count 13 log entries with(nextcloud-folders)CREATE, which signals the execution of a create action. That should hopefully be easier to pin down than all bookarks.Yes, that would be easier. You or someone else needs to build it.* I expect to work on floccus during the holidays and will probably publish this patch along with the next version soon, but I cannot promise anything.
* Build steps can be found here: https://github.com/floccusaddon/floccus?tab=readme-ov-file#development
@tom-ch1 commented on GitHub (Dec 22, 2024):
Thanks Marcel, I built floccus and installed the extension. I found the bookmarks which were causing the errors. They have long names, but I can't definitely determine the problem. I then closed all the failed tabs an re-ran a Sync. Now there are other errors (maybe related?):
The failed bookmarks are very often Github projects. The log not only mentions the page title, but also the entire "About" section. Maybe this generates an overflow?
@marcelklehr commented on GitHub (Dec 23, 2024):
Can you send logs again of this new error?
@marcelklehr commented on GitHub (Dec 27, 2024):
I've published a new alpha version for you to try, which should fix the "Failed to create bookmark" error: https://github.com/floccusaddon/floccus/releases/tag/v5.4.2-alpha.1
@tom-ch1 commented on GitHub (Dec 29, 2024):
@marcelklehr thanks for the alpha release. It provides better localisation of the erroneous Tab. I'll try to provide a chronology of relevant log entries for the following Tab which triggers this issue:
Logfile extract:
For what it's worth: There seem to be higher risks to run into this issue on github project pages. May it be related to the lengthy description? It would be interesting to see if this failing url also fails for other nextcloud bookmark installations.
@tom-ch1 commented on GitHub (Dec 29, 2024):
@marcelklehr : I highly suspect that the underlying cause for this issue is a database field length restriction in the nextcloud app. Try the following:
So I'd like to suggest 2 new features:
For bookmarks, I can shorten the title as a workaround. For Tab sync, this unfortunately won't work
@marcelklehr commented on GitHub (Dec 29, 2024):
Mh. It could be that you still have a very old database schema in Nextcloud Bookmarks, apparently I need to fix this, you're not the first with this issue. It can happen when you had installed bookmarks on your nextcloud prior to database migrations being introduced. What is the field length of oc_bookmarks.title for you?
@tom-ch1 commented on GitHub (Dec 29, 2024):
it's
character varying(255), should probably betextI suppose.Is there a documentation of the database schema in nc bookmarks? I could check if there are other discrepancies...
@marcelklehr commented on GitHub (Dec 29, 2024):
Yes, it should have length 4092, same for URL and description.
@tom-ch1 commented on GitHub (Dec 29, 2024):
isn't "text" better than "character varying(4092)"? currently, my url and description are text and user_id is "character varying(64)"
edit: I use postgres, see https://www.postgresql.org/docs/current/datatype-character.html
@marcelklehr commented on GitHub (Dec 29, 2024):
Bookmarks is not directly setting the postgres column type, but usign an abstraction layer called doctrine, which switches to text on demand if the declared length of the string column type exceeds the max possible length. So, you can switch the title column to TEXT in your case, I suppose.
@tom-ch1 commented on GitHub (Dec 29, 2024):
I went through all "lib/Migration/Version*.php" files and compared it to my db schema (that was a pain...)
Turns out that only bookmarks.title was wrong. I have a faint memory that I manually changed that column due to an earlier bug. This might have caused the migration to fail somehow :-(
Anyway: Thanks, @marcelklehr , I could resolve this issue by altering the db column. And as doctrine convert 4096 to infinity, I will not ever run into this issue again (which might not be true for other users who will hit it when somebody adds a fancy long description to a github project...)
@marcelklehr commented on GitHub (Dec 29, 2024):
The app does truncate to 4092 chars, luckily :)
@marcelklehr commented on GitHub (Dec 29, 2024):
I'm glad we could solve this! Thank you for your collaboration. Have a nice turn of years!
@github-actions[bot] commented on GitHub (Dec 30, 2025):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.