mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 22:26:06 +03:00
[GH-ISSUE #1788] Cannot read properties of null (reading 'indexOf') | Last synchronized: 0 seconds ago #1193
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#1193
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ghost on GitHub (Dec 3, 2024).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1788
Which version of floccus are you using?
5.4.0
How many bookmarks do you have, roughly?
52
Are you using other means to sync bookmarks in parallel to floccus?
No
Sync method
Linkwarden
Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.
Version 1.73.91 Chromium: 131.0.6778.85 (Official Build) (x86_64)
Which version of Nextcloud Bookmarks are you using? (if relevant)
N/A
Which version of Nextcloud? (if relevant)
N/A
What kind of WebDAV server are you using? (if relevant)
N/A
Describe the Bug
I have properly set up an instance of Linkwarden on my server using Docker. I can access and utilize it with zero issues so far. I also use the Linkwarden extension in my browser with zero issues.
The Floccus extension, however, is a different story. I have set up the extension properly, and am pointing it to the "Floccus" collection in my Linkwarden instance. This Floccus collection has sub-collections containing all of my bookmarks. The top collection (the Floccus collection) has a bookmark in it. The sub-collections also have bookmarks in them.
I am trying to synchronize the Floccus collection into the root of my "Other Bookmarks" folder in my browser, which is currently empty.
When I try to run the synchronization, I get this error:
"Cannot read properties of null (reading 'indexOf') | Last synchronized: 0 seconds ago"
I have also tried making a sub-folder in the "Other Bookmarks" folder called "Floccus", and pointing the synchronization job to that, but I get the same error.
I'm completely stumped and could really use some assistance.
Below is my debug log:
floccus-5.4.0-2024-12-03-full.log
2024-12-03T20:12:36.441Z Starting sync process for account Full sync
2024-12-03T20:12:36.443Z Using "merge default" strategy (no cache available)
2024-12-03T20:12:36.443Z Retrieving local tree
2024-12-03T20:12:36.444Z Overriding title of built-in node 2 Other Bookmarks => Other Bookmarks
2024-12-03T20:12:36.444Z Filtering out unaccepted local bookmarks
2024-12-03T20:12:36.444Z Retrieving server tree
2024-12-03T20:12:36.444Z QUEUING GET https://linkwarden.myserver.com//api/v1/links?cursor=
2024-12-03T20:12:36.444Z FETCHING GET https://linkwarden.myserver.com//api/v1/links?cursor=
2024-12-03T20:12:36.869Z Receiving response for GET https://linkwarden.myserver.com//api/v1/links?cursor=
2024-12-03T20:12:36.871Z QUEUING GET https://linkwarden.myserver.com//api/v1/links?cursor=4
2024-12-03T20:12:36.871Z FETCHING GET https://linkwarden.myserver.com//api/v1/links?cursor=4
2024-12-03T20:12:37.414Z Receiving response for GET https://linkwarden.myserver.com//api/v1/links?cursor=4
2024-12-03T20:12:37.414Z QUEUING GET https://linkwarden.myserver.com//api/v1/links?cursor=1
2024-12-03T20:12:37.414Z FETCHING GET https://linkwarden.myserver.com//api/v1/links?cursor=1
2024-12-03T20:12:37.937Z Receiving response for GET https://linkwarden.myserver.com//api/v1/links?cursor=1
2024-12-03T20:12:37.937Z QUEUING GET https://linkwarden.myserver.com//api/v1/collections
2024-12-03T20:12:37.937Z FETCHING GET https://linkwarden.myserver.com//api/v1/collections
2024-12-03T20:12:38.396Z Receiving response for GET https://linkwarden.myserver.com//api/v1/collections
2024-12-03T20:12:38.397Z Syncing failed with Cannot read properties of null (reading 'indexOf')
Expected Behavior
I expect the synchronization job to work without throwing an error.
To Reproduce
Debug log provided
@github-actions[bot] commented on GitHub (Dec 3, 2024):
Hello 👋
Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus a few years ago, maintaining it ever since. I currently work for Nextcloud
which leaves me with less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
To continue the development and maintenance of this project in a sustainable way it is expected that you donate to the project when opening a ticket,
if you're not a donor already. You can find donation options at https://floccus.org/donate/. Thank you!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.
I look forward to working with you on this issue
Cheers 💙
@ghost commented on GitHub (Dec 3, 2024):
Another thing to note -- I have tried this same operation with a "/" at the end of my server address, and without one. The error is identical when not using a trailing "/" at the end of the address. Here is the corresponding debug log:
floccus-5.4.0-2024-12-03-full alternate.log
2024-12-03T20:33:57.737Z Starting sync process for account Full sync
2024-12-03T20:33:57.739Z Using "merge default" strategy (no cache available)
2024-12-03T20:33:57.740Z Retrieving local tree
2024-12-03T20:33:57.741Z Overriding title of built-in node 2 Other Bookmarks => Other Bookmarks
2024-12-03T20:33:57.741Z Filtering out unaccepted local bookmarks
2024-12-03T20:33:57.741Z Retrieving server tree
2024-12-03T20:33:57.741Z QUEUING GET https://linkwarden.myserver.com/api/v1/links?cursor=
2024-12-03T20:33:57.741Z FETCHING GET https://linkwarden.myserver.com/api/v1/links?cursor=
2024-12-03T20:33:58.055Z Receiving response for GET https://linkwarden.myserver.com/api/v1/links?cursor=
2024-12-03T20:33:58.058Z QUEUING GET https://linkwarden.myserver.com/api/v1/links?cursor=5
2024-12-03T20:33:58.059Z FETCHING GET https://linkwarden.myserver.com/api/v1/links?cursor=5
2024-12-03T20:33:58.320Z Receiving response for GET https://linkwarden.myserver.com/api/v1/links?cursor=5
2024-12-03T20:33:58.320Z QUEUING GET https://linkwarden.myserver.com/api/v1/links?cursor=1
2024-12-03T20:33:58.320Z FETCHING GET https://linkwarden.myserver.com/api/v1/links?cursor=1
2024-12-03T20:33:58.511Z Receiving response for GET https://linkwarden.myserver.com/api/v1/links?cursor=1
2024-12-03T20:33:58.511Z QUEUING GET https://linkwarden.myserver.com/api/v1/collections
2024-12-03T20:33:58.511Z FETCHING GET https://linkwarden.myserver.com/api/v1/collections
2024-12-03T20:33:58.845Z Receiving response for GET https://linkwarden.myserver.com/api/v1/collections
2024-12-03T20:33:58.846Z Syncing failed with Cannot read properties of null (reading 'indexOf')
@marcelklehr commented on GitHub (Dec 4, 2024):
Hi @0penSourcerer
I'm sorry for the trouble. Which version of Linkwarden do you have running? Is it possible that you have a link in there that has no or an empty URL?
@ghost commented on GitHub (Dec 4, 2024):
I am running the latest version, freshly installed. Linkwarden v2.8.4
@ghost commented on GitHub (Dec 4, 2024):
Your question "Is it possible that you have a link in there that has no or an empty URL?" made me think about the content of all my bookmarks, and while I was positive that all of my collections contain at least 1 URL bookmark, I had a single collection into which I had uploaded a PDF file.
Upon removal of this singular PDF file, everything worked flawlessly!
Other users take note -- apparently having a PDF file directly uploaded into any collection will break proper synchronization.
EDIT: I have more helpful information to add to this bug report.
I discovered that if I directly upload a PDF from my hard disk into Linkwarden, it will trigger the behavior I described in my bug report. I also discovered that tags cannot be edited in the uploaded PDF after the initial option to tag is offered. Once it's uploaded, trying to edit and add tags will fail.
However, if I use the direct online URL to the exact same PDF file rather than upload it from my hard drive, everything works as normal. Tags can be edited after the PDF-based URL is added, and everything works as expected.
@marcelklehr commented on GitHub (Dec 4, 2024):
Thank you for the details! This will be fixed in the next release.
@ghost commented on GitHub (Dec 5, 2024):
I'm happy to help! Thank you for all of your efforts.
@github-actions[bot] commented on GitHub (Dec 6, 2025):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.