[GH-ISSUE #1731] Javascript bookmarklet multiplication #1153

Closed
opened 2026-02-25 22:39:10 +03:00 by kerem · 9 comments
Owner

Originally created by @danpeig on GitHub (Sep 30, 2024).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1731

Which version of floccus are you using?

5.3.0

How many bookmarks do you have, roughly?

200

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

Nextcloud Bookmarks

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Chrome 129 and Firefox 130

Which version of Nextcloud Bookmarks are you using? (if relevant)

14.2.6

Which version of Nextcloud? (if relevant)

29.0.7

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

Duplication of javascript bookmarklets after reopening the browser.

Every time the browser is reopened and a "pull down" operation is executed, a new bookmarklet will be added. If the "pull down" operation is executed more than once during the same browsing session, there is no duplication.

Bookmarklet

javascript:(function(){var a=window,b=document,c=encodeURIComponent,e=c(document.title),d=a.open('https://nextcloud.myserver.com/apps/bookmarks/bookmarklet?url='+c(b.location)+'&title='+e,'bkmk_popup','left='+((a.screenX||a.screenLeft)+10)+',top='+((a.screenY||a.screenTop)+10)+',height=650px,width=550px,resizable=1,alwaysRaised=1');a.setTimeout(function(){d.focus()},300);})();

Expected Behavior

The javascript bookmarklet shoud not be multiplied.

To Reproduce

  1. From Nextcloud bookmarks, create a bookmarklet (for adding new bookmarks) and save it in the browser bookmark list.
  2. Push up the bookmarklet so it appears in Nextcloud online bookmarks list
  3. Pull down using Floccus extension in another browser (Firefox or Chrome). The bookmarklet should appear in the new browser.
  4. Reopen the browser and pull down again. Now there are multiple bookmarklets. If you pull down within the same session, no extra bookmarklets will appear. The duplication only occurs when a new browser session is initiated.

NOTE: Sync is not enabled. "Push up" and "pull down" operations are executed manually.

Debug log provided

  • I have provided a debug log file
Originally created by @danpeig on GitHub (Sep 30, 2024). Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1731 ### Which version of floccus are you using? 5.3.0 ### How many bookmarks do you have, roughly? 200 ### Are you using other means to sync bookmarks in parallel to floccus? No ### Sync method Nextcloud Bookmarks ### Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please. Chrome 129 and Firefox 130 ### Which version of Nextcloud Bookmarks are you using? (if relevant) 14.2.6 ### Which version of Nextcloud? (if relevant) 29.0.7 ### What kind of WebDAV server are you using? (if relevant) _No response_ ### Describe the Bug Duplication of javascript bookmarklets after reopening the browser. Every time the browser is reopened and a "pull down" operation is executed, a new bookmarklet will be added. If the "pull down" operation is executed more than once during the same browsing session, there is no duplication. **Bookmarklet** ```javascript javascript:(function(){var a=window,b=document,c=encodeURIComponent,e=c(document.title),d=a.open('https://nextcloud.myserver.com/apps/bookmarks/bookmarklet?url='+c(b.location)+'&title='+e,'bkmk_popup','left='+((a.screenX||a.screenLeft)+10)+',top='+((a.screenY||a.screenTop)+10)+',height=650px,width=550px,resizable=1,alwaysRaised=1');a.setTimeout(function(){d.focus()},300);})(); ``` ### Expected Behavior The javascript bookmarklet shoud not be multiplied. ### To Reproduce 1. From Nextcloud bookmarks, create a bookmarklet (for adding new bookmarks) and save it in the browser bookmark list. 2. **Push up** the bookmarklet so it appears in Nextcloud online bookmarks list 3. **Pull down** using Floccus extension in another browser (Firefox or Chrome). The bookmarklet should appear in the new browser. 4. Reopen the browser and **pull down** again. Now there are multiple bookmarklets. If you **pull down** within the same session, no extra bookmarklets will appear. The duplication only occurs when a new browser session is initiated. **NOTE:** Sync is not enabled. "Push up" and "pull down" operations are executed manually. ### Debug log provided - [ ] I have provided a debug log file
kerem 2026-02-25 22:39:10 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@github-actions[bot] commented on GitHub (Sep 30, 2024):

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus a few years ago, maintaining it ever since. I currently work for Nextcloud
which leaves me with less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
To continue the development and maintenance of this project in a sustainable way it is expected that you donate to the project when opening a ticket,
if you're not a donor already. You can find donation options at https://floccus.org/donate/. Thank you!

One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

<!-- gh-comment-id:2383484664 --> @github-actions[bot] commented on GitHub (Sep 30, 2024): Hello :wave: Thank you for taking the time to open this issue with floccus. I know it's frustrating when software causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at and if possible solved. I'm Marcel and I created floccus a few years ago, maintaining it ever since. I currently work for Nextcloud which leaves me with less time for side projects like this one than I used to have. I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it. Until then, please be patient. Note also that GitHub is a place where people meet to make software better *together*. Nobody here is under any obligation to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can collaborate to make this software better. For everyone. Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and try to fix the odd bug yourself. Everyone will be thankful for extra helping hands! To continue the development and maintenance of this project in a sustainable way it is expected that you donate to the project when opening a ticket, if you're not a donor already. You can find donation options at <https://floccus.org/donate/>. Thank you! One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum, to twitter or somewhere else. But this is a technical issue tracker, so please make sure to focus on the tech and keep your opinions to yourself. I look forward to working with you on this issue Cheers :blue_heart:
Author
Owner

@marcelklehr commented on GitHub (Oct 1, 2024):

Hi @danpeig
I was able to reproduce this! 🎉 Thank you for your excellent steps to reproduce!

<!-- gh-comment-id:2385508102 --> @marcelklehr commented on GitHub (Oct 1, 2024): Hi @danpeig I was able to reproduce this! :tada: Thank you for your excellent steps to reproduce!
Author
Owner

@danpeig commented on GitHub (Oct 1, 2024):

Great! If you need more information, logs or tests, please let me know.

<!-- gh-comment-id:2386109935 --> @danpeig commented on GitHub (Oct 1, 2024): Great! If you need more information, logs or tests, please let me know.
Author
Owner

@canufarm commented on GitHub (Oct 3, 2024):

Hi,

I have a very similiar issue: When I open Firefox, start a manual or auto sync of floccus, then all my bookmarklets in the nextcloud bookmark app are removed to the trash of the bookmark app in Nextcloud. If I then restore them from the trash one by one and do some other syncs with floccus, nothing will be deleted any more in this session. But after closing and reopening Firefox the same issue appears each an every time. Only bookmarklets are deleted/put into trash in the nextcloud app by a floccus sync, not any other bookmarks.

For now I stopped the sync or only make a pushup from Firefox to Nextcloud to not miss any bookmarklets.

Any help appreciated! Thanks.

PS: I only use ONE Firefox browser on one machine.

PPS: In the mobile version of floccus there is also a (multiple) dubbling of my bookmarklets as mentioned by @danpeig after a new sync, see image.
photo_2024-10-03_14-44-44

<!-- gh-comment-id:2391277690 --> @canufarm commented on GitHub (Oct 3, 2024): Hi, I have a very similiar issue: When I open Firefox, start a manual or auto sync of floccus, then all my bookmarklets in the nextcloud bookmark app are removed to the trash of the bookmark app in Nextcloud. If I then restore them from the trash one by one and do some other syncs with floccus, nothing will be deleted any more in this session. But after closing and reopening Firefox the same issue appears each an every time. Only bookmarklets are deleted/put into trash in the nextcloud app by a floccus sync, not any other bookmarks. For now I stopped the sync or only make a pushup from Firefox to Nextcloud to not miss any bookmarklets. Any help appreciated! Thanks. PS: I only use ONE Firefox browser on one machine. PPS: In the mobile version of floccus there is also a (multiple) dubbling of my bookmarklets as mentioned by @danpeig after a new sync, see image. ![photo_2024-10-03_14-44-44](https://github.com/user-attachments/assets/b6199152-47a3-4e83-b79c-c3e264281370)
Author
Owner

@marcelklehr commented on GitHub (Oct 9, 2024):

Hi everyone,

I've just released v5.3.1 (currently in Open Testing on Google play), which should fix this. Can you please confirm?

<!-- gh-comment-id:2401767982 --> @marcelklehr commented on GitHub (Oct 9, 2024): Hi everyone, I've just released v5.3.1 (currently in Open Testing on Google play), which should fix this. Can you please confirm?
Author
Owner

@canufarm commented on GitHub (Oct 9, 2024):

I've just released v5.3.1 (currently in Open Testing on Google play), which should fix this. Can you please confirm?

Thank you, in Firefox the issue is solved. No more deleted bookmarklets after sync!

<!-- gh-comment-id:2401793152 --> @canufarm commented on GitHub (Oct 9, 2024): > I've just released v5.3.1 (currently in Open Testing on Google play), which should fix this. Can you please confirm? Thank you, in Firefox the issue is solved. No more deleted bookmarklets after sync!
Author
Owner

@danpeig commented on GitHub (Oct 9, 2024):

Confirming the fix is working as expected:

  • Firefox Windows: OK
  • Firefox Linux: OK
  • Chrome Windows: OK
  • Edge Windows: OK
<!-- gh-comment-id:2402225864 --> @danpeig commented on GitHub (Oct 9, 2024): Confirming the fix is working as expected: - Firefox Windows: OK - Firefox Linux: OK - Chrome Windows: OK - Edge Windows: OK
Author
Owner

@Nebucatnetzer commented on GitHub (May 17, 2025):

I'm seeing this problem again in my setup with Firefox.

Image

<!-- gh-comment-id:2888428561 --> @Nebucatnetzer commented on GitHub (May 17, 2025): I'm seeing this problem again in my setup with Firefox. ![Image](https://github.com/user-attachments/assets/8a8d9efd-0e2a-4268-8730-359c99197594)
Author
Owner

@marcelklehr commented on GitHub (May 17, 2025):

@Nebucatnetzer Could you please open a new issue?

<!-- gh-comment-id:2888478945 --> @marcelklehr commented on GitHub (May 17, 2025): @Nebucatnetzer Could you please open a new issue?
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/floccus#1153
No description provided.