mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 14:16:12 +03:00
[GH-ISSUE #1599] [Git Adapter] Possible rate-limites when using github #1055
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#1055
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bigdiff on GitHub (May 9, 2024).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1599
Which version of floccus are you using?
5.1.0
Sync method
Git
Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.
Brave Version 1.65.126 Chromium: 124.0.6367.118 (Official Build) (64-bit)
Which version of Nextcloud Bookmarks are you using? (if relevant)
N/A
Which version of Nextcloud? (if relevant)
N/A
What kind of WebDAV server are you using? (if relevant)
N/A
Describe the Bug
Github seems to heavily rate-limit the git adapater, I've setup two profile one for bookmarks and one for open tabs, and it seems there is a 15 minute limit between 2~3 requests.
Expected Behavior
I'm not sure if this is a known thing, IMO it is worth mentioning when adding a git adapter profile.
To Reproduce
Setup at least two profile, make some changes in both profile and notice the "Scheduled" appearing on both profiles for 15 minutes and it retries every so often.
Debug log provided
@github-actions[bot] commented on GitHub (May 9, 2024):
Hello 👋
Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus and have been maintaining it ever since.
I currently work for Nextcloud which leaves me with less time for side projects like this one
than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.
I look forward to working with you on this issue
Cheers 💙
@marcelklehr commented on GitHub (May 9, 2024):
Hhm, yeah, when the resource is locked, floccus retries every minute :S That doesn't go down well with rate limiting I imagine :/
@bigdiff commented on GitHub (May 9, 2024):
Sadly Floccus just gave up and removed all my folders (bookmarks and open tabs from github)
I now have 6 tags for floccus-locks and the repo is empty with just a readme.
the content of the readme is
all commit history is gone also 🙁 the only commit left is for adding the markdown
@marcelklehr commented on GitHub (May 9, 2024):
Wut?!
@marcelklehr commented on GitHub (May 9, 2024):
Could you send the log of that sync?
@bigdiff commented on GitHub (May 9, 2024):
the thing is they're multiple so I don't know which one triggered this lol
@bigdiff commented on GitHub (May 9, 2024):
I think I know why now, it initialized a new git repo and it did not detect that there is already a git repo
@marcelklehr commented on GitHub (May 9, 2024):
Yeah, it should only ever do that if the branch cannot be found... I'm gonna take that part out I guess. Can't have floccus bulldoze the entire repo.
@bigdiff commented on GitHub (May 9, 2024):
It was
mainby default in github and the default ismainin floccus so I'm not sure what happened there@bigdiff commented on GitHub (May 9, 2024):
thank you for the prompt replies and the hot fix 🔥
@bigdiff commented on GitHub (May 9, 2024):
Could it be due to the rate-limiting that it failed and "bulldozed" 😀 the repo?
we can keep the try catch in https://github.com/floccusaddon/floccus/pull/1602 but instead of initializing a new repo we can put the error into the logger, what do you think?
@marcelklehr commented on GitHub (May 9, 2024):
The try-catch is only used to set up a new repo, so if we don't want that, the error will be caught higher up and displayed, no need to log it manually.
@github-actions[bot] commented on GitHub (May 10, 2025):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.