[PR #751] [CLOSED] Split flag sizes into separate files #992

Closed
opened 2026-03-03 14:41:39 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/lipis/flag-icons/pull/751
Author: @yurikoval
Created: 9/15/2020
Status: Closed

Base: masterHead: split-flag-size-build


📝 Commits (6)

  • 2556f08 Add 1x1 and 4x3 source files
  • d78bc2e Use list function to generate flag classes
  • 71f52ff Extract squared definition into separate mixin
  • 633d1cd Create flag clsses using iterator
  • 8e12c83 Generate 1x1 and 4x3 sizes
  • a3e99ac Build assets

📊 Changes

14 files changed (+2424 additions, -1038 deletions)

View changed files

📝 Gruntfile.coffee (+12 -0)
css/flag-icon-1x1.css (+794 -0)
css/flag-icon-1x1.min.css (+1 -0)
css/flag-icon-4x3.css (+794 -0)
css/flag-icon-4x3.min.css (+1 -0)
📝 css/flag-icon.css (+773 -773)
📝 css/flag-icon.min.css (+1 -1)
less/flag-icon-1x1.less (+5 -0)
less/flag-icon-4x3.less (+5 -0)
📝 less/flag-icon-base.less (+16 -4)
less/flag-icon-list.less (+0 -249)
less/flag-icon-more.less (+0 -9)
📝 less/flag-icon.less (+6 -2)
📝 less/variables.less (+16 -0)

📄 Description

Different flag sizes are used in different contexts; there is rarely a need to include both at the same time. so optimising for load / build time by splitting flag sizes into separate files.

There are no changes to existing icon class definitions.

In this PR:

  • Move countries into a list variable.
  • Generate country css using countries variable.
  • Introduce flag-icon-1x1 and flag-icon-4x3 to be included separately in depended projects.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/lipis/flag-icons/pull/751 **Author:** [@yurikoval](https://github.com/yurikoval) **Created:** 9/15/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `split-flag-size-build` --- ### 📝 Commits (6) - [`2556f08`](https://github.com/lipis/flag-icons/commit/2556f0869b696746192f2c89c2341f71562647d7) Add 1x1 and 4x3 source files - [`d78bc2e`](https://github.com/lipis/flag-icons/commit/d78bc2ea3678e6f8c71ebdbf71d6d486e4136f50) Use list function to generate flag classes - [`71f52ff`](https://github.com/lipis/flag-icons/commit/71f52ff06cb01b1508716015deb237d8614645b9) Extract squared definition into separate mixin - [`633d1cd`](https://github.com/lipis/flag-icons/commit/633d1cd14644c4404db46c77fa6800a4cc8caab6) Create flag clsses using iterator - [`8e12c83`](https://github.com/lipis/flag-icons/commit/8e12c8398e415b166d1cbf3b5071a1c6dc72fe66) Generate 1x1 and 4x3 sizes - [`a3e99ac`](https://github.com/lipis/flag-icons/commit/a3e99ac0325b5b97a041d8a884b5b7891d0bc22b) Build assets ### 📊 Changes **14 files changed** (+2424 additions, -1038 deletions) <details> <summary>View changed files</summary> 📝 `Gruntfile.coffee` (+12 -0) ➕ `css/flag-icon-1x1.css` (+794 -0) ➕ `css/flag-icon-1x1.min.css` (+1 -0) ➕ `css/flag-icon-4x3.css` (+794 -0) ➕ `css/flag-icon-4x3.min.css` (+1 -0) 📝 `css/flag-icon.css` (+773 -773) 📝 `css/flag-icon.min.css` (+1 -1) ➕ `less/flag-icon-1x1.less` (+5 -0) ➕ `less/flag-icon-4x3.less` (+5 -0) 📝 `less/flag-icon-base.less` (+16 -4) ➖ `less/flag-icon-list.less` (+0 -249) ➖ `less/flag-icon-more.less` (+0 -9) 📝 `less/flag-icon.less` (+6 -2) 📝 `less/variables.less` (+16 -0) </details> ### 📄 Description Different flag sizes are used in different contexts; there is rarely a need to include both at the same time. so optimising for load / build time by splitting flag sizes into separate files. There are no changes to existing icon class definitions. In this PR: - Move countries into a list variable. - Generate country css using countries variable. - Introduce `flag-icon-1x1` and `flag-icon-4x3` to be included separately in depended projects. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 14:41:39 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/flag-icons#992
No description provided.