[PR #399] [CLOSED] Fix the greater height of icon #780

New issue

Closed

opened 2026-03-03 14:40:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 14:40:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lipis/flag-icons/pull/399
Author: @AlexWayfer
Created: 10/12/2017
Status: ❌ Closed

Base: master ← Head: fix-height

📝 Commits (1)

91a6b7a Fix the greater height of icon

📊 Changes

4 files changed (+4 additions, -1 deletions)

View changed files

📝 css/flag-icon.css (+1 -0)
📝 css/flag-icon.min.css (+1 -1)
📝 less/flag-icon-base.less (+1 -0)
📝 sass/_flag-icon-base.scss (+1 -0)

📄 Description

It's caused by ::before pseudo-element with display: inline by default,
which ignoring height of its parent (.flag-icon).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lipis/flag-icons/pull/399 **Author:** [@AlexWayfer](https://github.com/AlexWayfer) **Created:** 10/12/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-height` --- ### 📝 Commits (1) - [`91a6b7a`](https://github.com/lipis/flag-icons/commit/91a6b7ad742c44d1cd55b9c307d38015aa752dbc) Fix the greater height of icon ### 📊 Changes **4 files changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `css/flag-icon.css` (+1 -0) 📝 `css/flag-icon.min.css` (+1 -1) 📝 `less/flag-icon-base.less` (+1 -0) 📝 `sass/_flag-icon-base.scss` (+1 -0) </details> ### 📄 Description It's caused by `::before` pseudo-element with `display: inline` by default, which ignoring height of its parent (`.flag-icon`). ![image](https://user-images.githubusercontent.com/6510020/31496245-51422d66-af63-11e7-8498-be4328cb89da.png) ![image](https://user-images.githubusercontent.com/6510020/31496258-648fe296-af63-11e7-87ac-64483a7433e4.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>