[PR #46] [CLOSED] Update .less files to have a partial-style naming convention #648

New issue

Closed

opened 2026-03-03 14:40:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 14:40:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lipis/flag-icons/pull/46
Author: @karlito-who-else
Created: 3/2/2015
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

933973a Update .less files to have a partial-style naming convention in order that they will be bypassed by many popular LESS preprocessors.

📊 Changes

4 files changed (+3 additions, -4 deletions)

View changed files

📝 less/_flag-icon-base.less (+0 -0)
📝 less/_flag-icon-list.less (+0 -0)
📝 less/_variabless.less (+0 -0)
📝 less/flag-icon.less (+3 -4)

📄 Description

Many servers and applications that support LESS compilation will not attempt to compile files prefixed with an underscore character by default - for example, this is the case with Harp, CodeKit, Koala, SimpLESS, etc.

In the case of Harp, which uses a "convention over configuration" approach to ignoring files, it is not possible to serve flag-icon-css if its full codebase is included in the public web root as Harp will attempt to compile variabless.less, flag-icon-base.less and flag-icon-list.less without being aware of their dependencies, and so the entire Harp compilation process will fail.

I realise that my use case is very specific to Harp, and while they do have some tickets open regarding the treatment of vendor code included in a sites bower_components directory, etc, there doesn't seem to be a lot of progress being made. I also feel that this change would generally be beneficial in that it would prevent the need for developers having to manually exclude the files from being compiled in CodeKit, Koala, etc.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lipis/flag-icons/pull/46 **Author:** [@karlito-who-else](https://github.com/karlito-who-else) **Created:** 3/2/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`933973a`](https://github.com/lipis/flag-icons/commit/933973a7ce8787d4e03b62c593d788423f7db56c) Update .less files to have a partial-style naming convention in order that they will be bypassed by many popular LESS preprocessors. ### 📊 Changes **4 files changed** (+3 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `less/_flag-icon-base.less` (+0 -0) 📝 `less/_flag-icon-list.less` (+0 -0) 📝 `less/_variabless.less` (+0 -0) 📝 `less/flag-icon.less` (+3 -4) </details> ### 📄 Description Many servers and applications that support LESS compilation will not attempt to compile files prefixed with an underscore character by default - for example, this is the case with Harp, CodeKit, Koala, SimpLESS, etc. In the case of Harp, which uses a "convention over configuration" approach to ignoring files, it is not possible to serve flag-icon-css if its full codebase is included in the public web root as Harp will attempt to compile variabless.less, flag-icon-base.less and flag-icon-list.less without being aware of their dependencies, and so the entire Harp compilation process will fail. I realise that my use case is very specific to Harp, and while they do have some tickets open regarding the treatment of vendor code included in a sites bower_components directory, etc, there doesn't seem to be a lot of progress being made. I also feel that this change would generally be beneficial in that it would prevent the need for developers having to manually exclude the files from being compiled in CodeKit, Koala, etc. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>