[GH-ISSUE #1364] New Flags (in general) #611

New issue

Closed

opened 2026-03-03 14:39:44 +03:00 by kerem · 1 comment

kerem commented

2026-03-03 14:39:44 +03:00

Owner

Originally created by @p2made on GitHub (May 23, 2025).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/1364

I suggest that some guidelines for PRs that add flags would be helpful. Some house rules if we like...

The first I think of is what flags can be included? I've said elsewhere that I'm big on representation, and flags are a means of representation. With that in mind...

@jagomf That was the whole idea.. but the pressure and we did some decisions to include them because of other reasons! That was the whole point.. we can include them all.. there are millions of flags :)

Originally posted by @lipis in #1183

And yes‼️ I hope we can include them all 🙃 I hope the scope of what flags can be included can be broad enough to allow for a wealth of representation.

The flags of interest to me for my own work are probably a couple of dozen. Adding logical extensions to those (completing the Federal subjects of Russia & Oblasts of Ukraine), & a couple of side quests, and I have well over 100 that I could contribute. I've actually done most of them, & I maintain an extension to flag-icons that makes them available to my work, but that doesn't make them available to others. Adding them to flag-icons would.

Other considerations...

Curation: How should flags submitted in PRs be curated? Logical groupings or collections makes sense to me, although one person's idea of what makes a logical grouping might differ from another's. Also, some logical groupings might be large. There are 83 Federal subjects of Russia & almost 30 Oblasts of Ukraine.

Other work: Should someone submitting flags in a PR also update country.json & _variables.scss (was _flag-icons-list.scss) and recompile the CSS?

Size: I've concluded from looking at existing SVGs that it's 640x480 & 512x512 (I think I've seen a couple of exceptions). Having it explicitly specified would be helpful.

[update]

Optimisation: I've seen since writing the rest that the SVGs appear to be in an optimised & then prettified state, which makes a whole lot of sense. I've developed my own scripted workflow (using svgo) for achieving the same.

There are possibly other considerations that I haven't thought of. I hope this proves helpful.

Originally created by @p2made on GitHub (May 23, 2025). Original GitHub issue: https://github.com/lipis/flag-icons/issues/1364 I suggest that some guidelines for PRs that add flags would be helpful. Some house rules if we like... The first I think of is what flags can be included? I've said elsewhere that I'm big on representation, and flags are a means of representation. With that in mind... > @jagomf That was the whole idea.. but the pressure and we did some decisions to include them because of other reasons! That was the whole point.. we *can* include them all.. there are millions of flags :) _Originally posted by @lipis in [#1183](https://github.com/lipis/flag-icons/issues/1183#issuecomment-2685581681)_ And yes‼️ I hope we can include them all 🙃 I hope the scope of what flags can be included can be broad enough to allow for a wealth of representation. The flags of interest to me for my own work are probably a couple of dozen. Adding logical extensions to those (completing the Federal subjects of Russia & Oblasts of Ukraine), & a couple of side quests, and I have well over 100 that I could contribute. I've actually done most of them, & I maintain an extension to `flag-icons` that makes them available to my work, but that doesn't make them available to others. Adding them to `flag-icons` would. Other considerations... **Curation:** How should flags submitted in PRs be curated? Logical groupings or collections makes sense to me, although one person's idea of what makes a logical grouping might differ from another's. Also, some logical groupings might be large. There are 83 Federal subjects of Russia & almost 30 Oblasts of Ukraine. **Other work:** Should someone submitting flags in a PR also update `country.json` & `_variables.scss` (was `_flag-icons-list.scss`) and recompile the CSS? **Size:** I've concluded from looking at existing SVGs that it's 640x480 & 512x512 (I think I've seen a couple of exceptions). Having it explicitly specified would be helpful. [update] **Optimisation:** I've seen since writing the rest that the SVGs appear to be in an optimised & then prettified state, which makes a whole lot of sense. I've developed my own scripted workflow (using `svgo`) for achieving the same. There are possibly other considerations that I haven't thought of. I hope this proves helpful.