mirror of
https://github.com/lipis/flag-icons.git
synced 2026-04-26 09:25:50 +03:00
[GH-ISSUE #1254] For 1x1 flags, use a different width/height than 512 #578
Labels
No labels
3rd-party
3rd-party
bug
code
documentation
enhancement
fixed-in-master
flag-request
help needed
missing-flag
missing-flag
pull-request
wrong-flag
wrong-flag
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/flag-icons#578
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mpsijm on GitHub (May 30, 2024).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/1254
Not sure if this is desired or feasible, so feel free to close if you think it's not 🙂
When hacking away for #1251, I found it tedious to copy my changes from the 4x3 flags to the 1x1 version and vice versa, because they use different heights. Currently, 4x3 uses a viewBox of 640×480, and 1x1 uses 512×512. For triband flags like
NL, this results in (inaccurate) fractions.One suggestion could be to rescale the 1x1 flags to 480×480. I see several advantages:
However, there are also some disadvantages:
FR), the inaccurate fractions remain in the 4x3 variant, because 640 is not divisible by 3.Regarding feasability: in theory, this can be achieved by adding a
transform=scale(.9375)to all current flags, and use scripting to apply this transformation to all<rect>s and<path>s and what else (for one-off uses, I like to use this Inkscape plugin, but I don't know yet how to automate this for all flags at once). However, there will probably be flags where rounding errors need to be manually checked/corrected, and I'm not sure how well this works for charged flags with small details.I'm curious to hear your opinions on this! 😄
@lipis commented on GitHub (May 30, 2024):
The short answer that we won't do that.. too much effort for all those flags without a clear benefit.. they are not changing that often and It's pretty easy for me to do the changes for new flags.. or updating them!