mirror of
https://github.com/lipis/flag-icons.git
synced 2026-04-26 09:25:50 +03:00
[GH-ISSUE #85] ISO 3166-1 alpha-3 #53
Labels
No labels
3rd-party
3rd-party
bug
code
documentation
enhancement
fixed-in-master
flag-request
help needed
missing-flag
missing-flag
pull-request
wrong-flag
wrong-flag
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/flag-icons#53
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Filoz on GitHub (Jul 14, 2015).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/85
Hi,
great job!
Did you think about add also the ISO 3166-1 alpha-3 code?
It should be not so difficult... something like this:
before:
after
Thankyou!
@lipis commented on GitHub (Jul 14, 2015):
Is it really needed?
@Filoz commented on GitHub (Jul 14, 2015):
I think it could be... and it should not be so difficult to do.
Many people prefer to save in their application alpha-3 code rather then alpha-2.
@Filoz commented on GitHub (Jul 14, 2015):
In order to keep a smaller size for the css file, it could be created a version with only alpha-3 so the user can choose which one to use (alpha-2.css or alpha-3.css).
@lipis commented on GitHub (Sep 4, 2015):
sorry.. too much trouble
@ninjanye commented on GitHub (Sep 11, 2015):
This would be useful to me too. Would you accept a pull request to address this issue? I'd be happy to do it
@lipis commented on GitHub (Sep 11, 2015):
@ninjanye no.. sorry
@Filoz commented on GitHub (Sep 11, 2015):
@ninjanye give a look to this repo: https://github.com/7kfpun/flag-css
@ninjanye commented on GitHub (Sep 14, 2015):
Thanks @Filoz. For what it is worth, I have forked the repo and added all the ISO3166 Alpha-3 characters.
My repository is here: https://github.com/ninjanye/flag-icon-css
The result is as follows:
@mikeclagg commented on GitHub (Sep 23, 2015):
I forked it and converted it to 3 digit last night. Our geolocation uses the 3 digit code. I will also be supporting the 2 digit as well.
@ninjanye commented on GitHub (Sep 23, 2015):
Does that differ from my fork? https://github.com/ninjanye/flag-icon-css
@lipis commented on GitHub (Sep 23, 2015):
@ninjanye yes.. @belikemike's version doesn't support 2-digit code :)
@mikeclagg commented on GitHub (Sep 23, 2015):
Not yet, I needed 3 currently, working on supporting both. I am open to project organization suggestions.
https://github.com/belikemike/flag-icon-css
@ninjanye commented on GitHub (Sep 24, 2015):
Ah, ok. If it helps you, the fork I made already has support for both 2 and 3 digit codes
@mikeclagg commented on GitHub (Sep 24, 2015):
I was confused when because I only saw a few 3 digit svg files. Looking into the last commits I see your approach. Take my flags if you want, but as Lipis pointed out, I am not fan of both at the same time as since we don't use 2 digit codes.
@jgpacheco commented on GitHub (Mar 19, 2018):
Why not merge @ninjanye fork to main repo?
@koesper commented on GitHub (Feb 10, 2021):
Ran into the same problem as well, it seems like @ninjanye's solution is perfect!
Unfortunately that repo is now stale, so merging it here would benefit from the active maintenance, while adding very little complexity!