starred/flag-icons

Fork 0

mirror of https://github.com/lipis/flag-icons.git synced 2026-04-26 09:25:50 +03:00

[GH-ISSUE #1123] Black elements missing fill attribute #526

New issue

Closed

opened 2026-03-03 14:39:02 +03:00 by kerem · 6 comments

kerem commented

2026-03-03 14:39:02 +03:00

Owner

Originally created by @adamdebono on GitHub (Jul 27, 2023).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/1123

Many of the flags have black coloured elements that don't have an explicit fill attribute, instead relying on the default fill colour being black. If another fill colour is set, from CSS or otherwise, these elements don't appear correctly.

For example, the path element for the black rectangle in the Germany flag. https://github.com/lipis/flag-icons/blob/main/flags/4x3/de.svg?short_path=b08334b#L3

Originally created by @adamdebono on GitHub (Jul 27, 2023). Original GitHub issue: https://github.com/lipis/flag-icons/issues/1123 Many of the flags have black coloured elements that don't have an explicit `fill` attribute, instead relying on the default fill colour being black. If another fill colour is set, from CSS or otherwise, these elements don't appear correctly. For example, the path element for the black rectangle in the Germany flag. https://github.com/lipis/flag-icons/blob/main/flags/4x3/de.svg?short_path=b08334b#L3

kerem closed this issue

2026-03-03 14:39:02 +03:00

kerem commented

2026-03-03 14:39:03 +03:00

Author

Owner

@lipis commented on GitHub (Jul 27, 2023):

So what do we do?

@lipis commented on GitHub (Jul 27, 2023): So what do we do?

kerem commented

2026-03-03 14:39:03 +03:00

Author

Owner

@adamdebono commented on GitHub (Jul 27, 2023):

Add explicit fill="#000" to the elements that should be black

@adamdebono commented on GitHub (Jul 27, 2023): Add explicit `fill="#000"` to the elements that should be black

kerem commented

2026-03-03 14:39:03 +03:00

Author

Owner

@lipis commented on GitHub (Jul 27, 2023):

Alright.. how should I start you think.. alphabetically.. by file size.. by continent maybe?

@lipis commented on GitHub (Jul 27, 2023): Alright.. how should I start you think.. alphabetically.. by file size.. by continent maybe?

kerem commented

2026-03-03 14:39:03 +03:00

Author

Owner

@adamdebono commented on GitHub (Jul 28, 2023):

Geographically, North to South and West to East 😂

I'm in the middle of a big project right now but am happy to help out once I get time. This isn't a blocker for me right now so not a huge rush.

@adamdebono commented on GitHub (Jul 28, 2023): Geographically, North to South and West to East 😂 I'm in the middle of a big project right now but am happy to help out once I get time. This isn't a blocker for me right now so not a huge rush.

kerem commented

2026-03-03 14:39:03 +03:00

Author

Owner

@lipis commented on GitHub (Jul 28, 2023):

OK.. I'm glad you took it as a joke.. cause I really have no idea where to start and how to deal with it! There is no rush for sure.. but if you're about to do it.. let's start with couple of flags to see how it goes.. I prefer smaller PR than doing something massive on bunch of files!

@lipis commented on GitHub (Jul 28, 2023): OK.. I'm glad you took it as a joke.. cause I really have no idea where to start and how to deal with it! There is no rush for sure.. but if you're about to do it.. let's start with couple of flags to see how it goes.. I prefer smaller PR than doing something massive on bunch of files!

kerem commented

2026-03-03 14:39:03 +03:00

Author

Owner

@adamdebono commented on GitHub (Nov 27, 2023):

I've finally got around to this, I've started with the ISO codes beginning with a and b.

https://github.com/lipis/flag-icons/pull/1187

@adamdebono commented on GitHub (Nov 27, 2023): I've finally got around to this, I've started with the ISO codes beginning with a and b. https://github.com/lipis/flag-icons/pull/1187

kerem referenced this issue

2026-03-03 14:41:00 +03:00

[PR #526] [MERGED] Bump lint-staged from 8.1.0 to 8.1.1 #841