[GH-ISSUE #1016] Almost all colors are still wrong/too bright #474

Closed
opened 2026-03-03 14:38:38 +03:00 by kerem · 10 comments
Owner

Originally created by @Danny-Engelman on GitHub (Jul 2, 2022).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/1016

Lipis repo is the last column:

Originally created by @Danny-Engelman on GitHub (Jul 2, 2022). Original GitHub issue: https://github.com/lipis/flag-icons/issues/1016 Lipis repo is the last column: ![](https://i.imgur.com/t2L5mxb.png) ![](https://i.imgur.com/xjpxzLK.png) ![](https://i.imgur.com/zzJ0p2A.png)
kerem closed this issue 2026-03-03 14:38:38 +03:00
Author
Owner

@NotTsunami commented on GitHub (Jul 2, 2022):

Can you link the resource this is from? Found it

<!-- gh-comment-id:1172922647 --> @NotTsunami commented on GitHub (Jul 2, 2022): ~~Can you link the resource this is from?~~ Found it
Author
Owner

@lipis commented on GitHub (Jul 4, 2022):

This is very general.. most of the flags and colors over time are taken from Wikipedia flags! You can submit requests per flag.. as a general comment is very hard to see what needs to be updated.

<!-- gh-comment-id:1173675636 --> @lipis commented on GitHub (Jul 4, 2022): This is very general.. most of the flags and colors over time are taken from Wikipedia flags! You can submit requests per flag.. as a general comment is very hard to see what needs to be updated.
Author
Owner

@lipis commented on GitHub (Jul 4, 2022):

Can you share the link? can't find it

<!-- gh-comment-id:1173686419 --> @lipis commented on GitHub (Jul 4, 2022): Can you share the link? can't find it
Author
Owner

@Danny-Engelman commented on GitHub (Jul 5, 2022):

Every flag repo has errors. But yours looks like some filter was used.

Flag analyzer from different repos on: https://flagmeister.github.io/?#repoanalyzer

<!-- gh-comment-id:1175057817 --> @Danny-Engelman commented on GitHub (Jul 5, 2022): Every flag repo has errors. But yours looks like some filter was used. Flag analyzer from different repos on: https://flagmeister.github.io/?#repoanalyzer
Author
Owner

@lipis commented on GitHub (Jul 7, 2022):

Not sure if that's the case, but I added an issue to use the latest flags from this repo.. (flagmeister seems that is using the flag-icon-css version) https://github.com/flagmeister/flagmeister.github.io/issues/3

As for this issue.. I really can't just update all flags with some magical script to correct them.. Most flags that had issues we were taking them from Wikipedia.. which we are using as source of truth!

<!-- gh-comment-id:1177489437 --> @lipis commented on GitHub (Jul 7, 2022): Not sure if that's the case, but I added an issue to use the latest flags from this repo.. (flagmeister seems that is using the `flag-icon-css` version) https://github.com/flagmeister/flagmeister.github.io/issues/3 As for this issue.. I really can't just update all flags with some magical script to correct them.. Most flags that had issues we were taking them from Wikipedia.. which we are using as source of truth!
Author
Owner

@Danny-Engelman commented on GitHub (Jul 7, 2022):

You are not using the correct WikiMedia South African flag:
(WikiPedia links to WikiMedia for all flags)

https://upload.wikimedia.org/wikipedia/commons/a/af/Flag_of_South_Africa.svg

<svg xmlns="http://www.w3.org/2000/svg" width="400" height="267" viewBox="0 0 800 534">
  <rect x="0" y="0" width="100%" height="100%" fill="#000C8A" />
  <rect x="0" y="0" width="100%" height="50%" fill="#E1392D" />
  <path d="M 0,0 l 160,0 l 266,178 l 374,0 l 0,178 l -374,0 l -266,178 l -160,0 z" fill="#FFFFFF" />
  <path d="M 0,0 l 97 ,0 l 318,213 l 385,0 l 0,108 l -385,0 l -318,213 l -97,0 z" fill="#007847" />
  <path d="M 0,65 l 304,202 l -304,202 z" fill="#FFB915" />
  <path d="M 0,107 l 240,160 l -240,160 z" fill="#000000" />
</svg>

https://raw.githubusercontent.com/lipis/flag-icons/main/flags/4x3/za.svg

<svg xmlns="http://www.w3.org/2000/svg" id="flag-icons-za" viewBox="0 0 640 480">
  <defs>
    <clipPath id="a">
      <path fill-opacity=".7" d="M-71.9 0h682.7v512H-71.9z"/>
    </clipPath>
  </defs>
  <g clip-path="url(#a)" transform="translate(67.4) scale(.93748)">
    <g fill-rule="evenodd" stroke-width="1pt">
      <path d="M-71.9 407.8V104.4L154 256.1-72 407.8z"/>
      <path fill="#00c" d="m82.2 512.1 253.6-170.6H696V512H82.2z"/>
      <path fill="red" d="M66 0h630v170.8H335.7S69.3-1.7 66 0z"/>
      <path fill="#fc0" d="M-71.9 64v40.4L154 256-72 407.8v40.3l284.5-192L-72 64z"/>
      <path fill="#093" d="M-71.9 64V0h95l301.2 204h371.8v104.2H324.3L23 512h-94.9v-63.9l284.4-192L-71.8 64z"/>
      <path fill="#fff" d="M23 0h59.2l253.6 170.7H696V204H324.3L23 .1zm0 512.1h59.2l253.6-170.6H696v-33.2H324.3L23 512z"/>
    </g>
  </g>
</svg>
<!-- gh-comment-id:1177556383 --> @Danny-Engelman commented on GitHub (Jul 7, 2022): You are not using the correct WikiMedia South African flag: (WikiPedia links to WikiMedia for all flags) #### https://upload.wikimedia.org/wikipedia/commons/a/af/Flag_of_South_Africa.svg ``` <svg xmlns="http://www.w3.org/2000/svg" width="400" height="267" viewBox="0 0 800 534"> <rect x="0" y="0" width="100%" height="100%" fill="#000C8A" /> <rect x="0" y="0" width="100%" height="50%" fill="#E1392D" /> <path d="M 0,0 l 160,0 l 266,178 l 374,0 l 0,178 l -374,0 l -266,178 l -160,0 z" fill="#FFFFFF" /> <path d="M 0,0 l 97 ,0 l 318,213 l 385,0 l 0,108 l -385,0 l -318,213 l -97,0 z" fill="#007847" /> <path d="M 0,65 l 304,202 l -304,202 z" fill="#FFB915" /> <path d="M 0,107 l 240,160 l -240,160 z" fill="#000000" /> </svg> ``` #### https://raw.githubusercontent.com/lipis/flag-icons/main/flags/4x3/za.svg ``` <svg xmlns="http://www.w3.org/2000/svg" id="flag-icons-za" viewBox="0 0 640 480"> <defs> <clipPath id="a"> <path fill-opacity=".7" d="M-71.9 0h682.7v512H-71.9z"/> </clipPath> </defs> <g clip-path="url(#a)" transform="translate(67.4) scale(.93748)"> <g fill-rule="evenodd" stroke-width="1pt"> <path d="M-71.9 407.8V104.4L154 256.1-72 407.8z"/> <path fill="#00c" d="m82.2 512.1 253.6-170.6H696V512H82.2z"/> <path fill="red" d="M66 0h630v170.8H335.7S69.3-1.7 66 0z"/> <path fill="#fc0" d="M-71.9 64v40.4L154 256-72 407.8v40.3l284.5-192L-72 64z"/> <path fill="#093" d="M-71.9 64V0h95l301.2 204h371.8v104.2H324.3L23 512h-94.9v-63.9l284.4-192L-71.8 64z"/> <path fill="#fff" d="M23 0h59.2l253.6 170.7H696V204H324.3L23 .1zm0 512.1h59.2l253.6-170.6H696v-33.2H324.3L23 512z"/> </g> </g> </svg> ```
Author
Owner

@lipis commented on GitHub (Jul 7, 2022):

I created a new issue for South Africa.. if you find more specific errors.. please file as a new issue per flag to keep track of them! Thank you.

<!-- gh-comment-id:1177585561 --> @lipis commented on GitHub (Jul 7, 2022): I created a new issue for South Africa.. if you find more specific errors.. please file as a new issue per flag to keep track of them! Thank you.
Author
Owner

@chantouchsek commented on GitHub (Jul 25, 2022):

https://github.com/lipis/flag-icons/issues/1021

<!-- gh-comment-id:1194296792 --> @chantouchsek commented on GitHub (Jul 25, 2022): https://github.com/lipis/flag-icons/issues/1021
Author
Owner

@NotTsunami commented on GitHub (Jul 25, 2022):

Screenshot_20220725-121208

KM refers to another country in ISO 3166, which already exists in this project. This would cause a plethora of issues if we mixed and matched standards.

<!-- gh-comment-id:1194307821 --> @NotTsunami commented on GitHub (Jul 25, 2022): ![Screenshot_20220725-121208](https://user-images.githubusercontent.com/4589807/180825422-896ed679-8ef8-481c-89a9-d6d3d69d01c2.png) KM refers to another country in ISO 3166, which already exists in this project. This would cause a plethora of issues if we mixed and matched standards.
Author
Owner

@chantouchsek commented on GitHub (Jul 26, 2022):

@NotTsunami yes, i had no idea, but because it's being used in another where else, that make the confusion.

<!-- gh-comment-id:1194883666 --> @chantouchsek commented on GitHub (Jul 26, 2022): @NotTsunami yes, i had no idea, but because it's being used in another where else, that make the confusion.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/flag-icons#474
No description provided.