[GH-ISSUE #945] fail some postinstall check of electron-react-boilerplate #450

Closed
opened 2026-03-03 14:38:28 +03:00 by kerem · 1 comment
Owner

Originally created by @seiry on GitHub (Mar 19, 2022).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/945

When running the build check after adding the package to a project created by https://github.com/electron-react-boilerplate, an error will occur.

for there is a dep package check in the postinstall.

github.com/electron-react-boilerplate/electron-react-boilerplate@8aa6ff54cf/.erb/configs/webpack.config.renderer.dev.dll.ts (L34)

  entry: {
    renderer: Object.keys(dependencies || {}),
  },

For there's no main filed in the package.json, and according the the doc [https://docs.npmjs.com/cli/v8/configuring-npm/package-json#main], it will be index.js in default.

If main is not set it defaults to index.js in the package's root folder.

And, obviously, there's no index,js.

Originally created by @seiry on GitHub (Mar 19, 2022). Original GitHub issue: https://github.com/lipis/flag-icons/issues/945 When running the build check after adding the package to a project created by `https://github.com/electron-react-boilerplate`, an error will occur. <img width="600" alt="" src="https://user-images.githubusercontent.com/4397354/159120025-2ce795c9-773d-4092-9587-4e96bfad2522.png"> for there is a dep package check in the `postinstall`. https://github.com/electron-react-boilerplate/electron-react-boilerplate/blob/8aa6ff54cf9127e17c6956b54ab2d237096ec383/.erb/configs/webpack.config.renderer.dev.dll.ts#L34 ```js entry: { renderer: Object.keys(dependencies || {}), }, ``` For there's no `main` filed in the `package.json`, and according the the doc [https://docs.npmjs.com/cli/v8/configuring-npm/package-json#main], it will be `index.js` in default. > If main is not set it defaults to index.js in the package's root folder. And, obviously, there's no `index,js`.
kerem closed this issue 2026-03-03 14:38:28 +03:00
Author
Owner

@seiry commented on GitHub (Mar 19, 2022):

I've created a pr to fix

<!-- gh-comment-id:1072997667 --> @seiry commented on GitHub (Mar 19, 2022): I've created a pr to fix
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/flag-icons#450
No description provided.