mirror of
https://github.com/lipis/flag-icons.git
synced 2026-04-26 09:25:50 +03:00
[GH-ISSUE #895] Bundle size improvements #423
Labels
No labels
3rd-party
3rd-party
bug
code
documentation
enhancement
fixed-in-master
flag-request
help needed
missing-flag
missing-flag
pull-request
wrong-flag
wrong-flag
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/flag-icons#423
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @AmitMY on GitHub (Dec 6, 2021).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/895
The entire bundle size of the SASS, compiled with angular, is around 46kb.
You are allowing a selection of flags, which is great to reduce that size, but there are other avenues to take:
.flag-icon-xxto.fi-xx,.flag-icon-xx.flag-icon-squaredto.fis-xx(18% saving, uncompressed)@lipis commented on GitHub (Dec 23, 2021):
What do you think of #902?
@AmitMY commented on GitHub (Dec 23, 2021):
Thanks, @lipis
It indeed addresses all concerns of item number 2
An additional check of a new variable to control for which sizes exist (square vs original vs both) in this selector - https://github.com/lipis/flag-icons/pull/902/files#diff-1348f29469a605362817463cf4721b696c6c8b6b5740f0ab4e2fe3577f5fd8ceR21 would address the concerns in item number 1.
I appreciate your effort towards this important goal :)
FYI:
before #902, the min.css file is 34.8kb. after it is 27.3kb.
Download savings are around 35ms on the mobile standard of 1.6Mbps.
@lipis commented on GitHub (Dec 28, 2021):
I'll go ahead and merge this and leave the 1.. cause we are delivering the sources as well and if people want it they can easily use that instead of the css files..