[GH-ISSUE #891] Incompatibility with node-sass #421

New issue

Closed

opened 2026-03-03 14:38:17 +03:00 by kerem · 2 comments

kerem commented

2026-03-03 14:38:17 +03:00

Owner

Originally created by @Donov4n on GitHub (Nov 24, 2021).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/891

Hello everyone :)

The change introduced in https://github.com/lipis/flag-icons/pull/838 prevent all users using node-sass on legacy projects to update to the latest version of flag-icon-css.
Maybe a solution like the bootstrap one (or a 1.33 multiplication instead of the 4 / 3 division if the tiny loss of precision is acceptable) would have been a better move for everyone ?

See also:

Originally created by @Donov4n on GitHub (Nov 24, 2021). Original GitHub issue: https://github.com/lipis/flag-icons/issues/891 Hello everyone :) The change introduced in https://github.com/lipis/flag-icons/pull/838 prevent all users using `node-sass` on legacy projects to update to the latest version of `flag-icon-css`. Maybe a solution like the [bootstrap](https://github.com/twbs/bootstrap/blob/v5.1.3/scss/vendor/_rfs.scss#L55) one (or a `1.33` multiplication instead of the `4 / 3` division if the tiny loss of precision is acceptable) would have been a better move for everyone ? See also: - https://github.com/twbs/bootstrap/pull/34245 - https://github.com/FortAwesome/Font-Awesome/pull/17940#issuecomment-901216145